From a00b4199eb08dacdbb81a8aecc15e8f28833db53 Mon Sep 17 00:00:00 2001 From: l0lawrence Date: Thu, 16 Oct 2025 14:00:20 -0700 Subject: [PATCH 01/11] prompt --- .../check-package-validation.instructions.md | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 eng/common/instructions/azsdk-tools/check-package-validation.instructions.md diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md new file mode 100644 index 000000000000..4ea9d3d804c9 --- /dev/null +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -0,0 +1,38 @@ +--- +description: 'Check if the package pr checks and/or validation has passed for the SDK package.' +--- +## Goal +Check the PR and Validation checks for the SDK package by collecting the required information from the user and executing the run_check command. + +## Instructions +1. **Collect Required Information**: + - Prompt the user for the exact package name + - Prompt the user to select the programming language from the following options (case sensitive): + - Python + - Java + - JavaScript + - .NET + - Go + - Prompt the user to select the check type to run (default to "all" if not specified): + - all + - linting + - format + - changelog + - cspell + - readme + + +2. **Execute Readiness Check**: + - Use the `azsdk_package_run_check` tool with the package path and check type. + - If the package path is not provided, use the package name and language to determine the package path for each language and prompt the user to confirm the path before proceeding. + + +3. **Present Results**: + - If the package has passed all validation checks, highlight and finish + - If the package is not ready, display the specific check types that need to be fixed for each language. + +## Expected User Interaction Flow +1. Ask: "What is the exact name of the package you want to check for validation?" +2. Ask: "Please select the programming language for this package: Python, Java, JavaScript, .NET, Go, or All" +3. Execute the check using the provided information +4. Display results and next steps \ No newline at end of file From fb1fa6f34209fc6d01299841a3a9fee3f0f0b53d Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Thu, 23 Oct 2025 08:48:38 -0700 Subject: [PATCH 02/11] this --- .../check-package-validation.instructions.md | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index 4ea9d3d804c9..afd4244c7e10 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -1,8 +1,8 @@ --- -description: 'Check if the package pr checks and/or validation has passed for the SDK package.' +description: 'Check if the package validation checks have passed for the SDK package.' --- ## Goal -Check the PR and Validation checks for the SDK package by collecting the required information from the user and executing the run_check command. +Check the validation checks for the SDK package by collecting the required information from the user and executing the run_check command. ## Instructions 1. **Collect Required Information**: @@ -15,14 +15,19 @@ Check the PR and Validation checks for the SDK package by collecting the require - Go - Prompt the user to select the check type to run (default to "all" if not specified): - all - - linting - - format - changelog - - cspell + - dependency - readme + - cspell + - snippets + - linting + - format + - checkaotcompat + - generatedcodechecks + - samples -2. **Execute Readiness Check**: +2. **Execute Check**: - Use the `azsdk_package_run_check` tool with the package path and check type. - If the package path is not provided, use the package name and language to determine the package path for each language and prompt the user to confirm the path before proceeding. From b666f8dd9bad56312bfb7b0e1f7b17c6bbe1bb13 Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Thu, 23 Oct 2025 08:49:02 -0700 Subject: [PATCH 03/11] line --- .../azsdk-tools/check-package-validation.instructions.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index afd4244c7e10..5fb446a37934 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -26,12 +26,10 @@ Check the validation checks for the SDK package by collecting the required infor - generatedcodechecks - samples - 2. **Execute Check**: - Use the `azsdk_package_run_check` tool with the package path and check type. - If the package path is not provided, use the package name and language to determine the package path for each language and prompt the user to confirm the path before proceeding. - 3. **Present Results**: - If the package has passed all validation checks, highlight and finish - If the package is not ready, display the specific check types that need to be fixed for each language. From d20f76a4a929d9b51e1e31af2bc72cea051d839c Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Thu, 23 Oct 2025 12:41:42 -0700 Subject: [PATCH 04/11] update bens suggestions --- .../check-package-validation.instructions.md | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index 5fb446a37934..f963e16c1d34 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -2,7 +2,7 @@ description: 'Check if the package validation checks have passed for the SDK package.' --- ## Goal -Check the validation checks for the SDK package by collecting the required information from the user and executing the run_check command. +Check the validation checks for the SDK package by collecting the required information from the user and executing the azsdk_package_run_check command. ## Instructions 1. **Collect Required Information**: @@ -13,18 +13,7 @@ Check the validation checks for the SDK package by collecting the required infor - JavaScript - .NET - Go - - Prompt the user to select the check type to run (default to "all" if not specified): - - all - - changelog - - dependency - - readme - - cspell - - snippets - - linting - - format - - checkaotcompat - - generatedcodechecks - - samples + - Prompt the user specify values for each of the parameters required by the azsdk_package_run_check tool. Present the user with options to pick from for the allowed values specified by the parameter schema. 2. **Execute Check**: - Use the `azsdk_package_run_check` tool with the package path and check type. From 66dc1e1544116e9a6904e8d9b2e37b24d19406de Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Wed, 29 Oct 2025 09:28:05 -0700 Subject: [PATCH 05/11] update --- .../azsdk-tools/check-package-validation.instructions.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index f963e16c1d34..d6f2f2061378 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -6,13 +6,7 @@ Check the validation checks for the SDK package by collecting the required infor ## Instructions 1. **Collect Required Information**: - - Prompt the user for the exact package name - - Prompt the user to select the programming language from the following options (case sensitive): - - Python - - Java - - JavaScript - - .NET - - Go + - Prompt the user for the absolute package path to the package directory for the SDK package they want to check. - Prompt the user specify values for each of the parameters required by the azsdk_package_run_check tool. Present the user with options to pick from for the allowed values specified by the parameter schema. 2. **Execute Check**: From bd32fedaca05fdfbfb8d9720e682ef7f35f9367c Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Wed, 29 Oct 2025 09:30:20 -0700 Subject: [PATCH 06/11] remove try to find pkg path logic --- .../azsdk-tools/check-package-validation.instructions.md | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index d6f2f2061378..2a79bd30b501 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -11,7 +11,6 @@ Check the validation checks for the SDK package by collecting the required infor 2. **Execute Check**: - Use the `azsdk_package_run_check` tool with the package path and check type. - - If the package path is not provided, use the package name and language to determine the package path for each language and prompt the user to confirm the path before proceeding. 3. **Present Results**: - If the package has passed all validation checks, highlight and finish From 6f276415fbbbfeba637c427c2bfc706d9ae74790 Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Thu, 30 Oct 2025 14:35:50 -0700 Subject: [PATCH 07/11] Update eng/common/instructions/azsdk-tools/check-package-validation.instructions.md Co-authored-by: Ben Broderick Phillips --- .../azsdk-tools/check-package-validation.instructions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index 2a79bd30b501..c3fb9f84a291 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -2,7 +2,7 @@ description: 'Check if the package validation checks have passed for the SDK package.' --- ## Goal -Check the validation checks for the SDK package by collecting the required information from the user and executing the azsdk_package_run_check command. +Check the validation checks for the SDK package by collecting the required information from the user and executing the `azsdk_package_run_check` tool. ## Instructions 1. **Collect Required Information**: From d120695c0f3e9203534cb60d37923cb04b3353af Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Fri, 31 Oct 2025 10:59:30 -0700 Subject: [PATCH 08/11] path --- .../azsdk-tools/check-package-validation.instructions.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index c3fb9f84a291..e1de0fd9141a 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -17,7 +17,6 @@ Check the validation checks for the SDK package by collecting the required infor - If the package is not ready, display the specific check types that need to be fixed for each language. ## Expected User Interaction Flow -1. Ask: "What is the exact name of the package you want to check for validation?" -2. Ask: "Please select the programming language for this package: Python, Java, JavaScript, .NET, Go, or All" +1. Ask: "What is the exact path of the package you want to check for validation?" 3. Execute the check using the provided information 4. Display results and next steps \ No newline at end of file From 8cb814d755c2d1120c16245b6013630091195221 Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Fri, 31 Oct 2025 12:30:24 -0700 Subject: [PATCH 09/11] updates --- .../azsdk-tools/check-package-validation.instructions.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index e1de0fd9141a..507d4661355b 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -1,13 +1,13 @@ --- -description: 'Check if the package validation checks have passed for the SDK package.' +description: 'Run the package validation checks for the SDK package.' --- ## Goal -Check the validation checks for the SDK package by collecting the required information from the user and executing the `azsdk_package_run_check` tool. +Run the validation checks for the SDK package by collecting the required information from the user and executing the `azsdk_package_run_check` tool. ## Instructions 1. **Collect Required Information**: - Prompt the user for the absolute package path to the package directory for the SDK package they want to check. - - Prompt the user specify values for each of the parameters required by the azsdk_package_run_check tool. Present the user with options to pick from for the allowed values specified by the parameter schema. + - Prompt the user to specify values for each of the parameters required by the azsdk_package_run_check tool. Present the user with options to pick from for the allowed values specified by the parameter schema. 2. **Execute Check**: - Use the `azsdk_package_run_check` tool with the package path and check type. From 3ead0b167567d687bc9cdd7a8a3f7324ef547859 Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Mon, 3 Nov 2025 08:51:15 -0800 Subject: [PATCH 10/11] list numbering incorrect --- .../azsdk-tools/check-package-validation.instructions.md | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index 507d4661355b..290982fd6681 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -18,5 +18,6 @@ Run the validation checks for the SDK package by collecting the required informa ## Expected User Interaction Flow 1. Ask: "What is the exact path of the package you want to check for validation?" +2. Ask: "Please specify the check type you want to run (e.g., 'all', 'lint', 'format', etc.)" 3. Execute the check using the provided information 4. Display results and next steps \ No newline at end of file From bc4a93dd7cbe760f81b5c03d15f93057d19c2fa6 Mon Sep 17 00:00:00 2001 From: Libba Lawrence Date: Mon, 3 Nov 2025 08:52:35 -0800 Subject: [PATCH 11/11] linting --- .../azsdk-tools/check-package-validation.instructions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md index 290982fd6681..8a1238c81f09 100644 --- a/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md +++ b/eng/common/instructions/azsdk-tools/check-package-validation.instructions.md @@ -18,6 +18,6 @@ Run the validation checks for the SDK package by collecting the required informa ## Expected User Interaction Flow 1. Ask: "What is the exact path of the package you want to check for validation?" -2. Ask: "Please specify the check type you want to run (e.g., 'all', 'lint', 'format', etc.)" +2. Ask: "Please specify the check type you want to run (e.g., 'all', 'linting', 'format', etc.)" 3. Execute the check using the provided information 4. Display results and next steps \ No newline at end of file