Skip to content

Sync eng/common directory with azure-sdk-tools for PR 8463 #30091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8463 #30091

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad51041
Fix case where changelog wasn't marked as invalid
weshaggard Jun 17, 2024
84d54c8
Update CHANGELOG.md
weshaggard Jun 18, 2024
2fe6634
Update CHANGELOG.md
weshaggard Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions eng/common/scripts/ChangeLog-Operations.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ function Remove-EmptySections {
{
$parsedSections = $ChangeLogEntry.Sections
$sanitizedReleaseContent = New-Object System.Collections.ArrayList(,$releaseContent)
foreach ($key in @($parsedSections.Keys))

foreach ($key in @($parsedSections.Keys))
{
if ([System.String]::IsNullOrWhiteSpace($parsedSections[$key]))
{
Expand Down Expand Up @@ -442,9 +442,10 @@ function Confirm-ChangeLogForRelease {
if (!$foundRecommendedSection)
{
$ChangeLogStatus.Message = "The changelog entry did not contain any of the recommended sections ($($RecommendedSectionHeaders -join ', ')), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info."
$ChangeLogStatus.IsValid = $false
if (!$SuppressErrors) {
LogError "$($ChangeLogStatus.Message)"
}
}
return $ChangeLogStatus.IsValid
}
}
1 change: 1 addition & 0 deletions sdk/template/template/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 1.0.10-beta.1 (2020-11-16)

### Features Added
- Test Release Pipeline

## 1.0.9-beta.13 (2020-10-13)
Expand Down