Skip to content

Conversation

@jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented May 20, 2024

No description provided.

Reacts to test-credential changes.

While at it I also reduced waiting time for playback mode.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 20, 2024
@jeremymeng jeremymeng requested a review from kazrael2119 May 20, 2024 19:40
@jeremymeng
Copy link
Member Author

has been fixed by #30021

@jeremymeng jeremymeng closed this Jun 13, 2024
@jeremymeng jeremymeng changed the title [test][mgmt] fix rush build [test][arm-newrelicobservability] reduce playback test time Jun 13, 2024
@jeremymeng jeremymeng reopened this Jun 13, 2024
@jeremymeng
Copy link
Member Author

@kazrael2119 please take a look. thanks!

);
assert.equal(res.name, resourcename);
await delay(100000);
await delay(isPlaybackMode() ? 1000 : 100000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazrael2119 Could check any other places have similar issue and then fix them?

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremymeng
Copy link
Member Author

/check-enforcer override

@jeremymeng jeremymeng closed this Jun 18, 2024
@jeremymeng jeremymeng reopened this Jun 18, 2024
@jeremymeng jeremymeng merged commit 62f2664 into Azure:main Jun 18, 2024
@jeremymeng jeremymeng deleted the test-fix-build branch June 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants