From 8a7d19e6f66e58e3d222ce2dfad3c6ce42e59cf5 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Wed, 6 Mar 2024 09:14:40 -0800 Subject: [PATCH 1/5] [identity] Use tsx for tests --- sdk/identity/identity/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json index 6e43a6680f93..11ebb373b7bd 100644 --- a/sdk/identity/identity/package.json +++ b/sdk/identity/identity/package.json @@ -55,7 +55,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test:browser": "echo skipped", - "integration-test:node": "dev-tool run test:node-ts-input -- --timeout 180000 'test/public/node/*.spec.ts' 'test/internal/node/*.spec.ts'", + "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/**/node/*.spec.js'", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]", "lint": "eslint package.json api-extractor.json src test --ext .ts", @@ -64,8 +64,8 @@ "test:node": "npm run clean && npm run build:test && npm run unit-test:node && npm run integration-test:node", "test": "npm run clean && npm run build:test && npm run unit-test && npm run integration-test", "unit-test:browser": "dev-tool run test:browser", - "unit-test:node": "dev-tool run test:node-ts-input -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", - "unit-test:node:no-timeouts": "dev-tool run test:node-ts-input -- --timeout Infinite --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", + "unit-test:node": "dev-tool run test:node-tsx-ts -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", + "unit-test:node:no-timeouts": "dev-tool run test:node-tsx-ts -- --timeout Infinite --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", "unit-test": "npm run unit-test:node && npm run unit-test:browser" }, "files": [ From b25592436649d5446c2319a4a62ab31aa681bd0a Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Wed, 6 Mar 2024 20:13:49 -0800 Subject: [PATCH 2/5] filtering --- sdk/identity/identity/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json index 11ebb373b7bd..d8ba556d9731 100644 --- a/sdk/identity/identity/package.json +++ b/sdk/identity/identity/package.json @@ -55,7 +55,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test:browser": "echo skipped", - "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/**/node/*.spec.js'", + "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]", "lint": "eslint package.json api-extractor.json src test --ext .ts", From 0d3ffd93135bf475b8708c3508af6f314b0c1448 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Wed, 6 Mar 2024 20:51:58 -0800 Subject: [PATCH 3/5] we need to run isomorphic tests too --- sdk/identity/identity/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json index d8ba556d9731..6d265527995b 100644 --- a/sdk/identity/identity/package.json +++ b/sdk/identity/identity/package.json @@ -55,7 +55,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test:browser": "echo skipped", - "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", + "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 --exclude 'dist-esm/**/browser/**/*.spec.js' 'dist-esm/**/**/*.spec.js'", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]", "lint": "eslint package.json api-extractor.json src test --ext .ts", From 3e28f7ebbbfe9c908f35357a58e7519b9b8b43ce Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Wed, 6 Mar 2024 23:57:22 -0800 Subject: [PATCH 4/5] Revert "we need to run isomorphic tests too" This reverts commit 0d3ffd93135bf475b8708c3508af6f314b0c1448. --- sdk/identity/identity/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json index 6d265527995b..d8ba556d9731 100644 --- a/sdk/identity/identity/package.json +++ b/sdk/identity/identity/package.json @@ -55,7 +55,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test:browser": "echo skipped", - "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 --exclude 'dist-esm/**/browser/**/*.spec.js' 'dist-esm/**/**/*.spec.js'", + "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]", "lint": "eslint package.json api-extractor.json src test --ext .ts", From 6390dd5e4b51a541868911c6e0126bb8af30849f Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Thu, 7 Mar 2024 01:39:02 -0800 Subject: [PATCH 5/5] we can actually safely use node-js-input now --- sdk/identity/identity/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json index d8ba556d9731..1426accbb5f7 100644 --- a/sdk/identity/identity/package.json +++ b/sdk/identity/identity/package.json @@ -55,7 +55,7 @@ "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"", "integration-test:browser": "echo skipped", - "integration-test:node": "dev-tool run test:node-tsx-js -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", + "integration-test:node": "dev-tool run test:node-js-input -- --timeout 180000 'dist-esm/test/public/node/*.spec.js' 'dist-esm/test/internal/node/*.spec.js'", "integration-test": "npm run integration-test:node && npm run integration-test:browser", "lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]", "lint": "eslint package.json api-extractor.json src test --ext .ts", @@ -64,8 +64,8 @@ "test:node": "npm run clean && npm run build:test && npm run unit-test:node && npm run integration-test:node", "test": "npm run clean && npm run build:test && npm run unit-test && npm run integration-test", "unit-test:browser": "dev-tool run test:browser", - "unit-test:node": "dev-tool run test:node-tsx-ts -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", - "unit-test:node:no-timeouts": "dev-tool run test:node-tsx-ts -- --timeout Infinite --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", + "unit-test:node": "dev-tool run test:node-ts-input -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", + "unit-test:node:no-timeouts": "dev-tool run test:node-ts-input -- --timeout Infinite --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", "unit-test": "npm run unit-test:node && npm run unit-test:browser" }, "files": [