Skip to content

Chat preview6: Add Chat Message Tags Support #14973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juancamilor merged 13 commits into from
Apr 28, 2021
Merged

Chat preview6: Add Chat Message Tags Support #14973

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b24a06c
update to preview 6
LuChen-Microsoft Apr 9, 2021
1c3bce2
update to preview 6
LuChen-Microsoft Apr 9, 2021
ac3c828
Merge branch 'chat-preview6' of https://github.com/LuChen-Microsoft/a…
LuChen-Microsoft Apr 21, 2021
a09022d
update swagger file & tests
LuChen-Microsoft Apr 21, 2021
22754b4
update to preview 6
LuChen-Microsoft Apr 9, 2021
300c769
update swagger file & tests
LuChen-Microsoft Apr 21, 2021
a0f2d88
Merge branch 'chat-preview6' of https://github.com/LuChen-Microsoft/a…
LuChen-Microsoft Apr 21, 2021
92b085e
change properties format
LuChen-Microsoft Apr 26, 2021
d6bf4a9
format the code
LuChen-Microsoft Apr 26, 2021
f9be0de
add package version
LuChen-Microsoft Apr 26, 2021
262fd32
remove RestUpdateMessageOptions from exposed api
LuChen-Microsoft Apr 27, 2021
28abaf2
Merge remote-tracking branch 'origin/master' into chat-preview6
LuChen-Microsoft Apr 28, 2021
911a105
update package version to 1.1.0-beta.1
LuChen-Microsoft Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/communication/communication-chat/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release History

## 1.0.2 (Unreleased)
Copy link
Member Author

@LuChen-Microsoft LuChen-Microsoft Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the version number. Would like some suggestions here. @xirzec @DominikMe @juancamilor

Copy link
Member

@xirzec xirzec Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pedantic SemVer would have it be a minor bump (1.1.x) for any feature additions and a patch bump only for fixes that don't change public surface (1.0.x).

However, in practice we don't always bump the minor number every time we add new surface, usually it's more when we make a substantial change (or have some new feature we want to do a beta release for.)

Copy link
Member

@DominikMe DominikMe Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The swagger is now a -preview version, so should this have a beta suffix like in 1.1.0-beta.1?

Leaving it up to Jeff about the minor bump. I tend to follow semver and would bump it, but ideally we could have more changes. How far along is enabling real-time notifications for browser?

Copy link
Member

@xirzec xirzec Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings one way or the other. I'm totally fine with following semver to the letter if that works for you.

Copy link
Member

@DominikMe DominikMe Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is that we have a GA version referencing a beta swagger
tag: package-chat-2021-04-05-preview6

I think we have to fix that?
@juancamilor @LuChen-Microsoft

Copy link
Member Author

@LuChen-Microsoft LuChen-Microsoft Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used 1.1.0-beta.1 instead


### Added
- Added support to add `properties` for `message`

## 1.0.0 (2021-03-29)

### Breaking Changes
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/communication-chat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "@azure/communication-chat",
"version": "1.0.0",
"version": "1.0.2",
"description": "Azure client library for Azure Communication Chat services",
"sdk-type": "client",
"main": "dist/index.js",
"module": "dist-esm/src/index.js",
"types": "types/communication-chat.d.ts",
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
"build:autorest": "autorest ./swagger/README.md --typescript --version=3.0.6267 --v3 --disable-async-iterators=true --package-version=1.0.0 && rushx format",
"build:autorest": "autorest ./swagger/README.md --typescript --version=3.0.6267 --v3 --package-version=1.0.2 && rushx format",
"build:browser": "tsc -p . && cross-env ONLY_BROWSER=true rollup -c 2>&1",
"build:node": "tsc -p . && cross-env ONLY_NODE=true rollup -c 2>&1",
"build:samples": "dev-tool samples prep && cd dist-samples && tsc -p .",
Expand Down
12 changes: 6 additions & 6 deletions ...cordings/browsers/chatclient_chat_operations/recording_successfully_creates_a_thread.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...cordings/browsers/chatclient_chat_operations/recording_successfully_deletes_a_thread.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...n-chat/recordings/browsers/chatthreadclient/recording_successfully_adds_participants.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...n-chat/recordings/browsers/chatthreadclient/recording_successfully_deletes_a_message.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...cordings/browsers/chatthreadclient/recording_successfully_gets_the_thread_properties.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ...ordings/browsers/chatthreadclient/recording_successfully_intializes_chatthreadclient.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...tion-chat/recordings/browsers/chatthreadclient/recording_successfully_lists_messages.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...-chat/recordings/browsers/chatthreadclient/recording_successfully_lists_participants.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...chat/recordings/browsers/chatthreadclient/recording_successfully_lists_read_receipts.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading