Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-tracing] Make it so opentelemetry/api can be removed when bundling #15217

Closed
richardpark-msft opened this issue May 11, 2021 · 2 comments
Closed

[core-tracing] Make it so opentelemetry/api can be removed when bundling #15217

richardpark-msft opened this issue May 11, 2021 · 2 comments
Assignees
@maorleger
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented May 11, 2021 •
edited
Loading

Currently core-tracing non-optionally uses opentelemetry/api which will cause it to be included when bundled by rollup or webpack, for instance.

To be more friendly to size constraints we should make it so you can use core-tracing interfaces without being locked into bundling opentelemetry (for instance, if your application already has a tracing/telemetry solution).
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 11, 2021
@richardpark-msft richardpark-msft added the Client This issue points to a problem in the data-plane of the library. label May 11, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 11, 2021
@richardpark-msft
Copy link
Member Author

Related (in that opentelemetry/api is a potentially unexpected dependency): #11550

@deyaaeldeen deyaaeldeen added the feature-request This issue requires a new behavior in the product in order be resolved. label May 27, 2021
@deyaaeldeen deyaaeldeen added this to the Backlog milestone Jun 9, 2021
@richardpark-msft richardpark-msft removed their assignment Jun 30, 2021
@maorleger
Copy link
Member

Going to close this as we are removing OTel from core-tracing anyway

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xirzec @maorleger @deyaaeldeen @richardpark-msft