Skip to content

Commit b26a218

Browse files
authored
Remove core-lro runtime dependency on core-http (#15884)
Fixes #15880
1 parent 450f924 commit b26a218

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

sdk/core/core-lro/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,12 @@
9696
"sideEffects": false,
9797
"dependencies": {
9898
"@azure/abort-controller": "^1.0.0",
99-
"@azure/core-http": "^1.2.0",
10099
"@azure/core-tracing": "1.0.0-preview.12",
101100
"events": "^3.0.0",
102101
"tslib": "^2.2.0"
103102
},
104103
"devDependencies": {
104+
"@azure/core-http": "^1.2.0",
105105
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
106106
"@azure/dev-tool": "^1.0.0",
107107
"@microsoft/api-extractor": "7.7.11",

sdk/core/core-lro/rollup.base.config.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ const banner = [
2727
].join("\n");
2828

2929
const depNames = Object.keys(pkg.dependencies);
30+
const devDepNames = Object.keys(pkg.devDependencies);
3031
const production = process.env.NODE_ENV === "production";
3132

3233
export function nodeConfig(test = false) {
@@ -59,6 +60,9 @@ export function nodeConfig(test = false) {
5960
baseConfig.input = ["dist-esm/test/*.test.js"];
6061
baseConfig.plugins.unshift(multiEntry({ exports: false }));
6162

63+
// mark devdeps as external
64+
baseConfig.external.push(...devDepNames);
65+
6266
// different output file
6367
baseConfig.output.file = "dist-test/index.node.js";
6468

@@ -85,9 +89,6 @@ export function browserConfig(test = false) {
8589
banner: banner,
8690
format: "umd",
8791
name: "azurecorelro",
88-
globals: {
89-
"@azure/core-http": "Azure.Core.HTTP"
90-
},
9192
sourcemap: true
9293
},
9394
preserveSymlinks: false,

0 commit comments

Comments
 (0)