Skip to content

Commit 3ca1200

Browse files
Sync eng/common directory with azure-sdk-tools for PR 7841 (#28948)
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7841 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Praveen Kuttappan <[email protected]>
1 parent e8109d6 commit 3ca1200

File tree

3 files changed

+300
-113
lines changed

3 files changed

+300
-113
lines changed

eng/common/pipelines/templates/steps/create-apireview.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,37 @@ parameters:
22
ArtifactPath: $(Build.ArtifactStagingDirectory)
33
Artifacts: []
44
ConfigFileDir: $(Build.ArtifactStagingDirectory)/PackageInfo
5+
MarkPackageAsShipped: false
6+
GenerateApiReviewForManualOnly: false
7+
ArtifactName: 'packages'
8+
PackageName: ''
59

610
steps:
711
# ideally this should be done as initial step of a job in caller template
812
# We can remove this step later once it is added in caller
913
- template: /eng/common/pipelines/templates/steps/set-default-branch.yml
1014

11-
- ${{ each artifact in parameters.Artifacts }}:
15+
# Automatic API review is generated for a package when pipeline runs irrespective of how pipeline gets triggered.
16+
# Below condition ensures that API review is generated only for manual pipeline runs when flag GenerateApiReviewForManualOnly is set to true.
17+
- ${{ if or(ne(parameters.GenerateApiReviewForManualOnly, true), eq(variables['Build.Reason'], 'Manual')) }}:
1218
- task: Powershell@2
1319
inputs:
1420
filePath: $(Build.SourcesDirectory)/eng/common/scripts/Create-APIReview.ps1
1521
arguments: >
22+
-ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
1623
-ArtifactPath ${{parameters.ArtifactPath}}
17-
-APIViewUri $(azuresdk-apiview-uri)
24+
-ArtifactName ${{ parameters.ArtifactName }}
1825
-APIKey $(azuresdk-apiview-apikey)
19-
-APILabel "Auto Review - $(Build.SourceVersion)"
20-
-PackageName ${{artifact.name}}
26+
-PackageName '${{parameters.PackageName}}'
2127
-SourceBranch $(Build.SourceBranchName)
2228
-DefaultBranch $(DefaultBranch)
2329
-ConfigFileDir '${{parameters.ConfigFileDir}}'
30+
-BuildId $(Build.BuildId)
31+
-RepoName '$(Build.Repository.Name)'
32+
-MarkPackageAsShipped $${{parameters.MarkPackageAsShipped}}
2433
pwsh: true
2534
workingDirectory: $(Pipeline.Workspace)
26-
displayName: Create API Review for ${{ artifact.name}}
35+
displayName: Create API Review
2736
condition: >-
2837
and(
2938
succeededOrFailed(),

0 commit comments

Comments
 (0)