Skip to content

Updates HttpPolicyProviders Static Initializer #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Mar 5, 2020
Merged

Updates HttpPolicyProviders Static Initializer #8766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/core/azure-core/src/main/java/com/azure/core/http/policy/HttpPolicyProviders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

package com.azure.core.http.policy;

import java.util.ArrayList;
import java.util.List;
import java.util.ServiceLoader;

Expand All @@ -12,12 +13,12 @@
public final class HttpPolicyProviders {
private static final String INVALID_POLICY = "HttpPipelinePolicy created with %s resulted in a null policy.";

private static final Iterable<BeforeRetryPolicyProvider> BEFORE_PROVIDER;
private static final Iterable<AfterRetryPolicyProvider> AFTER_PROVIDER;
private static final List<BeforeRetryPolicyProvider> BEFORE_PROVIDER = new ArrayList<>();
private static final List<AfterRetryPolicyProvider> AFTER_PROVIDER = new ArrayList<>();

static {
BEFORE_PROVIDER = ServiceLoader.load(BeforeRetryPolicyProvider.class);
AFTER_PROVIDER = ServiceLoader.load(AfterRetryPolicyProvider.class);
ServiceLoader.load(BeforeRetryPolicyProvider.class).forEach(BEFORE_PROVIDER::add);
ServiceLoader.load(AfterRetryPolicyProvider.class).forEach(AFTER_PROVIDER::add);
}

private HttpPolicyProviders() {
Expand All @@ -42,8 +43,7 @@ public static void addAfterRetryPolicies(List<HttpPipelinePolicy> policies) {
addPolices(policies, AFTER_PROVIDER);
}

private static void addPolices(List<HttpPipelinePolicy> policies,
Iterable<? extends HttpPolicyProvider> providers) {
private static void addPolices(List<HttpPipelinePolicy> policies, List<? extends HttpPolicyProvider> providers) {
for (HttpPolicyProvider provider : providers) {
HttpPipelinePolicy policy = provider.create();
if (policy == null) {
Expand Down