Skip to content

CircuitBreaker: Partition availability staleness check background thread should be a daemon thread to not block apps from closing gracefully #44441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

CircuitBreaker: Partition availability staleness check background thread should be a daemon thread to not block apps from closing gracefully #44441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49c2e9a
CircuitBreaker: Partition availability staleness check background thr…
FabianMeiswinkel Feb 28, 2025
a1c88c7
Update CHANGELOG.md
FabianMeiswinkel Feb 28, 2025
713e5b0
Update CosmosSchedulers.java
FabianMeiswinkel Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/cosmos/azure-cosmos/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#### Breaking Changes

#### Bugs Fixed
* Fixed applications possibly not closing gracefully due to thread `partition-availability-staleness-check` not being a daemon thread. - [PR 44441](https://github.com/Azure/azure-sdk-for-java/pull/44441).

#### Other Changes

Expand Down
3 changes: 2 additions & 1 deletion sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosSchedulers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public class CosmosSchedulers {
Schedulers.DEFAULT_BOUNDED_ELASTIC_SIZE,
Schedulers.DEFAULT_BOUNDED_ELASTIC_QUEUESIZE,
CLIENT_TELEMETRY_BOUNDED_ELASTIC_THREAD_NAME,
TTL_FOR_SCHEDULER_WORKER_IN_SECONDS
TTL_FOR_SCHEDULER_WORKER_IN_SECONDS,
true
);

// Custom bounded elastic scheduler for open connections
Expand Down
4 changes: 3 additions & 1 deletion ...cosmos/implementation/circuitBreaker/GlobalPartitionEndpointManagerForCircuitBreaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ public class GlobalPartitionEndpointManagerForCircuitBreaker implements AutoClos
private final AtomicReference<GlobalAddressResolver> globalAddressResolverSnapshot;
private final ConcurrentHashMap<URI, String> locationToRegion;
private final AtomicBoolean isClosed = new AtomicBoolean(false);
private final Scheduler partitionRecoveryScheduler = Schedulers.newSingle("partition-availability-staleness-check");
private final Scheduler partitionRecoveryScheduler = Schedulers.newSingle(
"partition-availability-staleness-check",
true);

public GlobalPartitionEndpointManagerForCircuitBreaker(GlobalEndpointManager globalEndpointManager) {
this.partitionKeyRangeToLocationSpecificUnavailabilityInfo = new ConcurrentHashMap<>();
Expand Down
Loading