Skip to content

Sync eng/common directory with azure-sdk-tools for PR 8283 #40238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8283 #40238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0318361
Update APIView script path to absolute path
praveenkuttappan May 16, 2024
e3d736c
remove working directory
praveenkuttappan May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/common/pipelines/templates/steps/create-apireview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ steps:
- ${{ if or(ne(parameters.GenerateApiReviewForManualOnly, true), eq(variables['Build.Reason'], 'Manual')) }}:
- task: Powershell@2
inputs:
filePath: ./eng/common/scripts/Create-APIReview.ps1
filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1
arguments: >
-ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
-ArtifactPath ${{parameters.ArtifactPath}}
Expand All @@ -34,7 +34,6 @@ steps:
-RepoName '$(Build.Repository.Name)'
-MarkPackageAsShipped $${{parameters.MarkPackageAsShipped}}
pwsh: true
workingDirectory: ${{ parameters.SourceRootPath }}
displayName: Create API Review
condition: >-
and(
Expand Down