mgmt, generate paloaltonetworks.ngfw first preview by haolingdong-msft · Pull Request #34486 · Azure/azure-sdk-for-java

haolingdong-msft · 2023-04-17T05:28:31Z

Release request: https://github.com/Azure/sdk-release-request/issues/3924
Arch board review: https://github.com/Azure/azure-sdk-pr/issues/892

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

XiaofeiCao · 2023-04-17T05:52:48Z

...networks-ngfw/src/main/java/com/azure/resourcemanager/paloaltonetworks/ngfw/NgfwManager.java

+import java.util.stream.Collectors;
+
+/** Entry point to NgfwManager. */
+public final class NgfwManager {


Maybe PaloAltoNetworksNgfwManager?

Hi service team, we will need your suggestion on the Manager name.

PaloAltoNetworksNgfwManager sounds good, as it in line with the finalized namespace.

XiaofeiCao · 2023-04-17T05:55:18Z

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/CHANGELOG.md

+
+## 1.0.0-beta.1 (2023-04-17)
+
+- Azure Resource Manager ngfw client library for Java. This package contains Microsoft Azure SDK for ngfw Management SDK.  Package tag package-2022-08-29-preview. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).


Azure Resourcemanager PaloAlto Networks ngfw client library for Java?

Please delete the 2nd line "Azure Resource Manager ngfw client library for Java..."

haolingdong-msft · 2023-04-17T06:00:33Z

/azp run prepare-pipelines

azure-pipelines · 2023-04-17T06:00:48Z

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft · 2023-04-18T01:56:58Z

The script did not update https://github.com/Azure/azure-sdk-for-java/blob/main/eng/mgmt/automation/api-specs.yaml ?

It should add a line with "suffix". If script not modify that, you may have to do it by hand.

weidongxu-microsoft · 2023-04-18T11:33:39Z

haolingdong-msft · 2023-04-19T03:23:50Z

The script did not update https://github.com/Azure/azure-sdk-for-java/blob/main/eng/mgmt/automation/api-specs.yaml ?

It should add a line with "suffix". If script not modify that, you may have to do it by hand.

I will add it manually, the script does not add it.

# Conflicts: # eng/versioning/version_client.txt

eng/versioning/version_client.txt

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/CHANGELOG.md

XiaofeiCao · 2023-04-19T06:42:03Z

After the PR's merged, we may need to add the service-name configuration to the specs repo's readme.java.

weidongxu-microsoft · 2023-04-19T06:43:54Z

After the PR's merged, we may need to add the service-name configuration to the specs repo's readme.java.

I think Haoling already done it.

haolingdong-msft · 2023-04-19T06:55:14Z

After the PR's merged, we may need to add the service-name configuration to the specs repo's readme.java.

Azure/azure-rest-api-specs#23599 this is the pr

haolingdong-msft · 2023-04-19T07:06:53Z

Deleted the proj and regen again to make sure there is no other file's content is appended wrongly.

haolingdong-msft · 2023-04-19T07:10:44Z

/azp run prepare-pipelines

azure-pipelines · 2023-04-19T07:10:54Z

Azure Pipelines successfully started running 1 pipeline(s).

generate resourcemanager.paloaltonetworks.ngfw

4376b95

haolingdong-msft changed the title ~~mgmt, generate resourcemanager.paloaltonetworks.ngfw first preview~~ mgmt, generate paloaltonetworks.ngfw first preview Apr 17, 2023

XiaofeiCao reviewed Apr 17, 2023

View reviewed changes

haolingdong-msft mentioned this pull request Apr 18, 2023

mgmt, paloaltonetworks, customize service name Azure/azure-rest-api-specs#23599

Merged

11 tasks

customize service name

cc0a5ea

haolingdong-msft added 2 commits April 19, 2023 13:59

update api-specs.yaml

bc2a9ec

Merge remote-tracking branch 'azure-sdk/main' into release-paloalto-mgmt

49b60f0

# Conflicts: # eng/versioning/version_client.txt

weidongxu-microsoft reviewed Apr 19, 2023

View reviewed changes

eng/versioning/version_client.txt Outdated Show resolved Hide resolved

weidongxu-microsoft reviewed Apr 19, 2023

View reviewed changes

sdk/paloaltonetworks/azure-resourcemanager-paloaltonetworks-ngfw/CHANGELOG.md Outdated Show resolved Hide resolved

weidongxu-microsoft approved these changes Apr 19, 2023

View reviewed changes

haolingdong-msft added 2 commits April 19, 2023 14:27

update version_client

098aef1

update release date

b075a81

XiaofeiCao approved these changes Apr 19, 2023

View reviewed changes

update CHANGELOG

d27536d

delete the proj and regen again

068164a

haolingdong-msft marked this pull request as ready for review April 19, 2023 08:50

haolingdong-msft requested review from alzimmermsft and samvaity as code owners April 19, 2023 08:50

haolingdong-msft requested review from ArthurMa1978, JimSuplizio, JonathanGiles, anuchandy, benbp, conniey, g2vinay, hallipr, joshfree, lmolkova, srnagar and weshaggard as code owners April 19, 2023 08:50

haolingdong-msft merged commit 29c1d97 into Azure:main Apr 19, 2023


		## 1.0.0-beta.1 (2023-04-17)

		- Azure Resource Manager ngfw client library for Java. This package contains Microsoft Azure SDK for ngfw Management SDK. Package tag package-2022-08-29-preview. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).

Comments

Conversation

haolingdong-msft commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

XiaofeiCao Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haolingdong-msft Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Vibhuti-Sharma-Microsoft Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

XiaofeiCao Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

weidongxu-microsoft Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haolingdong-msft commented Apr 17, 2023

Uh oh!

azure-pipelines bot commented Apr 17, 2023

Uh oh!

weidongxu-microsoft commented Apr 18, 2023

Uh oh!

weidongxu-microsoft commented Apr 18, 2023

Uh oh!

haolingdong-msft commented Apr 19, 2023

Uh oh!

Uh oh!

Uh oh!

XiaofeiCao commented Apr 19, 2023

Uh oh!

weidongxu-microsoft commented Apr 19, 2023

Uh oh!

haolingdong-msft commented Apr 19, 2023

Uh oh!

haolingdong-msft commented Apr 19, 2023

Uh oh!

haolingdong-msft commented Apr 19, 2023

Uh oh!

azure-pipelines bot commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

haolingdong-msft commented Apr 17, 2023 •

edited

Loading

XiaofeiCao Apr 17, 2023 •

edited

Loading

weidongxu-microsoft Apr 19, 2023 •

edited

Loading