From 7d20fcc28645d38a1cc28ecdb0e89c4b63516ea6 Mon Sep 17 00:00:00 2001 From: samvaity Date: Wed, 29 Jun 2022 14:48:23 -0700 Subject: [PATCH 1/2] un-static request --- .../core/http/policy/ProtocolPolicyTests.java | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/ProtocolPolicyTests.java b/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/ProtocolPolicyTests.java index 7f727e525522..5b358e120200 100644 --- a/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/ProtocolPolicyTests.java +++ b/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/ProtocolPolicyTests.java @@ -18,22 +18,12 @@ import static org.junit.jupiter.api.Assertions.assertEquals; public class ProtocolPolicyTests { - static final HttpRequest HTTP_REQUEST; - - static { - try { - HTTP_REQUEST = createHttpRequest("https://www.bing.com"); - } catch (MalformedURLException e) { - throw new RuntimeException(e); - } - } - @SyncAsyncTest public void withOverwrite() throws Exception { final HttpPipeline pipeline = createPipeline("ftp", "ftp://www.bing.com"); SyncAsyncExtension.execute( - () -> pipeline.sendSync(HTTP_REQUEST, Context.NONE), - () -> pipeline.send(HTTP_REQUEST) + () -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE), + () -> pipeline.send(createHttpRequest("https://www.bing.com")) ); } @@ -41,8 +31,8 @@ public void withOverwrite() throws Exception { public void withNoOverwrite() throws Exception { final HttpPipeline pipeline = createPipeline("ftp", false, "https://www.bing.com"); SyncAsyncExtension.execute( - () -> pipeline.sendSync(HTTP_REQUEST, Context.NONE), - () -> pipeline.send(HTTP_REQUEST) + () -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE), + () -> pipeline.send(createHttpRequest("https://www.bing.com")) ); } From 94f0128d88afd24549ab6715c72d36035f0dfd1a Mon Sep 17 00:00:00 2001 From: samvaity Date: Wed, 29 Jun 2022 14:55:26 -0700 Subject: [PATCH 2/2] same change, requestId --- .../core/http/policy/RequestIdPolicyTests.java | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/RequestIdPolicyTests.java b/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/RequestIdPolicyTests.java index 6a97f9681783..24a8566f3ee7 100644 --- a/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/RequestIdPolicyTests.java +++ b/sdk/core/azure-core/src/test/java/com/azure/core/http/policy/RequestIdPolicyTests.java @@ -25,15 +25,6 @@ import java.time.temporal.ChronoUnit; public class RequestIdPolicyTests { - static final HttpRequest HTTP_REQUEST; - - static { - try { - HTTP_REQUEST = createHttpRequest("https://www.bing.com"); - } catch (MalformedURLException e) { - throw new RuntimeException(e); - } - } private final HttpResponse mockResponse = new HttpResponse(null) { @Override @@ -98,8 +89,8 @@ public Mono send(HttpRequest request) { .build(); SyncAsyncExtension.execute( - () -> pipeline.sendSync(HTTP_REQUEST, Context.NONE), - () -> pipeline.send(HTTP_REQUEST) + () -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE), + () -> pipeline.send(createHttpRequest("https://www.bing.com")) ); } @@ -127,8 +118,8 @@ public Mono send(HttpRequest request) { .build(); SyncAsyncExtension.execute( - () -> pipeline.sendSync(HTTP_REQUEST, Context.NONE), - () -> pipeline.send(HTTP_REQUEST) + () -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE), + () -> pipeline.send(createHttpRequest("https://www.bing.com")) ); }