Skip to content

Conversation

@chenrujun
Copy link

Update aad-starter's CHANGELOG.md. Make it easier to understand.

@ghost ghost added the azure-spring All azure-spring related issues label Jul 1, 2021
@chenrujun chenrujun self-assigned this Jul 1, 2021
@chenrujun chenrujun linked an issue Jul 1, 2021 that may be closed by this pull request
@chenrujun
Copy link
Author

Hi, @yiliuTo , please help to review this PR.

@check-enforcer
Copy link

check-enforcer bot commented Jul 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun
Copy link
Author

/check-enforcer override

1 similar comment
@chenrujun
Copy link
Author

/check-enforcer override

@chenrujun chenrujun closed this Jul 2, 2021
@chenrujun chenrujun reopened this Jul 2, 2021
@chenrujun chenrujun enabled auto-merge (squash) July 2, 2021 07:21
@chenrujun chenrujun merged commit 6319e60 into Azure:main Jul 2, 2021
@chenrujun chenrujun deleted the issue-22677-not-support-aad-v1 branch July 2, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Spring Boot AAD Starter broken against MIP v1.0

4 participants