Skip to content

Conversation

@mssfang
Copy link
Contributor

@mssfang mssfang commented Jun 21, 2021

This PR fixes the checkstyle issues that reported by the @mrm9084 .

[INFO] --- maven-checkstyle-plugin:3.1.2:check (default) @ azure-data-appconfiguration-perf ---
[INFO] Starting audit...
[ERROR] C:\Users\mametcal\azure-sdk-for-java\sdk\appconfiguration\azure-data-appconfiguration-perf\src\main\java\com\azure\data\appconfiguration\perf\App.java:1: Missing package-info.java file. [JavadocPackage]
[ERROR] C:\Users\mametcal\azure-sdk-for-java\sdk\appconfiguration\azure-data-appconfiguration-perf\src\main\java\com\azure\data\appconfiguration\perf\core\ServiceTest.java:1: Missing package-info.java file. [JavadocPackage]
[ERROR] C:\Users\mametcal\azure-sdk-for-java\sdk\appconfiguration\azure-data-appconfiguration-perf\src\main\java\com\azure\data\appconfiguration\perf\ListConfigurationSettingsTest.java:23:5: Field "keyFilterSelector" is not assigned in constructor or methods.You should consider making the field final, or suppressing the warning. [EnforceFinalFields]
[ERROR] C:\Users\mametcal\azure-sdk-for-java\sdk\appconfiguration\azure-data-appconfiguration-perf\src\main\java\com\azure\data\appconfiguration\perf\ListConfigurationSettingsTest.java:25:5: Field "settingCount" is not assigned in constructor or methods.You should consider making the field final, or suppressing the warning. [EnforceFinalFields]
Audit done.
[INFO] ------------------------

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Jun 21, 2021
@mssfang mssfang added this to the [2021] July milestone Jun 21, 2021
@mssfang mssfang requested a review from mrm9084 June 21, 2021 21:04
@mssfang mssfang self-assigned this Jun 21, 2021
@mssfang mssfang requested a review from alzimmermsft as a code owner June 21, 2021 21:04
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@mssfang
Copy link
Contributor Author

mssfang commented Jun 21, 2021

/check-enforcer evaluate

@mssfang
Copy link
Contributor Author

mssfang commented Jun 21, 2021

/check-enforcer override

@mssfang mssfang merged commit f70a169 into Azure:main Jun 21, 2021
@mssfang mssfang deleted the AppConfig-Performance-Checkstyle branch June 21, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants