Add the usage of azure spring BOMs for azure starter #20968

moarychan · 2021-04-27T01:37:18Z

Changelog:

Add azure spring boot BOM usage for azure spring boot starters.
Add azure spring cloud BOM usage for azure spring cloud starters.
Add version tag and missed dependencies for azure-spring-cloud-dependencies.

…ncies BOM for azure spring starter.

check-enforcer · 2021-04-27T04:44:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

sdk/spring/AZURE_SPRING_BOMS_USAGE.md

chenrujun · 2021-04-29T02:27:59Z

Hi, @saragluna , @moarychan .
I updated the PR.
Please take a look.

chenrujun

LGTM.

chenrujun · 2021-05-07T04:02:35Z

LGTM.

chenrujun · 2021-05-18T08:45:45Z

Hi, @saragluna , could you please merge this PR?

saragluna · 2021-05-20T06:12:04Z

@chenrujun there's still some work we need to finalize in this PR, like managing our bom versions and updating the versions in README files.

…ure spring cloud dependencies.

sdk/boms/azure-spring-cloud-dependencies/pom.xml

sdk/spring/azure-spring-boot/README.md

saragluna

LGTM.

saragluna · 2021-07-02T08:13:03Z

/azp run java - spring - ci

azure-pipelines · 2021-07-02T08:13:19Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-07-02T08:14:10Z

https://dev.azure.com/azure-sdk/public/_build/results?buildId=981507&view=results

saragluna · 2021-07-02T08:21:46Z

/check-enforcer evaluate

saragluna · 2021-07-02T08:23:08Z

/check-enforcer override

saragluna · 2021-07-02T09:15:29Z

https://dev.azure.com/azure-sdk/public/_build/results?buildId=981538&view=results

saragluna · 2021-07-02T09:17:48Z

/check-enforcer override

saragluna · 2021-07-02T09:18:26Z

The ci passed in https://dev.azure.com/azure-sdk/public/_build/results?buildId=981538, merging this now.

saragluna · 2021-07-02T09:33:20Z

/check-enforcer reset

saragluna · 2021-07-02T09:36:44Z

/check-enforcer reset

Add the usage of azure spring boot BOM and azure spring cloud depende…

fc115e7

…ncies BOM for azure spring starter.

moarychan requested review from backwind1233, chenrujun, saragluna, stliu and yiliuTo as code owners April 27, 2021 01:37

ghost added the azure-spring All azure-spring related issues label Apr 27, 2021

added for other starter modules

a840755

saragluna assigned saragluna and chenrujun Apr 28, 2021

saragluna added this to the [2021] June milestone Apr 28, 2021

saragluna requested changes Apr 28, 2021

View reviewed changes

sdk/spring/AZURE_SPRING_BOMS_USAGE.md Show resolved Hide resolved

sdk/spring/AZURE_SPRING_BOMS_USAGE.md Outdated Show resolved Hide resolved

sdk/spring/AZURE_SPRING_BOMS_USAGE.md Outdated Show resolved Hide resolved

sdk/spring/AZURE_SPRING_BOMS_USAGE.md Outdated Show resolved Hide resolved

rujche added 2 commits April 29, 2021 10:23

Make bom related content easier to read.

4b3a5d2

Fix error about break line.

b57320c

chenrujun approved these changes Apr 29, 2021

View reviewed changes

Moary Chen added 2 commits May 6, 2021 12:25

merge master from Azure

96f4b1f

fix build bugs

ca74a6e

saragluna added the azure-spring-dependency Spring dependency related issues. label May 17, 2021

moarychan marked this pull request as draft May 20, 2021 06:32

Moary Chen added 2 commits May 26, 2021 12:05

merge branch master from Azure

99b7b26

Add bom version tag in version_client; add missed dependencies for az…

4ed8308

…ure spring cloud dependencies.

moarychan marked this pull request as ready for review May 26, 2021 07:33

moarychan requested review from alzimmermsft, anuchandy and conniey as code owners May 26, 2021 07:33

saragluna requested changes Jun 22, 2021

View reviewed changes

sdk/boms/azure-spring-cloud-dependencies/pom.xml Outdated Show resolved Hide resolved

sdk/spring/azure-spring-boot/README.md Show resolved Hide resolved

Moary Chen added 8 commits June 22, 2021 14:25

fixes configuration issue

e4dff75

fixes broken links

00e3094

fixes conflicts

c3164d4

Keep the bom version and default branch name align

1020d24

fixes conflicts

f624a61

Remove duplicated items

5fe5e4e

add version tag

b04317e

Remove duplicated items

c50fdc5

saragluna approved these changes Jul 2, 2021

View reviewed changes

fixes conflicts

4d2bb66

moarychan requested a review from benbp as a code owner July 2, 2021 02:31

saragluna enabled auto-merge (squash) July 2, 2021 02:48

saragluna closed this Jul 2, 2021

auto-merge was automatically disabled July 2, 2021 08:08
Pull request was closed

saragluna reopened this Jul 2, 2021

Moary Chen added 2 commits July 2, 2021 16:29

Trigger job test

8e62b2c

Revert trigger job test

96569d4

saragluna merged commit d2859e9 into Azure:main Jul 2, 2021

moarychan deleted the feature/add-markdown-for-azure-spring-bom-usage branch July 7, 2021 02:38

Add the usage of azure spring BOMs for azure starter #20968

Add the usage of azure spring BOMs for azure starter #20968

Uh oh!

Conversation

moarychan commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

check-enforcer bot commented Apr 27, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenrujun commented Apr 29, 2021

Uh oh!

chenrujun left a comment

Choose a reason for hiding this comment

Uh oh!

chenrujun commented May 7, 2021

Uh oh!

chenrujun commented May 18, 2021

Uh oh!

saragluna commented May 20, 2021

Uh oh!

Uh oh!

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

azure-pipelines bot commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

saragluna commented Jul 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moarychan commented Apr 27, 2021 •

edited

Loading