Removed Beta tag from handle, and readMany APIs #20092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
FabianMeiswinkel,
kirankumarkolli,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
reviewed
Mar 24, 2021
| * @return set of regions contacted for this request | ||
| */ | ||
| @Beta(value = Beta.SinceVersion.V4_9_0, warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING) | ||
| public Set<URI> getRegionsContacted() { |
Contributor
There was a problem hiding this comment.
can we postpone GAing the getRegionsContacted() API for now.
I suspect we may need to return a different type. perhaps a Set<URL> or Set<String>
Member
There was a problem hiding this comment.
Also, the feedResponseDiagnostics doesnt return all the values for this and currently just null. So its worth waiting to fix that part too for GA
Member
Author
There was a problem hiding this comment.
@moderakh - makes sense, reverted this API back to Beta.
moderakh
approved these changes
Mar 24, 2021
kushagraThapar
changed the title
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 5, 2022
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 5, 2022
migrate to .net track 2 batch 2 (Azure#20092)
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 5, 2022
migrate to .net track 2 batch 2 (Azure#20092)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.