Skip to content

Remove unused configuration for two resource-server samples #18170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saragluna merged 1 commit into from
Dec 16, 2020
Merged

Remove unused configuration for two resource-server samples #18170

saragluna merged 1 commit into from
Dec 16, 2020

Conversation

@wujack778
Copy link
Contributor

@wujack778 wujack778 commented Dec 16, 2020

Remove unused client registration configuration

Unused configuration items:
sample azure-spring-boot-sample-active-directory-resource-server-obo
spring:
  security:
    oauth2:
      client:
        registration:
          azure:
            client-id: [resource-server-application-client-id-same-as-above]
            client-secret: [resource-server-application-client-secret-same-as-above]
sample azure-spring-boot-sample-active-directory-spring-security-resource-server
azure.activedirectory.session-stateless

@ghost ghost added the azure-spring All azure-spring related issues label Dec 16, 2020
@wujack778 wujack778 changed the title Remove unused configuration for resource-server samples Remove unused configuration for two resource-server samples Dec 16, 2020
backwind1233
backwind1233 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saragluna saragluna added the azure-spring-aad Spring active directory related issues. label Dec 16, 2020
@saragluna saragluna merged commit ee675d0 into Azure:master Dec 16, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Mar 30, 2022
@dosegal @NoaGoren @ushasan
CodeGen from PR 18410 in Azure/azure-rest-api-specs
2969050 
dev-Sentinel-2022-04-01-preview (Azure#18410)

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-01-01-preview to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fix ThreatInteliignece accordig to latest preview for alignment (Azure#18231)

* Add UebaEntityProviders to EntityAnalyticsSettings (Azure#18196)

* Add UebaEntityProviders to EntityAnalyticsSettings

* remove ueba

* Added additionalProperties to itemsKeyValue to resolve autorest issues (Azure#18170)

* added additionalProperties to itemsKeyValue to resolve autorest issues

* Update Watchlists.json

* ran prettier-fix

* Remove readonly property from ownerType (Azure#18450)

Co-authored-by: dosegal <[email protected]>
Co-authored-by: NoaGoren <[email protected]>
Co-authored-by: ushasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@backwind1233 backwind1233 backwind1233 approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@jialindai jialindai Awaiting requested review from jialindai

@saragluna saragluna Awaiting requested review from saragluna

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

No one assigned

Labels

azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wujack778 @backwind1233 @saragluna