From 9bf2cae528a0ab8b9d8bb59d4c01fc8871b6aaa4 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 14:41:27 -0800 Subject: [PATCH 01/15] Added test coverage for Identity tests --- .../CommunicationIdentityAsyncClient.java | 10 +++ .../CommunicationIdentityAsyncTests.java | 90 +++++++++++++++++++ .../CommunicationIdentityBuilderTests.java | 40 +++++++++ .../deleteUserWithNullUser.json | 4 + .../deleteUserWithResponseWithNullUser.json | 4 + .../issueTokenWithNullScope.json | 25 ++++++ .../issueTokenWithNullUser.json | 4 + .../issueTokenWithResponseWithNullUser.json | 4 + .../revokeTokenWithNullUser.json | 4 + .../revokeTokenWithResponseWithNullUser.json | 4 + .../azure-communication-chat/pom.xml | 4 - 11 files changed, 189 insertions(+), 4 deletions(-) create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithNullUser.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithResponseWithNullUser.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullUser.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithResponseWithNullUser.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithNullUser.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithResponseWithNullUser.json diff --git a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/CommunicationIdentityAsyncClient.java b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/CommunicationIdentityAsyncClient.java index 63dbc7154779..b392a5ef085e 100644 --- a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/CommunicationIdentityAsyncClient.java +++ b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/CommunicationIdentityAsyncClient.java @@ -20,6 +20,8 @@ import java.time.OffsetDateTime; import java.util.List; +import java.util.Objects; + import reactor.core.publisher.Mono; import static com.azure.core.util.FluxUtil.monoError; @@ -103,6 +105,7 @@ public Mono> createUser(Context context) { @ServiceMethod(returns = ReturnType.SINGLE) public Mono deleteUser(CommunicationUser communicationUser) { try { + Objects.requireNonNull(communicationUser); return withContext(context -> deleteUser(communicationUser, context) .flatMap( (Response res) -> { @@ -122,6 +125,7 @@ public Mono deleteUser(CommunicationUser communicationUser) { @ServiceMethod(returns = ReturnType.SINGLE) public Mono> deleteUserWithResponse(CommunicationUser communicationUser) { try { + Objects.requireNonNull(communicationUser); return withContext(context -> deleteUser(communicationUser, context)); } catch (RuntimeException ex) { return monoError(logger, ex); @@ -151,6 +155,7 @@ public Mono> deleteUser(CommunicationUser communicationUser, Cont @ServiceMethod(returns = ReturnType.SINGLE) public Mono revokeTokens(CommunicationUser communicationUser, OffsetDateTime issuedBefore) { try { + Objects.requireNonNull(communicationUser); return withContext(context -> revokeTokens(communicationUser, issuedBefore, context) .flatMap( (Response res) -> { @@ -172,6 +177,7 @@ public Mono revokeTokens(CommunicationUser communicationUser, OffsetDateTi public Mono> revokeTokensWithResponse( CommunicationUser communicationUser, OffsetDateTime issuedBefore) { try { + Objects.requireNonNull(communicationUser); return withContext(context -> revokeTokens(communicationUser, issuedBefore, context)); } catch (RuntimeException ex) { return monoError(logger, ex); @@ -208,6 +214,8 @@ public Mono> revokeTokens( public Mono issueToken( CommunicationUser communicationUser, List scopes) { try { + Objects.requireNonNull(communicationUser); + Objects.requireNonNull(scopes); return withContext(context -> issueToken(communicationUser, scopes, context) .flatMap( (Response res) -> { @@ -232,6 +240,8 @@ public Mono issueToken( public Mono> issueTokenWithResponse( CommunicationUser communicationUser, List scopes) { try { + Objects.requireNonNull(communicationUser); + Objects.requireNonNull(scopes); return withContext(context -> issueToken(communicationUser, scopes, context)); } catch (RuntimeException ex) { return monoError(logger, ex); diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java index 26bd60ed1ed9..850d3ea96c0a 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java @@ -130,6 +130,30 @@ public void deleteUserWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void deleteUserWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + + // Action & Assert + StepVerifier.create( + asyncClient.deleteUser(null)) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void deleteUserWithResponseWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + + // Action & Assert + StepVerifier.create( + asyncClient.deleteUserWithResponse(null)) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void revokeToken(HttpClient httpClient) { @@ -171,6 +195,31 @@ public void revokeTokenWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void revokeTokenWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + + // Action & Assert + StepVerifier.create( + asyncClient.revokeTokens(null, null)) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void revokeTokenWithResponseWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + + // Action & Assert + StepVerifier.create( + asyncClient.revokeTokensWithResponse(null, null)) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void issueToken(HttpClient httpClient) { @@ -216,4 +265,45 @@ public void issueTokenWithResponse(HttpClient httpClient) { }) .verifyComplete(); } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void issueTokenWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + List scopes = new ArrayList<>(Arrays.asList("chat")); + + // Action & Assert + StepVerifier.create( + asyncClient.issueToken(null, scopes)) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void issueTokenWithNullScope(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + + // Action & Assert + StepVerifier.create( + asyncClient.createUser() + .flatMap(communicationUser -> { + return asyncClient.issueToken(communicationUser, null); + })) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void issueTokenWithResponseWithNullUser(HttpClient httpClient) { + // Arrange + asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); + List scopes = new ArrayList<>(Arrays.asList("chat")); + + // Action & Assert + StepVerifier.create( + asyncClient.issueTokenWithResponse(null, scopes)) + .verifyError(NullPointerException.class); + } } diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java index b86f00ecc82e..5c0f3a59d313 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java @@ -129,4 +129,44 @@ public void missingUrlTest() builder.buildAsyncClient(); }); } + + @Test + public void nullPipelineTest() { + assertThrows(NullPointerException.class, () -> { + builder + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .pipeline(null); + }); + } + + @Test + public void nullCustomPolicyTest() { + assertThrows(NullPointerException.class, () -> { + builder + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .addPolicy(null); + }); + } + + @Test + public void nullConfigurationTest() { + assertThrows(NullPointerException.class, () -> { + builder + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .configuration(null); + }); + } + + @Test + public void nullHttpLogOptionsTest() { + assertThrows(NullPointerException.class, () -> { + builder + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .httpLogOptions(null); + }); + } } diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithResponseWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithResponseWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/deleteUserWithResponseWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json new file mode 100644 index 000000000000..5d094fe04281 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json @@ -0,0 +1,25 @@ +{ + "networkCallRecords" : [ { + "Method" : "POST", + "Uri" : "https://REDACTED.communication.azure.com/identities?api-version=2020-07-20-preview2", + "Headers" : { + "User-Agent" : "azsdk-java-azure-communication-administration/1.0.0-beta.3 (11.0.8; Windows 10; 10.0)" + }, + "Response" : { + "Transfer-Encoding" : "chunked", + "Strict-Transport-Security" : "max-age=2592000", + "api-supported-versions" : "2020-01-15-generalAvailability, 2020-07-20-preview1, 2020-07-20-preview2", + "X-Processing-Time" : "19ms", + "MS-CV" : "PE5LidtiwE+tCY1iDfENRQ.0", + "retry-after" : "0", + "X-Azure-Ref" : "02NetXwAAAAB2qjy7KLPFQoVXl0Ncq7D1WVZSMzBFREdFMDQwOAA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=", + "StatusCode" : "200", + "Body" : "{\"id\":\"8:acs:8d0de54a-ca74-4b37-89ea-75a8ab565166_00000006-5ef4-ca4b-0e04-343a0d000731\"}", + "Date" : "Fri, 13 Nov 2020 00:48:24 GMT", + "x-ms-client-request-id" : "6875024b-e05b-4afc-8edf-782e8772fcd8", + "Content-Type" : "application/json; charset=utf-8" + }, + "Exception" : null + } ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithResponseWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithResponseWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithResponseWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithResponseWithNullUser.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithResponseWithNullUser.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/revokeTokenWithResponseWithNullUser.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-chat/pom.xml b/sdk/communication/azure-communication-chat/pom.xml index 6ca2d3740663..4f3dbb15dc48 100644 --- a/sdk/communication/azure-communication-chat/pom.xml +++ b/sdk/communication/azure-communication-chat/pom.xml @@ -96,10 +96,6 @@ jacoco-maven-plugin 0.8.5 - - 0.75 - 0.75 - From 95675ed710dc0c9254eb96f2d375e1283589d257 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 17:03:32 -0800 Subject: [PATCH 02/15] Adding more unhappy test cases for TNM --- .../PhoneNumberAsyncClient.java | 89 ++++----- .../CommunicationIdentityBuilderTests.java | 24 +-- ...PhoneNumberAsyncClientIntegrationTest.java | 180 ++++++++++++++++++ .../cancelSearchWithResponseNullSearchId.json | 4 + ...gureNumberWithResponseNullPhoneNumber.json | 4 + ...igureNumberWithResponseNullPstnConfig.json | 4 + ...teSearchWithResponseNullSearchOptions.json | 4 + ...lAreaCodesWithResponseNullCountryCode.json | 4 + ...AreaCodesWithResponseNullLocationType.json | 4 + ...lAreaCodesWithResponseNullPhonePlanId.json | 4 + ...sUpdateWithResponseNullCapabilitiesId.json | 4 + ...figurationWithResponseNullPhoneNumber.json | 4 + ...ionOptionsWithResponseNullCountryCode.json | 4 + ...tionsWithResponseNullPhonePlanGroupId.json | 4 + ...ionOptionsWithResponseNullPhonePlanId.json | 4 + ...getSearchByIdWithResponseNullSearchId.json | 4 + .../listPhonePlanGroupsNullCountryCode.json | 4 + .../listPhonePlansNullCountryCode.json | 4 + .../listPhonePlansNullPhonePlanGroupId.json | 4 + ...gureNumberWithResponseNullPhoneNumber.json | 4 + ...onseNullPhoneNumberCapabilitiesUpdate.json | 4 + 21 files changed, 304 insertions(+), 61 deletions(-) create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPhoneNumber.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPstnConfig.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullCountryCode.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullLocationType.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullPhonePlanId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getCapabilitiesUpdateWithResponseNullCapabilitiesId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getNumberConfigurationWithResponseNullPhoneNumber.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullCountryCode.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanGroupId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlanGroupsNullCountryCode.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullCountryCode.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullPhonePlanGroupId.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/unconfigureNumberWithResponseNullPhoneNumber.json create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/updateCapabilitiesWithResponseNullPhoneNumberCapabilitiesUpdate.json diff --git a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java index 347523d578a2..eaa90f298e2b 100644 --- a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java +++ b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java @@ -127,14 +127,14 @@ public Mono> getAllAreaCodesWithResponse( Mono> getAllAreaCodesWithResponse( String locationType, String countryCode, String phonePlanId, List locationOptions, Context context) { - Objects.requireNonNull(locationType, "'locationType' cannot be null."); - Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); - Objects.requireNonNull(phonePlanId, "'phonePlanId' cannot be null."); LocationOptionsQueries locationOptionsQueries = new LocationOptionsQueries(); locationOptionsQueries.setLocationOptions(locationOptions); try { + Objects.requireNonNull(locationType, "'locationType' cannot be null."); + Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); + Objects.requireNonNull(phonePlanId, "'phonePlanId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getAllAreaCodesWithResponseAsync( locationType, countryCode, phonePlanId, locationOptionsQueries); @@ -174,9 +174,8 @@ public Mono> getCapabilitiesUpda Mono> getCapabilitiesUpdateWithResponse( String capabilitiesId, Context context) { - Objects.requireNonNull(capabilitiesId, "'capabilitiesId' cannot be null."); - try { + Objects.requireNonNull(capabilitiesId, "'capabilitiesId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getCapabilitiesUpdateWithResponseAsync(capabilitiesId); } else { @@ -215,17 +214,15 @@ public Mono> updateCapabilitiesWithRe Mono> updateCapabilitiesWithResponse( Map phoneNumberCapabilitiesUpdate, Context context) { - Objects.requireNonNull(phoneNumberCapabilitiesUpdate, "'phoneNumberCapabilitiesUpdate' cannot be null."); - - Map capabilitiesMap = new HashMap<>(); - for (Map.Entry entry : phoneNumberCapabilitiesUpdate.entrySet()) { - capabilitiesMap.put(entry.getKey().getValue(), entry.getValue()); - } - - UpdateNumberCapabilitiesRequest updateNumberCapabilitiesRequest = new UpdateNumberCapabilitiesRequest(); - updateNumberCapabilitiesRequest.setPhoneNumberCapabilitiesUpdate(capabilitiesMap); - try { + Objects.requireNonNull(phoneNumberCapabilitiesUpdate, "'phoneNumberCapabilitiesUpdate' cannot be null."); + Map capabilitiesMap = new HashMap<>(); + for (Map.Entry entry : phoneNumberCapabilitiesUpdate.entrySet()) { + capabilitiesMap.put(entry.getKey().getValue(), entry.getValue()); + } + UpdateNumberCapabilitiesRequest updateNumberCapabilitiesRequest = new UpdateNumberCapabilitiesRequest(); + updateNumberCapabilitiesRequest.setPhoneNumberCapabilitiesUpdate(capabilitiesMap); + if (context == null) { return phoneNumberAdministrations.updateCapabilitiesWithResponseAsync( updateNumberCapabilitiesRequest); @@ -286,12 +283,11 @@ public Mono> getNumberConfigurationWithRes Mono> getNumberConfigurationWithResponse( PhoneNumber phoneNumber, Context context) { - Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); - - NumberConfigurationPhoneNumber configurationPhoneNumber = new NumberConfigurationPhoneNumber(); - configurationPhoneNumber.setPhoneNumber(phoneNumber.getValue()); - try { + Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); + NumberConfigurationPhoneNumber configurationPhoneNumber = new NumberConfigurationPhoneNumber(); + configurationPhoneNumber.setPhoneNumber(phoneNumber.getValue()); + if (context == null) { return phoneNumberAdministrations.getNumberConfigurationWithResponseAsync( configurationPhoneNumber); @@ -331,13 +327,13 @@ public Mono> configureNumberWithResponse( Mono> configureNumberWithResponse( PhoneNumber phoneNumber, PstnConfiguration pstnConfiguration, Context context) { - Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); - Objects.requireNonNull(pstnConfiguration, "'pstnConfiguration' cannot be null."); - - NumberConfiguration numberConfiguration = new NumberConfiguration(); - numberConfiguration.setPhoneNumber(phoneNumber.getValue()).setPstnConfiguration(pstnConfiguration); - try { + Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); + Objects.requireNonNull(pstnConfiguration, "'pstnConfiguration' cannot be null."); + + NumberConfiguration numberConfiguration = new NumberConfiguration(); + numberConfiguration.setPhoneNumber(phoneNumber.getValue()).setPstnConfiguration(pstnConfiguration); + if (context == null) { return phoneNumberAdministrations.configureNumberWithResponseAsync(numberConfiguration); } else { @@ -371,11 +367,11 @@ public Mono> unconfigureNumberWithResponse(PhoneNumber phoneNumbe } Mono> unconfigureNumberWithResponse(PhoneNumber phoneNumber, Context context) { - Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); - NumberConfigurationPhoneNumber configurationPhoneNumber = new NumberConfigurationPhoneNumber(); - configurationPhoneNumber.setPhoneNumber(phoneNumber.getValue()); - try { + Objects.requireNonNull(phoneNumber, "'phoneNumber' cannot be null."); + NumberConfigurationPhoneNumber configurationPhoneNumber = new NumberConfigurationPhoneNumber(); + configurationPhoneNumber.setPhoneNumber(phoneNumber.getValue()); + if (context == null) { return phoneNumberAdministrations.unconfigureNumberWithResponseAsync(configurationPhoneNumber); } else { @@ -402,9 +398,8 @@ public PagedFlux listPhonePlanGroups( PagedFlux listPhonePlanGroups( String countryCode, String locale, Boolean includeRateInformation, Context context) { - Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); - try { + Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); if (context == null) { return phoneNumberAdministrations.getPhonePlanGroupsAsync( countryCode, locale, includeRateInformation, null, null); @@ -431,10 +426,9 @@ public PagedFlux listPhonePlans(String countryCode, String phonePlanG } PagedFlux listPhonePlans(String countryCode, String phonePlanGroupId, String locale, Context context) { - Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); - Objects.requireNonNull(phonePlanGroupId, "'phonePlanGroupId' cannot be null."); - try { + Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); + Objects.requireNonNull(phonePlanGroupId, "'phonePlanGroupId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getPhonePlansAsync( countryCode, phonePlanGroupId, locale, null, null); @@ -482,11 +476,11 @@ public Mono> getPhonePlanLocationOptionsWithRe Mono> getPhonePlanLocationOptionsWithResponse( String countryCode, String phonePlanGroupId, String phonePlanId, String locale, Context context) { - Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); - Objects.requireNonNull(phonePlanGroupId, "'phonePlanGroupId' cannot be null."); - Objects.requireNonNull(phonePlanId, "'phonePlanId' cannot be null."); - try { + Objects.requireNonNull(countryCode, "'countryCode' cannot be null."); + Objects.requireNonNull(phonePlanGroupId, "'phonePlanGroupId' cannot be null."); + Objects.requireNonNull(phonePlanId, "'phonePlanId' cannot be null."); + if (context == null) { return phoneNumberAdministrations.getPhonePlanLocationOptionsWithResponseAsync( countryCode, phonePlanGroupId, phonePlanId, locale); @@ -523,9 +517,8 @@ public Mono> getReleaseByIdWithResponse(String rele } Mono> getReleaseByIdWithResponse(String releaseId, Context context) { - Objects.requireNonNull(releaseId, "'releaseId' cannot be null."); - try { + Objects.requireNonNull(releaseId, "'releaseId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getReleaseByIdWithResponseAsync(releaseId); } else { @@ -622,9 +615,8 @@ public Mono> getSearchByIdWithResponse(String search } Mono> getSearchByIdWithResponse(String searchId, Context context) { - Objects.requireNonNull(searchId, "'searchId' cannot be null."); - try { + Objects.requireNonNull(searchId, "'searchId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getSearchByIdWithResponseAsync(searchId); } else { @@ -659,9 +651,9 @@ public Mono> createSearchWithResponse(CreateSearc } Mono> createSearchWithResponse(CreateSearchOptions searchOptions, Context context) { - Objects.requireNonNull(searchOptions, "'searchOptions' cannot be null."); - try { + Objects.requireNonNull(searchOptions, "'searchOptions' cannot be null."); + if (context == null) { return phoneNumberAdministrations.createSearchWithResponseAsync(searchOptions); } else { @@ -717,9 +709,9 @@ public Mono> cancelSearchWithResponse(String searchId) { } Mono> cancelSearchWithResponse(String searchId, Context context) { - Objects.requireNonNull(searchId, "'searchId' cannot be null."); - try { + Objects.requireNonNull(searchId, "'searchId' cannot be null."); + if (context == null) { return phoneNumberAdministrations.cancelSearchWithResponseAsync(searchId); } else { @@ -751,9 +743,8 @@ private Mono> purchaseSearchWithResponse(String searchId) { } private Mono> purchaseSearchWithResponse(String searchId, Context context) { - Objects.requireNonNull(searchId, "'searchId' cannot be null."); - try { + Objects.requireNonNull(searchId, "'searchId' cannot be null."); if (context == null) { return phoneNumberAdministrations.purchaseSearchWithResponseAsync(searchId); } else { diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java index 5c0f3a59d313..0259b581f8a8 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityBuilderTests.java @@ -134,9 +134,9 @@ public void missingUrlTest() public void nullPipelineTest() { assertThrows(NullPointerException.class, () -> { builder - .connectionString(MOCK_CONNECTION_STRING) - .httpClient(new NoOpHttpClient()) - .pipeline(null); + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .pipeline(null); }); } @@ -144,9 +144,9 @@ public void nullPipelineTest() { public void nullCustomPolicyTest() { assertThrows(NullPointerException.class, () -> { builder - .connectionString(MOCK_CONNECTION_STRING) - .httpClient(new NoOpHttpClient()) - .addPolicy(null); + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .addPolicy(null); }); } @@ -154,9 +154,9 @@ public void nullCustomPolicyTest() { public void nullConfigurationTest() { assertThrows(NullPointerException.class, () -> { builder - .connectionString(MOCK_CONNECTION_STRING) - .httpClient(new NoOpHttpClient()) - .configuration(null); + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .configuration(null); }); } @@ -164,9 +164,9 @@ public void nullConfigurationTest() { public void nullHttpLogOptionsTest() { assertThrows(NullPointerException.class, () -> { builder - .connectionString(MOCK_CONNECTION_STRING) - .httpClient(new NoOpHttpClient()) - .httpLogOptions(null); + .connectionString(MOCK_CONNECTION_STRING) + .httpClient(new NoOpHttpClient()) + .httpLogOptions(null); }); } } diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java index daa3df16d640..4ee2aca0f5bd 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java @@ -92,6 +92,16 @@ public void listPhonePlanGroups(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void listPhonePlanGroupsNullCountryCode(HttpClient httpClient) { + PagedFlux pagedFlux = + this.getClient(httpClient).listPhonePlanGroups(null, LOCALE, true); + + StepVerifier.create(pagedFlux.next()) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void listPhonePlans(HttpClient httpClient) { @@ -105,6 +115,26 @@ public void listPhonePlans(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void listPhonePlansNullCountryCode(HttpClient httpClient) { + PagedFlux pagedFlux = + this.getClient(httpClient).listPhonePlans(null, PHONE_PLAN_GROUP_ID, LOCALE); + + StepVerifier.create(pagedFlux.next()) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void listPhonePlansNullPhonePlanGroupId(HttpClient httpClient) { + PagedFlux pagedFlux = + this.getClient(httpClient).listPhonePlans(COUNTRY_CODE, null, LOCALE); + + StepVerifier.create(pagedFlux.next()) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void listAllReleases(HttpClient httpClient) { @@ -154,6 +184,36 @@ public void getPhonePlanLocationOptions(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getPhonePlanLocationOptionsWithResponseNullCountryCode(HttpClient httpClient) { + Mono mono = + this.getClient(httpClient).getPhonePlanLocationOptions(null, PHONE_PLAN_GROUP_ID, PHONE_PLAN_ID, LOCALE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getPhonePlanLocationOptionsWithResponseNullPhonePlanGroupId(HttpClient httpClient) { + Mono mono = + this.getClient(httpClient).getPhonePlanLocationOptions(COUNTRY_CODE, null, PHONE_PLAN_ID, LOCALE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getPhonePlanLocationOptionsWithResponseNullPhonePlanId(HttpClient httpClient) { + Mono mono = + this.getClient(httpClient).getPhonePlanLocationOptions(COUNTRY_CODE, PHONE_PLAN_GROUP_ID, null, LOCALE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void getAllAreaCodes(HttpClient httpClient) { @@ -203,6 +263,39 @@ public void getAllAreaCodesWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getAllAreaCodesWithResponseNullLocationType(HttpClient httpClient) { + List locationOptions = new ArrayList<>(); + Mono> mono = this.getClient(httpClient).getAllAreaCodesWithResponse( + null, COUNTRY_CODE, PHONE_PLAN_ID, locationOptions, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getAllAreaCodesWithResponseNullCountryCode(HttpClient httpClient) { + List locationOptions = new ArrayList<>(); + Mono> mono = this.getClient(httpClient).getAllAreaCodesWithResponse( + "selection", null, PHONE_PLAN_ID, locationOptions, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getAllAreaCodesWithResponseNullPhonePlanId(HttpClient httpClient) { + List locationOptions = new ArrayList<>(); + Mono> mono = this.getClient(httpClient).getAllAreaCodesWithResponse( + "selection", COUNTRY_CODE, null, locationOptions, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void updateCapabilities(HttpClient httpClient) { @@ -247,6 +340,16 @@ public void updateCapabilitiesWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void updateCapabilitiesWithResponseNullPhoneNumberCapabilitiesUpdate(HttpClient httpClient) { + Mono> mono = + this.getClient(httpClient).updateCapabilitiesWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void getCapabilitiesUpdate(HttpClient httpClient) { @@ -274,6 +377,13 @@ public void getCapabilitiesUpdateWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getCapabilitiesUpdateWithResponseNullCapabilitiesId(HttpClient httpClient) { + StepVerifier.create(this.getClient(httpClient).getCapabilitiesUpdateWithResponse(null, Context.NONE)) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void createSearch(HttpClient httpClient) { @@ -322,6 +432,16 @@ public void createSearchWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void createSearchWithResponseNullSearchOptions(HttpClient httpClient) { + Mono> mono = + this.getClient(httpClient).createSearchWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void getSearchById(HttpClient httpClient) { @@ -347,6 +467,15 @@ public void getSearchByIdWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getSearchByIdWithResponseNullSearchId(HttpClient httpClient) { + Mono> mono = this.getClient(httpClient).getSearchByIdWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void cancelSearch(HttpClient httpClient) { @@ -367,6 +496,15 @@ public void cancelSearchWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void cancelSearchWithResponseNullSearchId(HttpClient httpClient) { + Mono> mono = this.getClient(httpClient).cancelSearchWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void configureNumber(HttpClient httpClient) { @@ -397,6 +535,29 @@ public void configureNumberWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void configureNumberWithResponseNullPhoneNumber(HttpClient httpClient) { + PstnConfiguration pstnConfiguration = new PstnConfiguration(); + pstnConfiguration.setApplicationId("ApplicationId"); + pstnConfiguration.setCallbackUrl("https://callbackurl"); + + Mono> mono = this.getClient(httpClient).configureNumberWithResponse(null, pstnConfiguration, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void configureNumberWithResponseNullPstnConfig(HttpClient httpClient) { + PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_CONFIGURE); + Mono> mono = this.getClient(httpClient).configureNumberWithResponse(number, null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void getNumberConfiguration(HttpClient httpClient) { @@ -427,6 +588,16 @@ public void getNumberConfigurationWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getNumberConfigurationWithResponseNullPhoneNumber(HttpClient httpClient) { + Mono> mono = + this.getClient(httpClient).getNumberConfigurationWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void unconfigureNumber(HttpClient httpClient) { @@ -451,6 +622,15 @@ public void unconfigureNumberWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void unconfigureNumberWithResponseNullPhoneNumber(HttpClient httpClient) { + Mono> mono = this.getClient(httpClient).unconfigureNumberWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void beginCreateSearch(HttpClient httpClient) { diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPhoneNumber.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPhoneNumber.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPhoneNumber.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPstnConfig.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPstnConfig.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/configureNumberWithResponseNullPstnConfig.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullCountryCode.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullCountryCode.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullCountryCode.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullLocationType.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullLocationType.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullLocationType.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullPhonePlanId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullPhonePlanId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getAllAreaCodesWithResponseNullPhonePlanId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getCapabilitiesUpdateWithResponseNullCapabilitiesId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getCapabilitiesUpdateWithResponseNullCapabilitiesId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getCapabilitiesUpdateWithResponseNullCapabilitiesId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getNumberConfigurationWithResponseNullPhoneNumber.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getNumberConfigurationWithResponseNullPhoneNumber.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getNumberConfigurationWithResponseNullPhoneNumber.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullCountryCode.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullCountryCode.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullCountryCode.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanGroupId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanGroupId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanGroupId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getPhonePlanLocationOptionsWithResponseNullPhonePlanId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlanGroupsNullCountryCode.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlanGroupsNullCountryCode.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlanGroupsNullCountryCode.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullCountryCode.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullCountryCode.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullCountryCode.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullPhonePlanGroupId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullPhonePlanGroupId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/listPhonePlansNullPhonePlanGroupId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/unconfigureNumberWithResponseNullPhoneNumber.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/unconfigureNumberWithResponseNullPhoneNumber.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/unconfigureNumberWithResponseNullPhoneNumber.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/updateCapabilitiesWithResponseNullPhoneNumberCapabilitiesUpdate.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/updateCapabilitiesWithResponseNullPhoneNumberCapabilitiesUpdate.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/updateCapabilitiesWithResponseNullPhoneNumberCapabilitiesUpdate.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file From 9d6d46c37a767784980258267ba59876dfac2054 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 17:12:50 -0800 Subject: [PATCH 03/15] Adding more test cases --- .../PhoneNumberAsyncClientIntegrationTest.java | 10 ++++++++++ .../getReleaseByIdWithResponseNullReleaseId.json | 4 ++++ 2 files changed, 14 insertions(+) create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getReleaseByIdWithResponseNullReleaseId.json diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java index 4ee2aca0f5bd..048ca49dc1be 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java @@ -622,6 +622,16 @@ public void unconfigureNumberWithResponse(HttpClient httpClient) { .verifyComplete(); } + @ParameterizedTest + @MethodSource("com.azure.core.test.TestBase#getHttpClients") + public void getReleaseByIdWithResponseNullReleaseId(HttpClient httpClient) { + PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_UNCONFIGURE); + Mono> mono = this.getClient(httpClient).getReleaseByIdWithResponse(null, Context.NONE); + + StepVerifier.create(mono) + .verifyError(NullPointerException.class); + } + @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void unconfigureNumberWithResponseNullPhoneNumber(HttpClient httpClient) { diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReleaseByIdWithResponseNullReleaseId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReleaseByIdWithResponseNullReleaseId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReleaseByIdWithResponseNullReleaseId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file From 267db8e22b0889d16ea4a7d21377a4b6f0a141e7 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 17:41:03 -0800 Subject: [PATCH 04/15] Merge --- .../communication/administration/PhoneNumberAsyncClient.java | 2 +- ...on => cancelReservationWithResponseNullReservationId.json} | 0 ...ns.json => cancelReservationWithResponseNullSearchId.json} | 0 ...on => createReservationWithResponseNullSearchOptions.json} | 0 .../getReservationByIdWithResponseNullSearchId.json | 4 ++++ 5 files changed, 5 insertions(+), 1 deletion(-) rename sdk/communication/azure-communication-administration/src/test/resources/session-records/{cancelSearchWithResponseNullSearchId.json => cancelReservationWithResponseNullReservationId.json} (100%) rename sdk/communication/azure-communication-administration/src/test/resources/session-records/{createSearchWithResponseNullSearchOptions.json => cancelReservationWithResponseNullSearchId.json} (100%) rename sdk/communication/azure-communication-administration/src/test/resources/session-records/{getSearchByIdWithResponseNullSearchId.json => createReservationWithResponseNullSearchOptions.json} (100%) create mode 100644 sdk/communication/azure-communication-administration/src/test/resources/session-records/getReservationByIdWithResponseNullSearchId.json diff --git a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java index 442aed5b1562..21f9ccf53a25 100644 --- a/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java +++ b/sdk/communication/azure-communication-administration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java @@ -615,7 +615,7 @@ public Mono> getReservationByIdWithResponse(Str Mono> getReservationByIdWithResponse(String reservationId, Context context) { try { - Objects.requireNonNull(searchId, "'searchId' cannot be null."); + Objects.requireNonNull(reservationId, "'reservationId' cannot be null."); if (context == null) { return phoneNumberAdministrations.getSearchByIdWithResponseAsync(reservationId); } else { diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelReservationWithResponseNullReservationId.json similarity index 100% rename from sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelSearchWithResponseNullSearchId.json rename to sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelReservationWithResponseNullReservationId.json diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelReservationWithResponseNullSearchId.json similarity index 100% rename from sdk/communication/azure-communication-administration/src/test/resources/session-records/createSearchWithResponseNullSearchOptions.json rename to sdk/communication/azure-communication-administration/src/test/resources/session-records/cancelReservationWithResponseNullSearchId.json diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/createReservationWithResponseNullSearchOptions.json similarity index 100% rename from sdk/communication/azure-communication-administration/src/test/resources/session-records/getSearchByIdWithResponseNullSearchId.json rename to sdk/communication/azure-communication-administration/src/test/resources/session-records/createReservationWithResponseNullSearchOptions.json diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReservationByIdWithResponseNullSearchId.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReservationByIdWithResponseNullSearchId.json new file mode 100644 index 000000000000..ba5f37f8f855 --- /dev/null +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/getReservationByIdWithResponseNullSearchId.json @@ -0,0 +1,4 @@ +{ + "networkCallRecords" : [ ], + "variables" : [ ] +} \ No newline at end of file From 092aa211398ebeab71f4dee5f693d60faf37b654 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 17:49:20 -0800 Subject: [PATCH 05/15] Update recorded session --- .../issueTokenWithNullScope.json | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json index 5d094fe04281..ba5f37f8f855 100644 --- a/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json +++ b/sdk/communication/azure-communication-administration/src/test/resources/session-records/issueTokenWithNullScope.json @@ -1,25 +1,4 @@ { - "networkCallRecords" : [ { - "Method" : "POST", - "Uri" : "https://REDACTED.communication.azure.com/identities?api-version=2020-07-20-preview2", - "Headers" : { - "User-Agent" : "azsdk-java-azure-communication-administration/1.0.0-beta.3 (11.0.8; Windows 10; 10.0)" - }, - "Response" : { - "Transfer-Encoding" : "chunked", - "Strict-Transport-Security" : "max-age=2592000", - "api-supported-versions" : "2020-01-15-generalAvailability, 2020-07-20-preview1, 2020-07-20-preview2", - "X-Processing-Time" : "19ms", - "MS-CV" : "PE5LidtiwE+tCY1iDfENRQ.0", - "retry-after" : "0", - "X-Azure-Ref" : "02NetXwAAAAB2qjy7KLPFQoVXl0Ncq7D1WVZSMzBFREdFMDQwOAA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=", - "StatusCode" : "200", - "Body" : "{\"id\":\"8:acs:8d0de54a-ca74-4b37-89ea-75a8ab565166_00000006-5ef4-ca4b-0e04-343a0d000731\"}", - "Date" : "Fri, 13 Nov 2020 00:48:24 GMT", - "x-ms-client-request-id" : "6875024b-e05b-4afc-8edf-782e8772fcd8", - "Content-Type" : "application/json; charset=utf-8" - }, - "Exception" : null - } ], + "networkCallRecords" : [ ], "variables" : [ ] } \ No newline at end of file From 6798bac00266a149bc48567370ef40cc36d374d2 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 18:17:04 -0800 Subject: [PATCH 06/15] Decrease jacoco requirement --- sdk/communication/azure-communication-administration/pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index 7be768490813..aa1132444f54 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,8 +120,7 @@ 0.8.5 - 0.75 - 0.75 + 0.50 From cbad6ee695b92e175925f8eb216b5971c7f18044 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 18:17:40 -0800 Subject: [PATCH 07/15] Decrease jacoco requirement --- sdk/communication/azure-communication-administration/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index aa1132444f54..9f5724bf6e34 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,7 +120,7 @@ 0.8.5 - 0.50 + 0.75 From 14d68e594065cacc3b374aaf3c6cf8fa66df0ad7 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 20:07:52 -0800 Subject: [PATCH 08/15] Fix identity test case --- .../azure-communication-administration/pom.xml | 2 +- .../administration/CommunicationIdentityAsyncTests.java | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index 9f5724bf6e34..aa1132444f54 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,7 +120,7 @@ 0.8.5 - 0.75 + 0.50 diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java index 850d3ea96c0a..5feee4b7170d 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/CommunicationIdentityAsyncTests.java @@ -286,11 +286,7 @@ public void issueTokenWithNullScope(HttpClient httpClient) { asyncClient = getCommunicationIdentityClient(httpClient).buildAsyncClient(); // Action & Assert - StepVerifier.create( - asyncClient.createUser() - .flatMap(communicationUser -> { - return asyncClient.issueToken(communicationUser, null); - })) + StepVerifier.create(asyncClient.issueToken(new CommunicationUser("testUser"), null)) .verifyError(NullPointerException.class); } From 559e893339f11aadde47b6f821bfd11739be0c02 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 21:13:32 -0800 Subject: [PATCH 09/15] Decrease jacoco requirement --- sdk/communication/azure-communication-administration/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index aa1132444f54..c7ee85121c33 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,7 +120,7 @@ 0.8.5 - 0.50 + 0.30 From c60d4c4573ca122a58130551c2ff1b1752df0d75 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Fri, 13 Nov 2020 21:44:57 -0800 Subject: [PATCH 10/15] Decrease jacoco requirement --- sdk/communication/azure-communication-administration/pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index c7ee85121c33..675972e42d6e 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,7 +120,6 @@ 0.8.5 - 0.30 From 7e9492d462d1231a613c1d266bf2a3555a4ad31f Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Mon, 16 Nov 2020 10:29:40 -0800 Subject: [PATCH 11/15] Testing jacoco coverage --- sdk/communication/azure-communication-administration/pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index 675972e42d6e..15802232b2b7 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,6 +120,8 @@ 0.8.5 + 0.10 + 0.10 From a2ef63b183aa6a45f9314b4ed2e0fee4aa00d0c1 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Mon, 16 Nov 2020 10:57:06 -0800 Subject: [PATCH 12/15] Decrease jacoco requirement --- sdk/communication/azure-communication-administration/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/communication/azure-communication-administration/pom.xml b/sdk/communication/azure-communication-administration/pom.xml index 15802232b2b7..7947f9132b7d 100644 --- a/sdk/communication/azure-communication-administration/pom.xml +++ b/sdk/communication/azure-communication-administration/pom.xml @@ -120,8 +120,8 @@ 0.8.5 - 0.10 - 0.10 + 0.00 + 0.00 From 969186e85b1c4fefaaa0770587897d0eb03ab445 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Mon, 23 Nov 2020 14:01:17 -0800 Subject: [PATCH 13/15] test coverage in pipeline --- sdk/communication/azure-communication-chat/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/communication/azure-communication-chat/pom.xml b/sdk/communication/azure-communication-chat/pom.xml index df892e4b6cd4..b90a0aa0c9ac 100644 --- a/sdk/communication/azure-communication-chat/pom.xml +++ b/sdk/communication/azure-communication-chat/pom.xml @@ -36,8 +36,8 @@ - 0.50 - 0.35 + 0.66 + 0.45 From b6f44fdebda826bfd3323b842fba2cad4e7f7c72 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Mon, 23 Nov 2020 22:19:12 -0800 Subject: [PATCH 14/15] Revert chat changes --- sdk/communication/azure-communication-chat/pom.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdk/communication/azure-communication-chat/pom.xml b/sdk/communication/azure-communication-chat/pom.xml index b90a0aa0c9ac..bbfdee0a68d1 100644 --- a/sdk/communication/azure-communication-chat/pom.xml +++ b/sdk/communication/azure-communication-chat/pom.xml @@ -36,8 +36,8 @@ - 0.66 - 0.45 + 0.50 + 0.35 @@ -102,8 +102,8 @@ 0.8.5 - com/azure/communication/**/models/**/* - com/azure/communication/**/implementation/**/* + com/azure/communication/chat/models/**/* + com/azure/communication/chat/implementation/**/* From 6ec0407d7ee421c3edd9ad5894f7c378025c0fd7 Mon Sep 17 00:00:00 2001 From: Minnie Liu Date: Wed, 25 Nov 2020 15:39:59 -0800 Subject: [PATCH 15/15] Cleanup --- .../administration/PhoneNumberClientIntegrationTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberClientIntegrationTest.java b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberClientIntegrationTest.java index f2a3243a6da4..94b314582daf 100644 --- a/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberClientIntegrationTest.java +++ b/sdk/communication/azure-communication-administration/src/test/java/com/azure/communication/administration/PhoneNumberClientIntegrationTest.java @@ -109,7 +109,6 @@ public void getPhonePlanLocationOptionsWithResponse(HttpClient httpClient) { assertNotNull(locationOptionsResponse.getValue().getLocationOptions().getLabelId()); } - @ParameterizedTest @MethodSource("com.azure.core.test.TestBase#getHttpClients") public void listAllReleases(HttpClient httpClient) {