diff --git a/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml b/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml index 05a4da3620ee..61537fcf6e57 100755 --- a/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml +++ b/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml @@ -2458,23 +2458,35 @@ - + - + - + + + + + + + + + + + + + diff --git a/sdk/keyvault/azure-security-keyvault-jca/pom.xml b/sdk/keyvault/azure-security-keyvault-jca/pom.xml index d2ee04e7f8d8..f0919035645d 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/pom.xml +++ b/sdk/keyvault/azure-security-keyvault-jca/pom.xml @@ -122,14 +122,6 @@ - - com.github.spotbugs - spotbugs-maven-plugin - 3.1.12.2 - - true - - org.revapi revapi-maven-plugin @@ -148,12 +140,12 @@ 5.0.1 true + org.conscrypt conscrypt-openjdk-uber - compile + provided 2.2.1 - true @@ -192,14 +184,14 @@ it diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyManager.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyManager.java index 1cf099d84b0f..4e42e1505b56 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyManager.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyManager.java @@ -50,7 +50,12 @@ public class KeyVaultKeyManager extends X509ExtendedKeyManager { public KeyVaultKeyManager(KeyStore keystore, char[] password) { LOGGER.entering("KeyVaultKeyManager", "", new Object[] { keystore, password }); this.keystore = keystore; - this.password = password; + if (password != null) { + this.password = new char[password.length]; + System.arraycopy(password, 0, this.password, 0, password.length); + } else { + this.password = null; + } } @Override diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java index 634a6e1924fe..7c21d9570375 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java @@ -9,6 +9,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.io.OutputStream; +import java.nio.charset.StandardCharsets; import java.security.Key; import java.security.KeyStore; import java.security.KeyStoreException; @@ -33,7 +34,7 @@ /** * The Azure Key Vault implementation of the KeyStoreSpi. */ -public class KeyVaultKeyStore extends KeyStoreSpi { +public final class KeyVaultKeyStore extends KeyStoreSpi { /** * Stores the logger. @@ -155,7 +156,7 @@ public Certificate[] engineGetCertificateChain(String alias) { @Override public Date engineGetCreationDate(String alias) { - return creationDate; + return new Date(creationDate.getTime()); } @Override @@ -259,7 +260,7 @@ private String[] getFilenames(String path) throws IOException { List filenames = new ArrayList<>(); try (InputStream in = getClass().getResourceAsStream(path)) { if (in != null) { - try (BufferedReader br = new BufferedReader(new InputStreamReader(in))) { + try (BufferedReader br = new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8))) { String resource; while ((resource = br.readLine()) != null) { filenames.add(resource); diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateBundle.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateBundle.java index c874a5483b3c..21c4b983aaa0 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateBundle.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateBundle.java @@ -9,6 +9,11 @@ * The CertificateBundle REST model. */ public class CertificateBundle implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the CER bytes. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateItem.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateItem.java index 66dbcf277c66..fcfa95233a8c 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateItem.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateItem.java @@ -9,6 +9,11 @@ * The CertificateItem REST model. */ public class CertificateItem implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the id. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateListResult.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateListResult.java index 59dd984e3db4..f993a58d5c15 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateListResult.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificateListResult.java @@ -10,6 +10,11 @@ * The CertificateItem REST model. */ public class CertificateListResult implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the value. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificatePolicy.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificatePolicy.java index 871d73500038..adefbfb134c3 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificatePolicy.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/CertificatePolicy.java @@ -10,6 +10,11 @@ * The CertificatePolicy REST model. */ public class CertificatePolicy implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the key properties. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/KeyProperties.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/KeyProperties.java index 52ee90d4826a..7d4b5c77982a 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/KeyProperties.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/KeyProperties.java @@ -9,6 +9,11 @@ * The KeyProperties REST model. */ public class KeyProperties implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores if the key is exportable. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/OAuthToken.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/OAuthToken.java index 55206bc4070a..63841f788059 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/OAuthToken.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/OAuthToken.java @@ -9,6 +9,11 @@ * An OAuth2 token. */ public class OAuthToken implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the access token. diff --git a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/SecretBundle.java b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/SecretBundle.java index a15f8ba47745..ce2d65880510 100644 --- a/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/SecretBundle.java +++ b/sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/rest/SecretBundle.java @@ -9,6 +9,11 @@ * The SecretBundle REST model. */ public class SecretBundle implements Serializable { + + /** + * Stores the serial version UID. + */ + private static final long serialVersionUID = 1L; /** * Stores the value.