add module-info for azure-resourcemanager #15163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
requested review from
ChenTanyi,
weidongxu-microsoft and
yungezz
as code owners
sdk/resourcemanager/azure-resourcemanager-keyvault/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Sep 14, 2020
ChenTanyi
approved these changes
Sep 15, 2020
srnagar
approved these changes
Sep 17, 2020
Member
srnagar
left a comment
srnagar
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of questions that we need to resolve.
Comment on lines
+7
to
+8
| requires transitive com.azure.resourcemanager.network; | ||
| requires transitive com.azure.resourcemanager.storage; |
Member
There was a problem hiding this comment.
Do you need network and storage also to be transitive?
Contributor
Author
There was a problem hiding this comment.
In fluent interfaces, we provide convenient configs when creating virtual machine, like withExistingPrimaryNetwork(Network network), withExistingStorageAccount(StorageAccount storageAccount). The Network comes from module of com.azure.resourcemanager.network, and the StorageAccount is from com.azure.resourcemanager.storage.
Thus it requires transitive keyword. Otherwise, the end users have to add additional requires statement explicitly when calling withExistingPrimaryNetwork/withExistingStorageAccount.
sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #14127.
As discussed with @JonathanGiles offline, we decide to use statement of
export ... to ...for the qualified exports. This is because the impls insidefluentcoreofazure-resourcemanager-resourcesare common classes across mutiple modules, while they are not required to expose to end users.Inside
module-info, we apply a fewrequires transitiveas there are a few methods allowingwith*Resource*(Creatable<*Resource*>)provided by other services. For example, there is methodwithNewStorageAccount(Creatable<StorageAccount>)inazure-resourcemanager-compute, of which theStorageAccountcomes fromazure-resourcemanager-storage.