diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeSentimentAsyncClient.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeSentimentAsyncClient.java index 9399fdbf69f0..ab8e384c532d 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeSentimentAsyncClient.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeSentimentAsyncClient.java @@ -6,17 +6,18 @@ import com.azure.ai.textanalytics.implementation.TextAnalyticsClientImpl; import com.azure.ai.textanalytics.implementation.models.DocumentError; import com.azure.ai.textanalytics.implementation.models.DocumentSentiment; +import com.azure.ai.textanalytics.implementation.models.DocumentSentimentValue; import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput; +import com.azure.ai.textanalytics.implementation.models.SentenceSentimentValue; import com.azure.ai.textanalytics.implementation.models.SentimentConfidenceScorePerLabel; import com.azure.ai.textanalytics.implementation.models.SentimentResponse; +import com.azure.ai.textanalytics.implementation.models.WarningCodeValue; import com.azure.ai.textanalytics.models.AnalyzeSentimentResult; import com.azure.ai.textanalytics.models.SentenceSentiment; import com.azure.ai.textanalytics.models.SentimentConfidenceScores; import com.azure.ai.textanalytics.models.TextAnalyticsRequestOptions; import com.azure.ai.textanalytics.models.TextAnalyticsWarning; import com.azure.ai.textanalytics.models.TextDocumentInput; -import com.azure.ai.textanalytics.models.TextSentiment; -import com.azure.ai.textanalytics.models.WarningCode; import com.azure.ai.textanalytics.util.TextAnalyticsPagedFlux; import com.azure.ai.textanalytics.util.TextAnalyticsPagedResponse; import com.azure.core.exception.HttpResponseException; @@ -28,7 +29,6 @@ import java.util.ArrayList; import java.util.List; -import java.util.Locale; import java.util.stream.Collectors; import static com.azure.ai.textanalytics.TextAnalyticsAsyncClient.COGNITIVE_TRACING_NAMESPACE_VALUE; @@ -146,51 +146,35 @@ private TextAnalyticsPagedResponse toTextAnalyticsPagedR */ private AnalyzeSentimentResult convertToAnalyzeSentimentResult(DocumentSentiment documentSentiment) { // Document text sentiment - final TextSentiment documentSentimentLabel = TextSentiment.fromString( - documentSentiment.getSentiment().toString()); - if (documentSentimentLabel == null) { - // Not throw exception for an invalid Sentiment type because we should not skip processing the - // other response. It is a service issue. - logger.logExceptionAsWarning( - new RuntimeException(String.format(Locale.ROOT, "'%s' is not valid text sentiment.", - documentSentiment.getSentiment()))); - } - final SentimentConfidenceScorePerLabel confidenceScorePerLabel = documentSentiment.getConfidenceScores(); - // Sentence text sentiment final List sentenceSentiments = documentSentiment.getSentences().stream() .map(sentenceSentiment -> { - final TextSentiment sentenceSentimentLabel = TextSentiment.fromString( - sentenceSentiment.getSentiment().toString()); - if (sentenceSentimentLabel == null) { - // Not throw exception for an invalid Sentiment type because we should not skip processing the - // other response. It is a service issue. - logger.logExceptionAsWarning( - new RuntimeException(String.format(Locale.ROOT, "'%s' is not valid text sentiment.", - sentenceSentiment.getSentiment()))); - } final SentimentConfidenceScorePerLabel confidenceScorePerSentence = sentenceSentiment.getConfidenceScores(); - + final SentenceSentimentValue sentenceSentimentValue = sentenceSentiment.getSentiment(); return new SentenceSentiment(sentenceSentiment.getText(), - sentenceSentimentLabel, + sentenceSentimentValue == null ? null : sentenceSentimentValue.toString(), new SentimentConfidenceScores(confidenceScorePerSentence.getNegative(), confidenceScorePerSentence.getNeutral(), confidenceScorePerSentence.getPositive())); }).collect(Collectors.toList()); // Warnings final List warnings = documentSentiment.getWarnings().stream().map( - warning -> new TextAnalyticsWarning(WarningCode.fromString(warning.getCode().toString()), - warning.getMessage())).collect(Collectors.toList()); + warning -> { + final WarningCodeValue warningCodeValue = warning.getCode(); + return new TextAnalyticsWarning(warningCodeValue == null ? null : warningCodeValue.toString(), + warning.getMessage()); + }).collect(Collectors.toList()); + final DocumentSentimentValue documentSentimentValue = documentSentiment.getSentiment(); return new AnalyzeSentimentResult( documentSentiment.getId(), documentSentiment.getStatistics() == null ? null : toTextDocumentStatistics(documentSentiment.getStatistics()), null, new com.azure.ai.textanalytics.models.DocumentSentiment( - documentSentimentLabel, + documentSentimentValue == null ? null : documentSentimentValue.toString(), new SentimentConfidenceScores( confidenceScorePerLabel.getNegative(), confidenceScorePerLabel.getNeutral(), diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/DetectLanguageAsyncClient.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/DetectLanguageAsyncClient.java index 47bb7fada9cb..97b6a21cb165 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/DetectLanguageAsyncClient.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/DetectLanguageAsyncClient.java @@ -8,12 +8,12 @@ import com.azure.ai.textanalytics.implementation.models.DocumentLanguage; import com.azure.ai.textanalytics.implementation.models.LanguageBatchInput; import com.azure.ai.textanalytics.implementation.models.LanguageResult; +import com.azure.ai.textanalytics.implementation.models.WarningCodeValue; import com.azure.ai.textanalytics.models.DetectLanguageInput; import com.azure.ai.textanalytics.models.DetectLanguageResult; import com.azure.ai.textanalytics.models.DetectedLanguage; import com.azure.ai.textanalytics.models.TextAnalyticsRequestOptions; import com.azure.ai.textanalytics.models.TextAnalyticsWarning; -import com.azure.ai.textanalytics.models.WarningCode; import com.azure.ai.textanalytics.util.TextAnalyticsPagedFlux; import com.azure.ai.textanalytics.util.TextAnalyticsPagedResponse; import com.azure.core.exception.HttpResponseException; @@ -114,10 +114,12 @@ private TextAnalyticsPagedResponse toTextAnalyticsPagedRes documentLanguage.getDetectedLanguage(); // warnings - final List warnings = documentLanguage.getWarnings().stream().map(warning -> - new TextAnalyticsWarning(WarningCode.fromString(warning.getCode().toString()), - warning.getMessage())).collect(Collectors.toList()); - + final List warnings = documentLanguage.getWarnings().stream() + .map(warning -> { + final WarningCodeValue warningCodeValue = warning.getCode(); + return new TextAnalyticsWarning(warningCodeValue == null ? null : warningCodeValue.toString(), + warning.getMessage()); + }).collect(Collectors.toList()); detectLanguageResults.add(new DetectLanguageResult( documentLanguage.getId(), diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/ExtractKeyPhraseAsyncClient.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/ExtractKeyPhraseAsyncClient.java index 8f2cd601f549..0b95a130db97 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/ExtractKeyPhraseAsyncClient.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/ExtractKeyPhraseAsyncClient.java @@ -8,13 +8,13 @@ import com.azure.ai.textanalytics.implementation.models.DocumentKeyPhrases; import com.azure.ai.textanalytics.implementation.models.KeyPhraseResult; import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput; +import com.azure.ai.textanalytics.implementation.models.WarningCodeValue; import com.azure.ai.textanalytics.models.ExtractKeyPhraseResult; import com.azure.ai.textanalytics.models.KeyPhrasesCollection; import com.azure.ai.textanalytics.models.TextAnalyticsError; import com.azure.ai.textanalytics.models.TextAnalyticsRequestOptions; import com.azure.ai.textanalytics.models.TextAnalyticsWarning; import com.azure.ai.textanalytics.models.TextDocumentInput; -import com.azure.ai.textanalytics.models.WarningCode; import com.azure.ai.textanalytics.util.TextAnalyticsPagedFlux; import com.azure.ai.textanalytics.util.TextAnalyticsPagedResponse; import com.azure.core.exception.HttpResponseException; @@ -150,10 +150,11 @@ private TextAnalyticsPagedResponse toTextAnalyticsPagedR : toTextDocumentStatistics(documentKeyPhrases.getStatistics()), null, new KeyPhrasesCollection( new IterableStream<>(documentKeyPhrases.getKeyPhrases()), - new IterableStream<>(documentKeyPhrases.getWarnings().stream().map(warning -> - new TextAnalyticsWarning(WarningCode.fromString(warning.getCode().toString()), - warning.getMessage())) - .collect(Collectors.toList()))))); + new IterableStream<>(documentKeyPhrases.getWarnings().stream().map(warning -> { + final WarningCodeValue warningCodeValue = warning.getCode(); + return new TextAnalyticsWarning(warningCodeValue == null ? null : warningCodeValue.toString(), + warning.getMessage()); + }).collect(Collectors.toList()))))); } // Document errors for (DocumentError documentError : keyPhraseResult.getErrors()) { diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeEntityAsyncClient.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeEntityAsyncClient.java index fa067b430679..249f17ff28c5 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeEntityAsyncClient.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeEntityAsyncClient.java @@ -6,14 +6,13 @@ import com.azure.ai.textanalytics.implementation.TextAnalyticsClientImpl; import com.azure.ai.textanalytics.implementation.models.EntitiesResult; import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput; +import com.azure.ai.textanalytics.implementation.models.WarningCodeValue; import com.azure.ai.textanalytics.models.CategorizedEntity; import com.azure.ai.textanalytics.models.CategorizedEntityCollection; -import com.azure.ai.textanalytics.models.EntityCategory; import com.azure.ai.textanalytics.models.RecognizeEntitiesResult; import com.azure.ai.textanalytics.models.TextAnalyticsRequestOptions; import com.azure.ai.textanalytics.models.TextAnalyticsWarning; import com.azure.ai.textanalytics.models.TextDocumentInput; -import com.azure.ai.textanalytics.models.WarningCode; import com.azure.ai.textanalytics.util.TextAnalyticsPagedFlux; import com.azure.ai.textanalytics.util.TextAnalyticsPagedResponse; import com.azure.core.exception.HttpResponseException; @@ -151,13 +150,15 @@ private TextAnalyticsPagedResponse toTextAnalyticsPaged null, new CategorizedEntityCollection( new IterableStream<>(documentEntities.getEntities().stream().map(entity -> - new CategorizedEntity(entity.getText(), EntityCategory.fromString(entity.getCategory()), + new CategorizedEntity(entity.getText(), entity.getCategory(), entity.getSubcategory(), entity.getConfidenceScore())) .collect(Collectors.toList())), - new IterableStream<>(documentEntities.getWarnings().stream().map(warning -> - new TextAnalyticsWarning(WarningCode.fromString(warning.getCode().toString()), - warning.getMessage())) - .collect(Collectors.toList()))) + new IterableStream<>(documentEntities.getWarnings().stream() + .map(warning -> { + final WarningCodeValue warningCodeValue = warning.getCode(); + return new TextAnalyticsWarning( + warningCodeValue == null ? null : warningCodeValue.toString(), warning.getMessage()); + }).collect(Collectors.toList()))) ))); // Document errors entitiesResult.getErrors().forEach(documentError -> { diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeLinkedEntityAsyncClient.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeLinkedEntityAsyncClient.java index 27cb31e266a3..508c7406490b 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeLinkedEntityAsyncClient.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeLinkedEntityAsyncClient.java @@ -6,6 +6,7 @@ import com.azure.ai.textanalytics.implementation.TextAnalyticsClientImpl; import com.azure.ai.textanalytics.implementation.models.EntityLinkingResult; import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput; +import com.azure.ai.textanalytics.implementation.models.WarningCodeValue; import com.azure.ai.textanalytics.models.LinkedEntity; import com.azure.ai.textanalytics.models.LinkedEntityCollection; import com.azure.ai.textanalytics.models.LinkedEntityMatch; @@ -13,7 +14,6 @@ import com.azure.ai.textanalytics.models.TextAnalyticsRequestOptions; import com.azure.ai.textanalytics.models.TextAnalyticsWarning; import com.azure.ai.textanalytics.models.TextDocumentInput; -import com.azure.ai.textanalytics.models.WarningCode; import com.azure.ai.textanalytics.util.TextAnalyticsPagedFlux; import com.azure.ai.textanalytics.util.TextAnalyticsPagedResponse; import com.azure.core.exception.HttpResponseException; @@ -102,8 +102,7 @@ TextAnalyticsPagedFlux recognizeLinkedEntitiesBat return new TextAnalyticsPagedFlux<>(() -> (continuationToken, pageSize) -> withContext(context -> getRecognizedLinkedEntitiesResponseInPage(documents, options, context)).flux()); } catch (RuntimeException ex) { - return new TextAnalyticsPagedFlux<>(() -> - (continuationToken, pageSize) -> fluxError(logger, ex)); + return new TextAnalyticsPagedFlux<>(() -> (continuationToken, pageSize) -> fluxError(logger, ex)); } } @@ -150,10 +149,12 @@ private TextAnalyticsPagedResponse toTextAnalytic null, new LinkedEntityCollection( mapLinkedEntity(documentLinkedEntities.getEntities()), - new IterableStream<>(documentLinkedEntities.getWarnings().stream().map(warning -> - new TextAnalyticsWarning(WarningCode.fromString(warning.getCode().toString()), - warning.getMessage())) - .collect(Collectors.toList()))) + new IterableStream<>(documentLinkedEntities.getWarnings().stream() + .map(warning -> { + final WarningCodeValue warningCodeValue = warning.getCode(); + return new TextAnalyticsWarning( + warningCodeValue == null ? null : warningCodeValue.toString(), warning.getMessage()); + }).collect(Collectors.toList()))) ))); // Document errors entityLinkingResult.getErrors().forEach(documentError -> { diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java index a4784c9f8b35..03e7ccf8b485 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java @@ -13,7 +13,6 @@ import com.azure.ai.textanalytics.implementation.models.TextAnalyticsError; import com.azure.ai.textanalytics.implementation.models.TextAnalyticsErrorException; import com.azure.ai.textanalytics.models.DetectLanguageInput; -import com.azure.ai.textanalytics.models.TextAnalyticsErrorCode; import com.azure.ai.textanalytics.models.TextAnalyticsException; import com.azure.ai.textanalytics.models.TextDocumentBatchStatistics; import com.azure.ai.textanalytics.models.TextDocumentInput; @@ -174,14 +173,14 @@ public static com.azure.ai.textanalytics.models.TextAnalyticsError toTextAnalyti if (innerError == null) { final ErrorCodeValue errorCodeValue = textAnalyticsError.getCode(); return new com.azure.ai.textanalytics.models.TextAnalyticsError( - TextAnalyticsErrorCode.fromString(errorCodeValue == null ? null : errorCodeValue.toString()), + errorCodeValue == null ? null : errorCodeValue.toString(), textAnalyticsError.getMessage(), textAnalyticsError.getTarget()); } final InnerErrorCodeValue innerErrorCodeValue = innerError.getCode(); return new com.azure.ai.textanalytics.models.TextAnalyticsError( - TextAnalyticsErrorCode.fromString(innerErrorCodeValue == null ? null : innerErrorCodeValue.toString()), + innerErrorCodeValue == null ? null : innerErrorCodeValue.toString(), innerError.getMessage(), innerError.getTarget()); } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/CategorizedEntity.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/CategorizedEntity.java index fd666be4127f..1198931b93fa 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/CategorizedEntity.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/CategorizedEntity.java @@ -38,9 +38,9 @@ public final class CategorizedEntity { * @param subcategory The entity subcategory, such as Age/Year/TimeRange etc. * @param confidenceScore A confidence score between 0 and 1 of the extracted entity. */ - public CategorizedEntity(String text, EntityCategory category, String subcategory, double confidenceScore) { + public CategorizedEntity(String text, String category, String subcategory, double confidenceScore) { this.text = text; - this.category = category; + this.category = EntityCategory.fromString(category); this.subcategory = subcategory; this.confidenceScore = confidenceScore; } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/DocumentSentiment.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/DocumentSentiment.java index 39db850edbe8..1d33cb04bda3 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/DocumentSentiment.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/DocumentSentiment.java @@ -26,9 +26,9 @@ public final class DocumentSentiment { * @param sentences An {@link IterableStream} of sentence sentiments. * @param warnings An {@link IterableStream} of {@link TextAnalyticsWarning}. */ - public DocumentSentiment(TextSentiment sentiment, SentimentConfidenceScores confidenceScores, + public DocumentSentiment(String sentiment, SentimentConfidenceScores confidenceScores, IterableStream sentences, IterableStream warnings) { - this.sentiment = sentiment; + this.sentiment = TextSentiment.fromString(sentiment); this.confidenceScores = confidenceScores; this.sentences = sentences; this.warnings = warnings; diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/EntityCategory.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/EntityCategory.java index 5d412ae6b1af..4e17276052d5 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/EntityCategory.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/EntityCategory.java @@ -91,7 +91,7 @@ public final class EntityCategory extends ExpandableStringEnum { * @return The corresponding {@link EntityCategory}. */ @JsonCreator - public static EntityCategory fromString(String name) { + static EntityCategory fromString(String name) { return fromString(name, EntityCategory.class); } } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/SentenceSentiment.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/SentenceSentiment.java index 636739209fe9..b14092e5c585 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/SentenceSentiment.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/SentenceSentiment.java @@ -23,9 +23,9 @@ public final class SentenceSentiment { * @param confidenceScores The sentiment confidence score (Softmax score) between 0 and 1, for each sentiment label. * Higher values signify higher confidence. */ - public SentenceSentiment(String text, TextSentiment sentiment, SentimentConfidenceScores confidenceScores) { + public SentenceSentiment(String text, String sentiment, SentimentConfidenceScores confidenceScores) { this.text = text; - this.sentiment = sentiment; + this.sentiment = TextSentiment.fromString(sentiment); this.confidenceScores = confidenceScores; } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsError.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsError.java index 0e805491b510..1e41e50e4edc 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsError.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsError.java @@ -15,7 +15,7 @@ public final class TextAnalyticsError { * Error code. Possible values include: 'invalidRequest', * 'invalidArgument', 'internalServerError', 'serviceUnavailable' */ - private final TextAnalyticsErrorCode code; + private final TextAnalyticsErrorCode errorCode; /* * Error message. @@ -29,13 +29,12 @@ public final class TextAnalyticsError { /** * Creates a {@code TextAnalyticsError} model that describes text analytics error. - * - * @param code The error code. + * @param errorCode The error code. * @param message The error message. * @param target The error target. */ - public TextAnalyticsError(TextAnalyticsErrorCode code, String message, String target) { - this.code = code; + public TextAnalyticsError(String errorCode, String message, String target) { + this.errorCode = TextAnalyticsErrorCode.fromString(errorCode); this.message = message; this.target = target; } @@ -48,7 +47,7 @@ public TextAnalyticsError(TextAnalyticsErrorCode code, String message, String ta * @return The code value. */ public TextAnalyticsErrorCode getErrorCode() { - return this.code; + return this.errorCode; } /** diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsErrorCode.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsErrorCode.java index 6603e8cf34aa..12d47c384163 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsErrorCode.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsErrorCode.java @@ -84,7 +84,7 @@ public final class TextAnalyticsErrorCode extends ExpandableStringEnum { * @return The corresponding {@link TextSentiment}. */ @JsonCreator - public static TextSentiment fromString(String name) { + static TextSentiment fromString(String name) { return fromString(name, TextSentiment.class); } } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/WarningCode.java b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/WarningCode.java index ce3e3e17d26e..1bc7b5ea56d7 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/WarningCode.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/WarningCode.java @@ -30,7 +30,7 @@ public final class WarningCode extends ExpandableStringEnum { * @return The corresponding {@link WarningCode}. */ @JsonCreator - public static WarningCode fromString(String name) { + static WarningCode fromString(String name) { return fromString(name, WarningCode.class); } } diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TestUtils.java b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TestUtils.java index 70701be0504b..9f9babba652e 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TestUtils.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TestUtils.java @@ -181,9 +181,9 @@ static TextAnalyticsPagedResponse getExpectedCategorizedEntit * Helper method to get the expected Categorized Entities List 1 */ static List getCategorizedEntitiesList1() { - CategorizedEntity categorizedEntity1 = new CategorizedEntity("trip", EntityCategory.EVENT, null, 0.0); - CategorizedEntity categorizedEntity2 = new CategorizedEntity("Seattle", EntityCategory.LOCATION, "GPE", 0.0); - CategorizedEntity categorizedEntity3 = new CategorizedEntity("last week", EntityCategory.DATE_TIME, "DateRange", 0.0); + CategorizedEntity categorizedEntity1 = new CategorizedEntity("trip", EntityCategory.EVENT.toString(), null, 0.0); + CategorizedEntity categorizedEntity2 = new CategorizedEntity("Seattle", EntityCategory.LOCATION.toString(), "GPE", 0.0); + CategorizedEntity categorizedEntity3 = new CategorizedEntity("last week", EntityCategory.DATE_TIME.toString(), "DateRange", 0.0); return Arrays.asList(categorizedEntity1, categorizedEntity2, categorizedEntity3); } @@ -191,7 +191,7 @@ static List getCategorizedEntitiesList1() { * Helper method to get the expected Categorized Entities List 2 */ static List getCategorizedEntitiesList2() { - CategorizedEntity categorizedEntity3 = new CategorizedEntity("Microsoft", EntityCategory.ORGANIZATION, null, 0.0); + CategorizedEntity categorizedEntity3 = new CategorizedEntity("Microsoft", EntityCategory.ORGANIZATION.toString(), null, 0.0); return Arrays.asList(categorizedEntity3); } @@ -270,18 +270,18 @@ static TextAnalyticsPagedResponse getExpectedBatchKeyPhr static TextAnalyticsPagedResponse getExpectedBatchTextSentiment() { final TextDocumentStatistics textDocumentStatistics = new TextDocumentStatistics(67, 1); - final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.MIXED, + final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.MIXED.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.NEGATIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.POSITIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.NEGATIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.POSITIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); - final DocumentSentiment expectedDocumentSentiment2 = new DocumentSentiment(TextSentiment.MIXED, + final DocumentSentiment expectedDocumentSentiment2 = new DocumentSentiment(TextSentiment.MIXED.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.POSITIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.NEGATIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.POSITIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.NEGATIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); final AnalyzeSentimentResult analyzeSentimentResult1 = new AnalyzeSentimentResult("0", diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClientTest.java b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClientTest.java index a11972b8712a..fd144a94de57 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClientTest.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClientTest.java @@ -558,11 +558,11 @@ public void extractKeyPhrasesBatchWarning(HttpClient httpClient, TextAnalyticsSe @MethodSource("com.azure.ai.textanalytics.TestUtils#getTestParameters") public void analyseSentimentForTextInput(HttpClient httpClient, TextAnalyticsServiceVersion serviceVersion) { client = getTextAnalyticsAsyncClient(httpClient, serviceVersion); - final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.MIXED, + final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.MIXED.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.NEGATIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.POSITIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.NEGATIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.POSITIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); StepVerifier @@ -590,11 +590,11 @@ public void analyseSentimentForEmptyText(HttpClient httpClient, TextAnalyticsSer public void analyseSentimentForFaultyText(HttpClient httpClient, TextAnalyticsServiceVersion serviceVersion) { client = getTextAnalyticsAsyncClient(httpClient, serviceVersion); final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment( - TextSentiment.NEUTRAL, + TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.NEUTRAL, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.NEUTRAL, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); StepVerifier.create(client.analyzeSentiment("!@#%%")) diff --git a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java index 918b5f59595f..08146c07cbf0 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java +++ b/sdk/textanalytics/azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java @@ -317,7 +317,7 @@ public void recognizeLinkedEntitiesForTextInput(HttpClient httpClient, TextAnaly @MethodSource("com.azure.ai.textanalytics.TestUtils#getTestParameters") public void recognizeLinkedEntitiesForEmptyText(HttpClient httpClient, TextAnalyticsServiceVersion serviceVersion) { client = getTextAnalyticsClient(httpClient, serviceVersion); - Exception exception = assertThrows(TextAnalyticsException.class, () -> client.recognizeLinkedEntities("").iterator().hasNext()); + TextAnalyticsException exception = assertThrows(TextAnalyticsException.class, () -> client.recognizeLinkedEntities("").iterator().hasNext()); assertTrue(exception.getMessage().equals(INVALID_DOCUMENT_EXPECTED_EXCEPTION_MESSAGE)); } @@ -510,11 +510,11 @@ public void extractKeyPhrasesBatchWarning(HttpClient httpClient, TextAnalyticsSe public void analyseSentimentForTextInput(HttpClient httpClient, TextAnalyticsServiceVersion serviceVersion) { client = getTextAnalyticsClient(httpClient, serviceVersion); final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment( - TextSentiment.MIXED, + TextSentiment.MIXED.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.NEGATIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.POSITIVE, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.NEGATIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.POSITIVE.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); DocumentSentiment analyzeSentimentResult = client.analyzeSentiment("The hotel was dark and unclean. The restaurant had amazing gnocchi."); @@ -540,11 +540,11 @@ public void analyseSentimentForEmptyText(HttpClient httpClient, TextAnalyticsSer @MethodSource("com.azure.ai.textanalytics.TestUtils#getTestParameters") public void analyseSentimentForFaultyText(HttpClient httpClient, TextAnalyticsServiceVersion serviceVersion) { client = getTextAnalyticsClient(httpClient, serviceVersion); - final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.NEUTRAL, + final DocumentSentiment expectedDocumentSentiment = new DocumentSentiment(TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0), new IterableStream<>(Arrays.asList( - new SentenceSentiment("", TextSentiment.NEUTRAL, new SentimentConfidenceScores(0.0, 0.0, 0.0)), - new SentenceSentiment("", TextSentiment.NEUTRAL, new SentimentConfidenceScores(0.0, 0.0, 0.0)) + new SentenceSentiment("", TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)), + new SentenceSentiment("", TextSentiment.NEUTRAL.toString(), new SentimentConfidenceScores(0.0, 0.0, 0.0)) )), null); DocumentSentiment analyzeSentimentResult = client.analyzeSentiment("!@#%%");