Skip to content

Commit 5f4270f

Browse files
Sync eng/common directory with azure-sdk-tools for PR 8463 (#40683)
* Fix case where changelog wasn't marked as invalid * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
1 parent c9ee06b commit 5f4270f

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

eng/common/scripts/ChangeLog-Operations.ps1

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ function Remove-EmptySections {
297297
{
298298
$parsedSections = $ChangeLogEntry.Sections
299299
$sanitizedReleaseContent = New-Object System.Collections.ArrayList(,$releaseContent)
300-
301-
foreach ($key in @($parsedSections.Keys))
300+
301+
foreach ($key in @($parsedSections.Keys))
302302
{
303303
if ([System.String]::IsNullOrWhiteSpace($parsedSections[$key]))
304304
{
@@ -442,9 +442,10 @@ function Confirm-ChangeLogForRelease {
442442
if (!$foundRecommendedSection)
443443
{
444444
$ChangeLogStatus.Message = "The changelog entry did not contain any of the recommended sections ($($RecommendedSectionHeaders -join ', ')), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info."
445+
$ChangeLogStatus.IsValid = $false
445446
if (!$SuppressErrors) {
446447
LogError "$($ChangeLogStatus.Message)"
447448
}
448449
}
449450
return $ChangeLogStatus.IsValid
450-
}
451+
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# Release History
22

33
## 1.0.0-beta.1 (2022-04-19)
4+
5+
### Features Added
46
- Test batch release
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# Release History
22

33
## 1.0.0-beta.1 (2022-04-19)
4-
- Test batch release
4+
5+
### Features Added
6+
- Test batch release

sdk/template/azure-sdk-template/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Release History
22

33
## 1.2.2-beta.1 (Unreleased)
4+
5+
### Features Added
46
- Test batch release
57

68
## 1.2.1-beta.2 (2020-09-04)

0 commit comments

Comments
 (0)