Skip to content

Conversation

@gunjansingh-msft
Copy link
Member

Fixed a Panic in the test :- TestUploadBlobWithMD5WithCPK() which was caused due to a functional issue in the compareHeaders custom sorting algorithm.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Oct 4, 2024
@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution @gunjansingh-msft! We will review the pull request and get back to you soon.

@tanyasethi-msft
Copy link
Member

@gunjansingh-msft - The tests of all 3 modules - azblob, azfile, and azdatalake seems to be failing because of -

  1. Recording not found. We may need to re-record the tests (by re-running them in record mode) and uploading the recordings to this repo - https://github.com/Azure/azure-sdk-assets.
  2. Linter error in the pipeline - Minor Linter issues needs fixes in test files (can be seen in azblob-ci pipeline failure)

@souravgupta-msft
Copy link
Member

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gunjansingh-msft
Copy link
Member Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gunjansingh-msft
Copy link
Member Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gunjansingh-msft
Copy link
Member Author

/azp run go - azfile

@gunjansingh-msft
Copy link
Member Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gunjansingh-msft
Copy link
Member Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

@microsoft-github-policy-service agree

@gunjansingh-msft
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

@gunjansingh-msft gunjansingh-msft merged commit 40dcd1b into Azure:main Oct 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AzBlob AzDatalake AzFile Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants