From 0dfe4f6444a272842f2d06dff89709fb860f6590 Mon Sep 17 00:00:00 2001 From: "Scott Beddall (from Dev Box)" Date: Wed, 19 Jun 2024 14:55:19 -0700 Subject: [PATCH 1/4] update the target version of the proxy --- eng/common/testproxy/target_version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/testproxy/target_version.txt b/eng/common/testproxy/target_version.txt index 30229be64fe4..1466900c73ee 100644 --- a/eng/common/testproxy/target_version.txt +++ b/eng/common/testproxy/target_version.txt @@ -1 +1 @@ -1.0.0-dev.20240604.2 +1.0.0-dev.20240619.2 From a277f2015b7933f99be426b104c68eaa85acace9 Mon Sep 17 00:00:00 2001 From: "Scott Beddall (from Dev Box)" Date: Thu, 20 Jun 2024 11:50:12 -0700 Subject: [PATCH 2/4] unskip the tests so they fail properly --- sdk/containers/azcontainerregistry/client_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sdk/containers/azcontainerregistry/client_test.go b/sdk/containers/azcontainerregistry/client_test.go index 682552a66231..b8b0e6797b12 100644 --- a/sdk/containers/azcontainerregistry/client_test.go +++ b/sdk/containers/azcontainerregistry/client_test.go @@ -131,9 +131,6 @@ func TestClient_DeleteTag_error(t *testing.T) { } func TestClient_GetManifest(t *testing.T) { - if recording.GetRecordMode() == recording.PlaybackMode { - t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919") - } startRecording(t) endpoint, cred, options := getEndpointCredAndClientOptions(t) ctx := context.Background() @@ -616,9 +613,6 @@ func TestClient_UpdateTagProperties_wrongTag(t *testing.T) { } func TestClient_UploadManifest(t *testing.T) { - if recording.GetRecordMode() == recording.PlaybackMode { - t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919") - } startRecording(t) endpoint, cred, options := getEndpointCredAndClientOptions(t) ctx := context.Background() From aaeee3b8a0520abc969d48894808c21ccc8988bb Mon Sep 17 00:00:00 2001 From: "Scott Beddall (from Dev Box)" Date: Thu, 20 Jun 2024 12:33:20 -0700 Subject: [PATCH 3/4] fix the skips --- sdk/containers/azcontainerregistry/client_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/containers/azcontainerregistry/client_test.go b/sdk/containers/azcontainerregistry/client_test.go index b8b0e6797b12..9c49236659e9 100644 --- a/sdk/containers/azcontainerregistry/client_test.go +++ b/sdk/containers/azcontainerregistry/client_test.go @@ -20,7 +20,6 @@ import ( "github.com/Azure/azure-sdk-for-go/sdk/azcore/streaming" "github.com/Azure/azure-sdk-for-go/sdk/azcore/to" "github.com/Azure/azure-sdk-for-go/sdk/internal/mock" - "github.com/Azure/azure-sdk-for-go/sdk/internal/recording" "github.com/stretchr/testify/require" ) From 6bdfbd397a0a22cd30e4caf0de0b92efb8c08436 Mon Sep 17 00:00:00 2001 From: "Scott Beddall (from Dev Box)" Date: Thu, 20 Jun 2024 12:36:57 -0700 Subject: [PATCH 4/4] update the assets.json --- sdk/containers/azcontainerregistry/assets.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/containers/azcontainerregistry/assets.json b/sdk/containers/azcontainerregistry/assets.json index 7677bc61aa77..b7e540810034 100644 --- a/sdk/containers/azcontainerregistry/assets.json +++ b/sdk/containers/azcontainerregistry/assets.json @@ -2,5 +2,5 @@ "AssetsRepo": "Azure/azure-sdk-assets", "AssetsRepoPrefixPath": "go", "TagPrefix": "go/containers/azcontainerregistry", - "Tag": "go/containers/azcontainerregistry_b6bdd049bc" + "Tag": "go/containers/azcontainerregistry_734baeebc4" }