Skip to content

Disable code coverage redesign in CI #22402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Disable code coverage redesign in CI #22402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2cb707
Disable code coverage redesign in CI
jhendrixMSFT Feb 16, 2024
dff6dd6
conditionally set env var
jhendrixMSFT Feb 16, 2024
59ee8b6
tweak
jhendrixMSFT Feb 16, 2024
fc212bf
move to build matrix
jhendrixMSFT Feb 16, 2024
6feb197
update test regex
jhendrixMSFT Feb 16, 2024
5fd2523
Add GOEXPERIMENT to live test matrix
benbp Feb 16, 2024
cd08c48
Swap matrix order for display name consistency
benbp Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/pipelines/templates/jobs/archetype-sdk-client-samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ stages:
pool.name: azsdk-pool-mms-ubuntu-2004-general
image.name: MMSUbuntu20.04
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
Windows_Go122:
pool.name: azsdk-pool-mms-win-2022-general
image.name: MMS2022
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
pool:
name: $(pool.name)
vmImage: $(image.name)
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,12 @@ stages:
pool.name: azsdk-pool-mms-ubuntu-2004-general
image.name: MMSUbuntu20.04
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
Windows_Go122:
pool.name: azsdk-pool-mms-win-2022-general
image.name: MMS2022
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
generate.bom: true
pool:
name: $(pool.name)
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/jobs/archetype-sdk-eng-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ stages:
pool.name: azsdk-pool-mms-ubuntu-2004-general
image.name: MMSUbuntu20.04
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
Windows_Go122:
pool.name: azsdk-pool-mms-win-2022-general
image.name: MMS2022
go.version: '1.22.0'
GOEXPERIMENT: nocoverageredesign
generate.bom: true
pool:
name: $(pool.name)
Expand Down
23 changes: 20 additions & 3 deletions eng/pipelines/templates/stages/platform-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,25 @@
},
"GoVersion": [
"1.18.10",
"1.21.7",
"1.22.0"
"1.21.7"
]
}
},
"include": [
{
"Agent": {
"ubuntu-20.04": {
"OSVmImage": "MMSUbuntu20.04",
"Pool": "azsdk-pool-mms-ubuntu-2004-general"
},
"windows-2022": {
"OSVmImage": "MMS2022",
"Pool": "azsdk-pool-mms-win-2022-general"
}
},
"GoVersion": [
"1.22.0"
],
"GOEXPERIMENT": "nocoverageredesign"
}
]
}
5 changes: 4 additions & 1 deletion sdk/internal/telemetry/telemetry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@ func TestFormat(t *testing.T) {
// * azsdk-go-azservicebus/v1.0.0 (go1.19.3; linux)
// * azsdk-go-azservicebus/v1.0.0 (go1.19; Windows_NT)
// * azsdk-go-azservicebus/v1.0.0 (go1.21rc3; linux)
// * azsdk-go-azservicebus/v1.0.0 (go1.22.0 X:nocoverageredesign; linux)
//
// The OS varies based on the actual platform but it's a small set.
re := `^azsdk-go-azservicebus/v1.0.0` +
` ` +
`\(` +
`go\d+\.\d+(|\.\d+|rc\d+); (Windows_NT|linux|freebsd)` +
`go\d+\.\d+(?:|\.\d+|rc\d+)(?:\s[a-zA-Z0-9|:]+)?; (?:Windows_NT|linux|freebsd)` +
`\)$`

require.Regexp(t, re, userAgent)
require.Regexp(t, re, "azsdk-go-azservicebus/v1.0.0 (go1.21rc3; linux)")
require.Regexp(t, re, "azsdk-go-azservicebus/v1.0.0 (go1.22.0 X:nocoverageredesign; linux)")
}