Skip to content

[azeventhubs] Fixing an issue where a processor wouldn't grab partitions #22153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2024
Merged

[azeventhubs] Fixing an issue where a processor wouldn't grab partitions #22153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae50c4c
The processor load balancer had a bug where a processor starting up m…
Jan 5, 2024
3e325ae
Fixing broken load balancer test - our rules are different now that w…
Jan 8, 2024
a0bc544
goimports -w
Jan 8, 2024
b1583f2
prepare release changelog update
Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/messaging/azeventhubs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Processor distributes partitions optimally, which would result in idle or over-assigned processors. (PR#22153)

### Other Changes

## 1.0.2 (2023-11-07)
Expand Down
5 changes: 5 additions & 0 deletions sdk/messaging/azeventhubs/inmemory_checkpoint_store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package azeventhubs

import (
"context"
"sort"
"strings"
"sync"
"testing"
Expand Down Expand Up @@ -277,6 +278,10 @@ func (cps *testCheckpointStore) ListOwnership(ctx context.Context, fullyQualifie
ownerships = append(ownerships, v)
}

sort.Slice(ownerships, func(i, j int) bool {
return ownerships[i].PartitionID < ownerships[j].PartitionID
})

return ownerships, nil
}

Expand Down
4 changes: 4 additions & 0 deletions sdk/messaging/azeventhubs/internal/eh/stress/scenarios-matrix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,7 @@ matrix:
prefetch: 0
verbose: ""
sleepAfter: "5m"
multibalance:
testTarget: multibalance
rounds: 20
verbose: ""
24 changes: 18 additions & 6 deletions sdk/messaging/azeventhubs/internal/eh/stress/stress-test-resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,25 @@
"apiVersion": "[variables('apiVersion')]",
"name": "[variables('authorizationName')]",
"location": "[variables('location')]",
"dependsOn": ["[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"],
"dependsOn": [
"[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"
],
"properties": {
"rights": ["Listen", "Manage", "Send"]
"rights": [
"Listen",
"Manage",
"Send"
]
}
},
{
"type": "Microsoft.EventHub/namespaces/eventhubs",
"apiVersion": "[variables('apiVersion')]",
"name": "[variables('eventHubNameFull')]",
"location": "[variables('location')]",
"dependsOn": ["[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"],
"dependsOn": [
"[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"
],
"properties": {
"messageRetentionInDays": 7,
"partitionCount": 32
Expand All @@ -73,7 +81,9 @@
"apiVersion": "[variables('apiVersion')]",
"name": "[concat(variables('namespaceName'), '/default')]",
"location": "[variables('location')]",
"dependsOn": ["[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"],
"dependsOn": [
"[resourceId('Microsoft.EventHub/namespaces', variables('namespaceName'))]"
],
"properties": {
"defaultAction": "Deny",
"virtualNetworkRules": [],
Expand Down Expand Up @@ -127,13 +137,15 @@
"name": "[concat('default/', variables('containerName'))]",
"type": "blobServices/containers",
"apiVersion": "[variables('storageApiVersion')]",
"dependsOn": ["[variables('storageAccountName')]"]
"dependsOn": [
"[variables('storageAccountName')]"
]
}
]
},
],
"outputs": {
"EVENTHUB_NAME": {
"EVENTHUB_NAME_STRESS": {
"type": "string",
"value": "[variables('eventHubName')]"
},
Expand Down
2 changes: 2 additions & 0 deletions sdk/messaging/azeventhubs/internal/eh/stress/stress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ func main() {
fn func(ctx context.Context) error
}{
{name: "batch", fn: tests.BatchStressTester},
{name: "balance", fn: tests.BalanceTester},
{name: "multibalance", fn: tests.MultiBalanceTester},
{name: "processor", fn: tests.ProcessorStressTester},
}

Expand Down
4 changes: 4 additions & 0 deletions sdk/messaging/azeventhubs/internal/eh/stress/templates/stress-test-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ spec:
- >
set -ex;
mkdir -p "$DEBUG_SHARE";
{{if eq .Stress.testTarget "multibalance" }}
/app/stress "{{.Stress.testTarget}}" "-rounds" "{{.Stress.rounds}}" "{{.Stress.verbose}}" 2>&1 | tee -a "${DEBUG_SHARE}/{{ .Stress.Scenario }}-`date +%s`.log";
{{else}}
/app/stress "{{.Stress.testTarget}}" "-rounds" "{{.Stress.rounds}}" "-prefetch" "{{.Stress.prefetch}}" "{{.Stress.verbose}}" "-sleepAfter" "{{.Stress.sleepAfter}}" 2>&1 | tee -a "${DEBUG_SHARE}/{{ .Stress.Scenario }}-`date +%s`.log";
{{end}}
# Pulls the image on pod start, always. We tend to push to the same image and tag over and over again
# when iterating, so this is a must.
imagePullPolicy: Always
Expand Down
Loading