diff --git a/sdk/security/keyvault/azsecrets/CHANGELOG.md b/sdk/security/keyvault/azsecrets/CHANGELOG.md index 5b29594596b0..44e740a94980 100644 --- a/sdk/security/keyvault/azsecrets/CHANGELOG.md +++ b/sdk/security/keyvault/azsecrets/CHANGELOG.md @@ -1,6 +1,6 @@ # Release History -## 1.0.0 (Unreleased) +## 0.14.0 (2023-06-06) ### Breaking Changes * Renamed `Client.ListSecrets` to `Client.ListSecretProperties` @@ -11,6 +11,7 @@ * Renamed `DeletedSecretItem` to `DeletedSecretProperties` * Renamed `Kid` to `KID` * Removed `DeletionRecoveryLevel` type +* Remove `MaxResults` option ### Other Changes * Updated dependencies diff --git a/sdk/security/keyvault/azsecrets/assets.json b/sdk/security/keyvault/azsecrets/assets.json index f9ff30851e3f..cc65dde0e60f 100644 --- a/sdk/security/keyvault/azsecrets/assets.json +++ b/sdk/security/keyvault/azsecrets/assets.json @@ -2,5 +2,5 @@ "AssetsRepo": "Azure/azure-sdk-assets", "AssetsRepoPrefixPath": "go", "TagPrefix": "go/security/keyvault/azsecrets", - "Tag": "go/security/keyvault/azsecrets_857c006979" + "Tag": "go/security/keyvault/azsecrets_c3ed1e9c8d" } diff --git a/sdk/security/keyvault/azsecrets/autorest.md b/sdk/security/keyvault/azsecrets/autorest.md index f96a92915468..3226bac85eb5 100644 --- a/sdk/security/keyvault/azsecrets/autorest.md +++ b/sdk/security/keyvault/azsecrets/autorest.md @@ -84,6 +84,12 @@ directive: where: $ transform: return $.replace(/DeletionRecoveryLevel/g, "string"); + # Remove MaxResults parameter + - where: "$.paths..*" + remove-parameter: + in: query + name: maxresults + # delete unused error models - from: models.go where: $ diff --git a/sdk/security/keyvault/azsecrets/client.go b/sdk/security/keyvault/azsecrets/client.go index 51e004fa2ebf..aed123d116d4 100644 --- a/sdk/security/keyvault/azsecrets/client.go +++ b/sdk/security/keyvault/azsecrets/client.go @@ -17,7 +17,6 @@ import ( "github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime" "net/http" "net/url" - "strconv" "strings" ) @@ -269,9 +268,6 @@ func (client *Client) listDeletedSecretPropertiesCreateRequest(ctx context.Conte return nil, err } reqQP := req.Raw().URL.Query() - if options != nil && options.MaxResults != nil { - reqQP.Set("maxresults", strconv.FormatInt(int64(*options.MaxResults), 10)) - } reqQP.Set("api-version", "7.4") req.Raw().URL.RawQuery = reqQP.Encode() req.Raw().Header["Accept"] = []string{"application/json"} @@ -330,9 +326,6 @@ func (client *Client) listSecretPropertiesCreateRequest(ctx context.Context, opt return nil, err } reqQP := req.Raw().URL.Query() - if options != nil && options.MaxResults != nil { - reqQP.Set("maxresults", strconv.FormatInt(int64(*options.MaxResults), 10)) - } reqQP.Set("api-version", "7.4") req.Raw().URL.RawQuery = reqQP.Encode() req.Raw().Header["Accept"] = []string{"application/json"} @@ -395,9 +388,6 @@ func (client *Client) listSecretPropertiesVersionsCreateRequest(ctx context.Cont return nil, err } reqQP := req.Raw().URL.Query() - if options != nil && options.MaxResults != nil { - reqQP.Set("maxresults", strconv.FormatInt(int64(*options.MaxResults), 10)) - } reqQP.Set("api-version", "7.4") req.Raw().URL.RawQuery = reqQP.Encode() req.Raw().Header["Accept"] = []string{"application/json"} diff --git a/sdk/security/keyvault/azsecrets/client_test.go b/sdk/security/keyvault/azsecrets/client_test.go index a7b437854db6..e2016d5b1055 100644 --- a/sdk/security/keyvault/azsecrets/client_test.go +++ b/sdk/security/keyvault/azsecrets/client_test.go @@ -237,7 +237,7 @@ func TestListDeletedSecrets(t *testing.T) { }) expected := map[string]struct{}{secret1: {}, secret2: {}} - pager := client.NewListDeletedSecretPropertiesPager(&azsecrets.ListDeletedSecretPropertiesOptions{MaxResults: to.Ptr(int32(1))}) + pager := client.NewListDeletedSecretPropertiesPager(nil) for pager.More() && len(expected) > 0 { page, err := pager.NextPage(context.Background()) require.NoError(t, err) @@ -265,7 +265,7 @@ func TestListSecrets(t *testing.T) { defer cleanUpSecret(t, client, name) } - pager := client.NewListSecretPropertiesPager(&azsecrets.ListSecretPropertiesOptions{MaxResults: to.Ptr(int32(1))}) + pager := client.NewListSecretPropertiesPager(nil) for pager.More() { page, err := pager.NextPage(context.Background()) require.NoError(t, err) @@ -302,7 +302,7 @@ func TestListSecretVersions(t *testing.T) { } defer cleanUpSecret(t, client, name) - pager := client.NewListSecretPropertiesVersionsPager(name, &azsecrets.ListSecretPropertiesVersionsOptions{MaxResults: to.Ptr(int32(1))}) + pager := client.NewListSecretPropertiesVersionsPager(name, nil) for pager.More() { page, err := pager.NextPage(context.Background()) require.NoError(t, err) diff --git a/sdk/security/keyvault/azsecrets/models.go b/sdk/security/keyvault/azsecrets/models.go index d2d6c76a62b8..232c44f56118 100644 --- a/sdk/security/keyvault/azsecrets/models.go +++ b/sdk/security/keyvault/azsecrets/models.go @@ -40,21 +40,18 @@ type GetSecretOptions struct { // ListDeletedSecretPropertiesOptions contains the optional parameters for the Client.NewListDeletedSecretPropertiesPager // method. type ListDeletedSecretPropertiesOptions struct { - // Maximum number of results to return in a page. If not specified the service will return up to 25 results. - MaxResults *int32 + // placeholder for future optional parameters } // ListSecretPropertiesOptions contains the optional parameters for the Client.NewListSecretPropertiesPager method. type ListSecretPropertiesOptions struct { - // Maximum number of results to return in a page. If not specified, the service will return up to 25 results. - MaxResults *int32 + // placeholder for future optional parameters } // ListSecretPropertiesVersionsOptions contains the optional parameters for the Client.NewListSecretPropertiesVersionsPager // method. type ListSecretPropertiesVersionsOptions struct { - // Maximum number of results to return in a page. If not specified, the service will return up to 25 results. - MaxResults *int32 + // placeholder for future optional parameters } // PurgeDeletedSecretOptions contains the optional parameters for the Client.PurgeDeletedSecret method. diff --git a/sdk/security/keyvault/azsecrets/version.go b/sdk/security/keyvault/azsecrets/version.go index 936e7274d409..48ae62418bae 100644 --- a/sdk/security/keyvault/azsecrets/version.go +++ b/sdk/security/keyvault/azsecrets/version.go @@ -8,5 +8,5 @@ package azsecrets const ( moduleName = "azsecrets" - version = "v1.0.0" + version = "v0.14.0" )