From 06ee47780056d8c7f9e442d8e58ab107d89c6774 Mon Sep 17 00:00:00 2001 From: Richard Park Date: Fri, 7 Jan 2022 13:29:28 -0800 Subject: [PATCH 1/5] Updating sb to handle breaking changes in azcore --- .../azservicebus/admin/admin_client_test.go | 4 +-- .../azservicebus/admin/admin_client_topic.go | 2 +- sdk/messaging/azservicebus/go.mod | 8 ++++-- sdk/messaging/azservicebus/go.sum | 25 +++++++++++++------ .../internal/atom/entity_manager.go | 10 ++++---- .../internal/atom/manager_common_test.go | 2 +- 6 files changed, 32 insertions(+), 19 deletions(-) diff --git a/sdk/messaging/azservicebus/admin/admin_client_test.go b/sdk/messaging/azservicebus/admin/admin_client_test.go index c063a2d46cd2..98450235ab48 100644 --- a/sdk/messaging/azservicebus/admin/admin_client_test.go +++ b/sdk/messaging/azservicebus/admin/admin_client_test.go @@ -801,9 +801,9 @@ func TestAdminClient_LackPermissions_Topic(t *testing.T) { require.Contains(t, err.Error(), "error code: 401, Details: Authorization failed for specified action: Manage,EntityDelete.") // sanity check that the http response is getting bundled into these errors, should it be needed. - var httpResponse azcore.HTTPResponse + var httpResponse *azcore.ResponseError require.True(t, errors.As(err, &httpResponse)) - require.EqualValues(t, http.StatusUnauthorized, httpResponse.RawResponse().StatusCode) + require.EqualValues(t, http.StatusUnauthorized, httpResponse.RawResponse.StatusCode) } func TestAdminClient_LackPermissions_Subscription(t *testing.T) { diff --git a/sdk/messaging/azservicebus/admin/admin_client_topic.go b/sdk/messaging/azservicebus/admin/admin_client_topic.go index 137e5a09924d..ae11bb9358be 100644 --- a/sdk/messaging/azservicebus/admin/admin_client_topic.go +++ b/sdk/messaging/azservicebus/admin/admin_client_topic.go @@ -131,7 +131,7 @@ func (ac *Client) GetTopic(ctx context.Context, topicName string, options *GetTo props, err := newTopicProperties(&atomResp.Content.TopicDescription) if err != nil { - return nil, atom.NewResponseError(err, resp) + return nil, err } return &GetTopicResponse{ diff --git a/sdk/messaging/azservicebus/go.mod b/sdk/messaging/azservicebus/go.mod index 628052efccb6..6ffc908f5f7f 100644 --- a/sdk/messaging/azservicebus/go.mod +++ b/sdk/messaging/azservicebus/go.mod @@ -3,8 +3,8 @@ module github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus go 1.16 require ( - github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.0 - github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.0 + // github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.0 + // github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.0 github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.2 github.com/Azure/azure-sdk-for-go/sdk/messaging/internal v0.0.0-20211208010914-2b10e91d237e github.com/Azure/go-amqp v0.17.0 @@ -19,3 +19,7 @@ require ( golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect nhooyr.io/websocket v1.8.6 ) + +require github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.1-0.20211217200426-f2d5927fe220 + +require github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.1-0.20211217202854-9673a656af22 diff --git a/sdk/messaging/azservicebus/go.sum b/sdk/messaging/azservicebus/go.sum index 1352278398fb..900631118043 100644 --- a/sdk/messaging/azservicebus/go.sum +++ b/sdk/messaging/azservicebus/go.sum @@ -1,17 +1,15 @@ code.cloudfoundry.org/clock v0.0.0-20180518195852-02e53af36e6c h1:5eeuG0BHx1+DHeT3AP+ISKZ2ht1UjGhm581ljqYpVeQ= code.cloudfoundry.org/clock v0.0.0-20180518195852-02e53af36e6c/go.mod h1:QD9Lzhd/ux6eNQVUDVRJX/RKTigpewimNYBi7ivZKY8= -github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.0 h1:KQgdWmEOmaJKxaUUZwHAYh12t+b+ZJf8q3friycK1kA= github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.0/go.mod h1:ZPW/Z0kLCTdDZaDbYTetxc9Cxl/2lNqxYHYNOF2bti0= -github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.0 h1:VBvHGLJbaY0+c66NZHdS9cgjHVYSH6DDa0XJMyrblsI= -github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.0/go.mod h1:GJzjM4SR9T0KyX5gKCVyz1ytD8FeWeUPCwtFCt1AyfE= +github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.1-0.20211217200426-f2d5927fe220 h1:IJmlas1doMoLMhG5LbKdyhLI8dkjTNY5AD8VfFKGuRE= +github.com/Azure/azure-sdk-for-go/sdk/azcore v0.20.1-0.20211217200426-f2d5927fe220/go.mod h1:ZPW/Z0kLCTdDZaDbYTetxc9Cxl/2lNqxYHYNOF2bti0= +github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.1-0.20211217202854-9673a656af22 h1:6Lz1iIvWRwfsx4NiKF4KfIMlmJ+BlPTBy6JsTXKiK8w= +github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.12.1-0.20211217202854-9673a656af22/go.mod h1:tfA+sP6iTxAiHcYPghAg0dNQ5qGwUc3aYal9XWVPJw4= github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.1/go.mod h1:KLF4gFr6DcKFZwSuH8w8yEK6DpFl3LP5rhdvAb7Yz5I= github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.2 h1:rImM7Yjz9yUgpdxp3A4cZLm1JZuo4XbtIp2LrUZnwYw= github.com/Azure/azure-sdk-for-go/sdk/internal v0.8.2/go.mod h1:KLF4gFr6DcKFZwSuH8w8yEK6DpFl3LP5rhdvAb7Yz5I= github.com/Azure/azure-sdk-for-go/sdk/messaging/internal v0.0.0-20211208010914-2b10e91d237e h1:9n9b/dngBY5hfevx1jmEMbGvZGCcx1zAUaeYF8dk9Co= github.com/Azure/azure-sdk-for-go/sdk/messaging/internal v0.0.0-20211208010914-2b10e91d237e/go.mod h1:7hMUlcqiMXDUJtU1EWQlhhkC4BfIr6pEsiyuRYq4xLQ= -github.com/Azure/go-amqp v0.16.0/go.mod h1:9YJ3RhxRT1gquYnzpZO1vcYMMpAdJT+QEg6fwmw9Zlg= -github.com/Azure/go-amqp v0.16.5-0.20211207190606-01b4c6402182 h1:E1rCzk/cEGhcedyB0l3ImnNNRCztZq51ataskdhCno8= -github.com/Azure/go-amqp v0.16.5-0.20211207190606-01b4c6402182/go.mod h1:9YJ3RhxRT1gquYnzpZO1vcYMMpAdJT+QEg6fwmw9Zlg= github.com/Azure/go-amqp v0.17.0 h1:HHXa3149nKrI0IZwyM7DRcRy5810t9ZICDutn4BYzj4= github.com/Azure/go-amqp v0.17.0/go.mod h1:9YJ3RhxRT1gquYnzpZO1vcYMMpAdJT+QEg6fwmw9Zlg= github.com/Azure/go-autorest v14.2.0+incompatible/go.mod h1:r+4oMnoxhatjLLJ6zxSWATqVooLgysK6ZNox3g/xq24= @@ -22,11 +20,14 @@ github.com/Azure/go-autorest/autorest/date v0.3.0/go.mod h1:BI0uouVdmngYNUzGWeSY github.com/Azure/go-autorest/autorest/mocks v0.4.1/go.mod h1:LTp+uSrOhSkaKrUy935gNZuuIPPVsHlr9DSOxSayd+k= github.com/Azure/go-autorest/logger v0.2.1/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZmbF5NWuPV8+WeEW8= github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU= +github.com/AzureAD/microsoft-authentication-library-for-go v0.4.0 h1:WVsrXCnHlDDX8ls+tootqRE87/hL9S/g4ewig9RsD/c= +github.com/AzureAD/microsoft-authentication-library-for-go v0.4.0/go.mod h1:Vt9sXTKwMyGcOxSmLDMnGPgqsUg7m8pe215qMLrDXw4= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/devigned/tab v0.1.1 h1:3mD6Kb1mUOYeLpJvTVSDwSg5ZsfSxfvxGRTxRsJsITA= github.com/devigned/tab v0.1.1/go.mod h1:XG9mPq0dFghrYvoBF3xdRrJzSTX1b7IQrvaL9mzjeJY= +github.com/dnaeon/go-vcr v1.1.0 h1:ReYa/UBrRyQdant9B4fNHGoCNKw6qh6P0fsdGmZpR7c= github.com/dnaeon/go-vcr v1.1.0/go.mod h1:M7tiix8f0r6mKKJ3Yq/kqU1OYf3MnfmBWVbPx/yU9ko= github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k= github.com/fortytw2/leaktest v1.3.0 h1:u8491cBMTQ8ft8aeV+adlcytMZylmA5nnwwkRZjI8vw= @@ -51,6 +52,8 @@ github.com/gobwas/ws v1.0.2 h1:CoAavW/wd/kulfZmSIBt6p24n4j7tHgNVCjsfHVNUbo= github.com/gobwas/ws v1.0.2/go.mod h1:szmBTxLgaFppYjEmNtny/v3w89xOydFnnZMcgRRu/EM= github.com/gofrs/uuid v3.3.0+incompatible h1:8K4tyRfvU1CYPgJsveYFQMhpFd/wXNM7iK6rR7UHz84= github.com/gofrs/uuid v3.3.0+incompatible/go.mod h1:b2aQJv3Z4Fp6yNu3cdSllBxTCLRxnplIgP/c0N/04lM= +github.com/golang-jwt/jwt v3.2.1+incompatible h1:73Z+4BJcrTC+KczS6WvTPvRGOp1WmfEP4Q1lOd9Z/+c= +github.com/golang-jwt/jwt v3.2.1+incompatible/go.mod h1:8pz2t5EyA70fFQQSrl6XZXzqecmYZeUEB8OUGHkxJ+I= github.com/golang-jwt/jwt/v4 v4.0.0/go.mod h1:/xlHOz8bRuivTWchD4jCa+NbatV+wEUSzwAxVc6locg= github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= github.com/golang/protobuf v1.3.3/go.mod h1:vzj43D7+SQXF/4pzW/hwtAqwc6iTitCiVSaWz5lYuqw= @@ -60,6 +63,8 @@ github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/ github.com/google/go-cmp v0.5.1 h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k= github.com/google/go-cmp v0.5.1/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= +github.com/google/uuid v1.1.1 h1:Gkbcsh/GbpXz7lPftLA3P6TYMwjCLYm83jiFQZF/3gY= +github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/gorilla/websocket v1.4.1 h1:q7AeDBpnBk8AogcD4DSag/Ukw/KV+YhzLj2bP5HvKCM= github.com/gorilla/websocket v1.4.1/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE= github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU= @@ -76,6 +81,8 @@ github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORN github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE= github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= +github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc= +github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw= github.com/leodido/go-urn v1.2.0 h1:hpXL4XnriNwQ/ABnpepYM/1vCLWNDfUNts8dX3xTG6Y= github.com/leodido/go-urn v1.2.0/go.mod h1:+8+nEpDfqqsY+g338gtMEUOtuK+4dEMhiQEgxpxOKII= github.com/mattn/go-isatty v0.0.12 h1:wuysRhFDzyxgEmMf5xjvJ2M9dZoWAXNNr5LSBS7uHXY= @@ -87,11 +94,12 @@ github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742 h1:Esafd1046DLDQ0W1YjYsBW+p8U2u7vzgW2SQVmlNazg= github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/modocache/gover v0.0.0-20171022184752-b58185e213c5/go.mod h1:caMODM3PzxT8aQXRPkAt8xlV/e7d7w8GM5g0fa5F0D8= +github.com/montanaflynn/stats v0.6.6/go.mod h1:etXPPgVO6n31NxCd9KQUMvCM+ve0ruNzt6R8Bnaayow= github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= github.com/onsi/ginkgo v1.8.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= github.com/onsi/gomega v1.5.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= -github.com/pkg/browser v0.0.0-20180916011732-0a3d74bf9ce4 h1:49lOXmGaUpV9Fz3gd7TFZY106KVlPVa5jcYD1gaQf98= -github.com/pkg/browser v0.0.0-20180916011732-0a3d74bf9ce4/go.mod h1:4OwLy04Bl9Ef3GJJCoec+30X3LQs/0/m4HFRt/2LUSA= +github.com/pkg/browser v0.0.0-20210115035449-ce105d075bb4 h1:Qj1ukM4GlMWXNdMBuXcXfz/Kw9s1qm0CLY32QxuSImI= +github.com/pkg/browser v0.0.0-20210115035449-ce105d075bb4/go.mod h1:N6UoU20jOqggOuDwUaBQpluzLNDqif3kq9z2wpdYEfQ= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= @@ -124,6 +132,7 @@ golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7w golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20211001092434-39dca1131b70 h1:pGleJoyD1yA5HfvuaksHxD0404gsEkNDerKsQ0N0y1s= diff --git a/sdk/messaging/azservicebus/internal/atom/entity_manager.go b/sdk/messaging/azservicebus/internal/atom/entity_manager.go index f8b9e157befd..553a665a6dc2 100644 --- a/sdk/messaging/azservicebus/internal/atom/entity_manager.go +++ b/sdk/messaging/azservicebus/internal/atom/entity_manager.go @@ -386,7 +386,7 @@ func TraceReqAndResponseMiddleware() MiddlewareFunc { } type feedEmptyError struct { - azcore.HTTPResponse + azcore.ResponseError response *http.Response } @@ -404,20 +404,20 @@ func NotFound(err error) (bool, *http.Response) { return true, feedEmptyError.RawResponse() } - var httpResponse azcore.HTTPResponse + var httpResponse *azcore.ResponseError if errors.As(err, &httpResponse) { - return httpResponse.RawResponse().StatusCode == 404, httpResponse.RawResponse() + return httpResponse.RawResponse.StatusCode == 404, httpResponse.RawResponse } return false, nil } func AsHTTPResponse(err error) *http.Response { - var httpResponse azcore.HTTPResponse + var httpResponse *azcore.ResponseError if errors.As(err, &httpResponse) { - return httpResponse.RawResponse() + return httpResponse.RawResponse } return nil diff --git a/sdk/messaging/azservicebus/internal/atom/manager_common_test.go b/sdk/messaging/azservicebus/internal/atom/manager_common_test.go index d7e5e7628855..fc02c9c9ed41 100644 --- a/sdk/messaging/azservicebus/internal/atom/manager_common_test.go +++ b/sdk/messaging/azservicebus/internal/atom/manager_common_test.go @@ -17,7 +17,7 @@ import ( func TestResponseError(t *testing.T) { // sanity check to make sure my error conforms to azcore's interface - var err azcore.HTTPResponse = ResponseError{} + var err azcore.ResponseError = azcore.ResponseError{} require.NotNil(t, err) require.EqualValues(t, "this is now the error message: 409", NewResponseError(nil, &http.Response{ From 829138e422ae651fc898fff8b45d98ceaa6080e4 Mon Sep 17 00:00:00 2001 From: Richard Park Date: Fri, 7 Jan 2022 16:38:46 -0800 Subject: [PATCH 2/5] At the moment we're not using azcore's HTTP library, so we don't need to test for specific errors that come from azcore --- .../azservicebus/admin/admin_client_test.go | 7 ------- .../internal/atom/entity_manager.go | 17 ----------------- .../internal/atom/manager_common_test.go | 5 ----- 3 files changed, 29 deletions(-) diff --git a/sdk/messaging/azservicebus/admin/admin_client_test.go b/sdk/messaging/azservicebus/admin/admin_client_test.go index 98450235ab48..8ff788c909fe 100644 --- a/sdk/messaging/azservicebus/admin/admin_client_test.go +++ b/sdk/messaging/azservicebus/admin/admin_client_test.go @@ -5,7 +5,6 @@ package admin import ( "context" - "errors" "fmt" "net/http" "os" @@ -14,7 +13,6 @@ import ( "testing" "time" - "github.com/Azure/azure-sdk-for-go/sdk/azcore" "github.com/Azure/azure-sdk-for-go/sdk/azcore/to" "github.com/Azure/azure-sdk-for-go/sdk/azidentity" "github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus/internal/atom" @@ -799,11 +797,6 @@ func TestAdminClient_LackPermissions_Topic(t *testing.T) { _, err = testData.Client.DeleteTopic(ctx, testData.TopicName, nil) require.Contains(t, err.Error(), "error code: 401, Details: Authorization failed for specified action: Manage,EntityDelete.") - - // sanity check that the http response is getting bundled into these errors, should it be needed. - var httpResponse *azcore.ResponseError - require.True(t, errors.As(err, &httpResponse)) - require.EqualValues(t, http.StatusUnauthorized, httpResponse.RawResponse.StatusCode) } func TestAdminClient_LackPermissions_Subscription(t *testing.T) { diff --git a/sdk/messaging/azservicebus/internal/atom/entity_manager.go b/sdk/messaging/azservicebus/internal/atom/entity_manager.go index 553a665a6dc2..179b5b60d678 100644 --- a/sdk/messaging/azservicebus/internal/atom/entity_manager.go +++ b/sdk/messaging/azservicebus/internal/atom/entity_manager.go @@ -386,7 +386,6 @@ func TraceReqAndResponseMiddleware() MiddlewareFunc { } type feedEmptyError struct { - azcore.ResponseError response *http.Response } @@ -404,25 +403,9 @@ func NotFound(err error) (bool, *http.Response) { return true, feedEmptyError.RawResponse() } - var httpResponse *azcore.ResponseError - - if errors.As(err, &httpResponse) { - return httpResponse.RawResponse.StatusCode == 404, httpResponse.RawResponse - } - return false, nil } -func AsHTTPResponse(err error) *http.Response { - var httpResponse *azcore.ResponseError - - if errors.As(err, &httpResponse) { - return httpResponse.RawResponse - } - - return nil -} - func isEmptyFeed(b []byte) bool { var emptyFeed QueueFeed feedErr := xml.Unmarshal(b, &emptyFeed) diff --git a/sdk/messaging/azservicebus/internal/atom/manager_common_test.go b/sdk/messaging/azservicebus/internal/atom/manager_common_test.go index fc02c9c9ed41..9945fff0b8ec 100644 --- a/sdk/messaging/azservicebus/internal/atom/manager_common_test.go +++ b/sdk/messaging/azservicebus/internal/atom/manager_common_test.go @@ -11,15 +11,10 @@ import ( "strings" "testing" - "github.com/Azure/azure-sdk-for-go/sdk/azcore" "github.com/stretchr/testify/require" ) func TestResponseError(t *testing.T) { - // sanity check to make sure my error conforms to azcore's interface - var err azcore.ResponseError = azcore.ResponseError{} - require.NotNil(t, err) - require.EqualValues(t, "this is now the error message: 409", NewResponseError(nil, &http.Response{ StatusCode: http.StatusConflict, Status: "this is now the error message", From f2d8d6e26a5a4a3ff91c44e85e4f23ce378c7f2f Mon Sep 17 00:00:00 2001 From: Richard Park Date: Fri, 7 Jan 2022 16:39:21 -0800 Subject: [PATCH 3/5] Remove empty sections from changelog (still needs a date) --- sdk/messaging/azservicebus/CHANGELOG.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sdk/messaging/azservicebus/CHANGELOG.md b/sdk/messaging/azservicebus/CHANGELOG.md index 832f2beba75a..b43538a4210e 100644 --- a/sdk/messaging/azservicebus/CHANGELOG.md +++ b/sdk/messaging/azservicebus/CHANGELOG.md @@ -6,12 +6,6 @@ - Support the pass-through of an Application ID when constructing an Azure Service Bus Client. -### Breaking Changes - -### Bugs Fixed - -### Other Changes - ## 0.3.2 (2021-12-08) ### Features Added From ee452b9e60e947a2e73a94aa8c346f872f999154 Mon Sep 17 00:00:00 2001 From: Richard Park Date: Mon, 10 Jan 2022 10:13:15 -0800 Subject: [PATCH 4/5] Updating some older docs I noticed, updating changelog with potential release date. --- sdk/messaging/azservicebus/CHANGELOG.md | 2 +- sdk/messaging/azservicebus/internal/atom/errors.go | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sdk/messaging/azservicebus/CHANGELOG.md b/sdk/messaging/azservicebus/CHANGELOG.md index b43538a4210e..a9d6359679e4 100644 --- a/sdk/messaging/azservicebus/CHANGELOG.md +++ b/sdk/messaging/azservicebus/CHANGELOG.md @@ -1,6 +1,6 @@ # Release History -## 0.3.3 (Unreleased) +## 0.3.3 (2022-01-11) ### Features Added diff --git a/sdk/messaging/azservicebus/internal/atom/errors.go b/sdk/messaging/azservicebus/internal/atom/errors.go index 25bbe9d534b0..e8182a433746 100644 --- a/sdk/messaging/azservicebus/internal/atom/errors.go +++ b/sdk/messaging/azservicebus/internal/atom/errors.go @@ -12,7 +12,9 @@ func NewResponseError(inner error, resp *http.Response) error { return ResponseError{inner, resp} } -// ResponseError conforms to the azcore.HTTPResponse +// ResponseError conforms to the older azcore.HTTPResponse +// NOTE: after breaking changes have been incorporated we'll move +// to the newer azcore.HTTPResponseError type ResponseError struct { inner error resp *http.Response From a7cb5d64d9bb368f664d4d075b94366cabb4def7 Mon Sep 17 00:00:00 2001 From: Richard Park Date: Mon, 10 Jan 2022 13:58:28 -0800 Subject: [PATCH 5/5] updating date since we're actually shipping on Wednesday --- sdk/messaging/azservicebus/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/messaging/azservicebus/CHANGELOG.md b/sdk/messaging/azservicebus/CHANGELOG.md index a9d6359679e4..a921ee4c9528 100644 --- a/sdk/messaging/azservicebus/CHANGELOG.md +++ b/sdk/messaging/azservicebus/CHANGELOG.md @@ -1,6 +1,6 @@ # Release History -## 0.3.3 (2022-01-11) +## 0.3.3 (2022-01-12) ### Features Added