From 156a43aab6bca7bb678a7f9d10ca8ae2e8ba75d4 Mon Sep 17 00:00:00 2001 From: Kim Ying <15070078+kimprice@users.noreply.github.com> Date: Wed, 29 Dec 2021 15:39:59 -0800 Subject: [PATCH 1/2] Updated README sample code container name should be all lowercase --- sdk/storage/azblob/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/storage/azblob/README.md b/sdk/storage/azblob/README.md index 2828035d17b7..0001c03c9c20 100644 --- a/sdk/storage/azblob/README.md +++ b/sdk/storage/azblob/README.md @@ -164,7 +164,7 @@ Three different clients are provided to interact with the various components of // ===== 1. Creating a container ===== // First, branch off of the service client and create a container client. - container := service.NewContainerClient("myContainer") + container := service.NewContainerClient("mycontainer") // Then, fire off a create operation on the container client. // Note that, all service-side requests have an options bag attached, allowing you to specify things like metadata, public access types, etc. // Specifying nil omits all options. From 064407c4ba91c668310c2c1854f837a15bcb0bfa Mon Sep 17 00:00:00 2001 From: Kim Ying <15070078+kimprice@users.noreply.github.com> Date: Wed, 29 Dec 2021 16:09:14 -0800 Subject: [PATCH 2/2] Fix typo GetAccountSASToken to GetSASToken I believe 'GetAccountSASToken' was written by mistake. It's inconsistent with what is described on line 97 and I don't see this method in the documentation. --- sdk/storage/azblob/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/storage/azblob/README.md b/sdk/storage/azblob/README.md index 0001c03c9c20..34aedafd1cb3 100644 --- a/sdk/storage/azblob/README.md +++ b/sdk/storage/azblob/README.md @@ -103,7 +103,7 @@ serviceClient, err := azblob.NewServiceClientWithSharedKey(fmt.Sprintf("https:// handle(err) // Provide the convenience function with relevant info (services, resource types, permissions, and duration) // The SAS token will be valid from this moment onwards. -accountSAS, err := serviceClient.GetAccountSASToken(AccountSASResourceTypes{Object: true, Service: true, Container: true}, +accountSAS, err := serviceClient.GetSASToken(AccountSASResourceTypes{Object: true, Service: true, Container: true}, AccountSASPermissions{Read: true, List: true}, AccountSASServices{Blob: true}, time.Now(), time.Now().Add(48*time.Hour)) handle(err) urlToSend := fmt.Sprintf("https://%s.blob.core.windows.net/?%s", accountName, accountSAS)