Skip to content

Remove 'using namespace' from header files #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove 'using namespace' from header files #5260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...bles/azure-data-tables/inc/azure/data/tables/internal/policies/shared_key_lite_policy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
#include <memory>
#include <string>

using namespace Azure::Data::Tables::Credentials;

namespace Azure { namespace Data { namespace Tables { namespace _detail { namespace Policies {
class SharedKeyLitePolicy final : public Core::Http::Policies::HttpPolicy {
public:
explicit SharedKeyLitePolicy(std::shared_ptr<SharedKeyCredential> credential)
explicit SharedKeyLitePolicy(std::shared_ptr<Credentials::SharedKeyCredential> credential)
: m_credential{std::move(credential)}
{
}
Expand All @@ -39,7 +37,7 @@ namespace Azure { namespace Data { namespace Tables { namespace _detail { namesp
}

std::string GetSignature(const Core::Http::Request& request) const;
std::shared_ptr<SharedKeyCredential> m_credential;
std::shared_ptr<Credentials::SharedKeyCredential> m_credential;
};

}}}}} // namespace Azure::Data::Tables::_detail::Policies
6 changes: 2 additions & 4 deletions sdk/tables/azure-data-tables/inc/azure/data/tables/internal/policies/shared_key_policy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@
#include <memory>
#include <string>

using namespace Azure::Data::Tables::Credentials;

namespace Azure { namespace Data { namespace Tables { namespace _detail { namespace Policies {

class SharedKeyPolicy final : public Core::Http::Policies::HttpPolicy {
public:
explicit SharedKeyPolicy(std::shared_ptr<SharedKeyCredential> credential)
explicit SharedKeyPolicy(std::shared_ptr<Credentials::SharedKeyCredential> credential)
: m_credential{std::move(credential)}
{
}
Expand All @@ -41,7 +39,7 @@ namespace Azure { namespace Data { namespace Tables { namespace _detail { namesp
private:
std::string GetSignature(const Core::Http::Request& request) const;

std::shared_ptr<SharedKeyCredential> m_credential;
std::shared_ptr<Credentials::SharedKeyCredential> m_credential;
};

}}}}} // namespace Azure::Data::Tables::_detail::Policies