From 77e7ada8a10eb94a3b48eccbcb5d005b6233c702 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Tue, 11 Oct 2022 16:16:12 -0700 Subject: [PATCH 1/4] Updated attestation change log to add periods for consistency --- sdk/attestation/azure-security-attestation/CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/attestation/azure-security-attestation/CHANGELOG.md b/sdk/attestation/azure-security-attestation/CHANGELOG.md index e4300cd817..e1107c5cc8 100644 --- a/sdk/attestation/azure-security-attestation/CHANGELOG.md +++ b/sdk/attestation/azure-security-attestation/CHANGELOG.md @@ -6,10 +6,10 @@ ### Breaking Changes -- Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave` +- Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`. - Added `std::vector` dataToAttest parameter. -- Removed `Payload` in `TpmAttestationOptions` -- Changed `TpmResult` in `TpmAttestationResult` to type `std::vector` +- Removed `Payload` in `TpmAttestationOptions`. +- Changed `TpmResult` in `TpmAttestationResult` to type `std::vector`. ### Bugs Fixed From 83d5e7ce0ae131e49597006cabd5cc0ada1ddc5e Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Tue, 11 Oct 2022 16:18:09 -0700 Subject: [PATCH 2/4] Update wording for a breaking change. --- sdk/attestation/azure-security-attestation/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/attestation/azure-security-attestation/CHANGELOG.md b/sdk/attestation/azure-security-attestation/CHANGELOG.md index e1107c5cc8..cede13dfb2 100644 --- a/sdk/attestation/azure-security-attestation/CHANGELOG.md +++ b/sdk/attestation/azure-security-attestation/CHANGELOG.md @@ -7,7 +7,7 @@ ### Breaking Changes - Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`. -- Added `std::vector` dataToAttest parameter. +- Added `std::vector` dataToAttest parameter to the AttestTpm() client method. - Removed `Payload` in `TpmAttestationOptions`. - Changed `TpmResult` in `TpmAttestationResult` to type `std::vector`. From 7b76bc67cc6cfe58bfec8ba879dd526f5a20b282 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Tue, 11 Oct 2022 16:19:06 -0700 Subject: [PATCH 3/4] Add back-ticks. --- sdk/attestation/azure-security-attestation/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/attestation/azure-security-attestation/CHANGELOG.md b/sdk/attestation/azure-security-attestation/CHANGELOG.md index cede13dfb2..bab53a0f37 100644 --- a/sdk/attestation/azure-security-attestation/CHANGELOG.md +++ b/sdk/attestation/azure-security-attestation/CHANGELOG.md @@ -7,7 +7,7 @@ ### Breaking Changes - Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`. -- Added `std::vector` dataToAttest parameter to the AttestTpm() client method. +- Added `std::vector` dataToAttest parameter to the `AttestTpm()` client method. - Removed `Payload` in `TpmAttestationOptions`. - Changed `TpmResult` in `TpmAttestationResult` to type `std::vector`. From 0c4d204e2b3471381b2e2c49ad641c6b9e5e1808 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Tue, 11 Oct 2022 16:30:57 -0700 Subject: [PATCH 4/4] Make the sub-bullets under the main one. --- sdk/attestation/azure-security-attestation/CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdk/attestation/azure-security-attestation/CHANGELOG.md b/sdk/attestation/azure-security-attestation/CHANGELOG.md index bab53a0f37..a522bd05b6 100644 --- a/sdk/attestation/azure-security-attestation/CHANGELOG.md +++ b/sdk/attestation/azure-security-attestation/CHANGELOG.md @@ -6,10 +6,10 @@ ### Breaking Changes -- Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`. -- Added `std::vector` dataToAttest parameter to the `AttestTpm()` client method. -- Removed `Payload` in `TpmAttestationOptions`. -- Changed `TpmResult` in `TpmAttestationResult` to type `std::vector`. +- Changed `AttestationClient::AttestTpm` to match `AttestOpenEnclave` and `AttestSgxEnclave`: + - Added `std::vector` dataToAttest parameter to the `AttestTpm()` client method. + - Removed `Payload` in `TpmAttestationOptions`. + - Changed `TpmResult` in `TpmAttestationResult` to type `std::vector`. ### Bugs Fixed