From c7ad64496472fbae09ed20758d42fd898469167c Mon Sep 17 00:00:00 2001
From: JinmingHu <jinmhu@microsoft.com>
Date: Wed, 4 May 2022 16:28:28 +0800
Subject: [PATCH] Get rid of warnings in nullable.hpp

I keep getting warnings like below

```
Severity	Code	Description	Project	File	Line	Suppression State
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::BlobImmutabilityPolicy>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::EncryptionKey>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::AccessTier>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::ArchiveStatus>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::CopyStatus>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::LeaseDurationType>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::LeaseState>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::LeaseStatus>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::Models::RehydratePriority>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<__int64>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<bool>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<int>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<std::vector<unsigned char,std::allocator<unsigned char> > >::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	61
Warning	C26495	Variable 'Azure::Nullable<Azure::Storage::Blobs::EncryptionKey>::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	75
Warning	C26495	Variable 'Azure::Nullable<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::<unnamed-tag>::m_value' is uninitialized. Always initialize a member variable (type.6).	datamovement-getting-started	C:\Users\Jamis\Desktop\azure-sdk-for-cpp\sdk\core\azure-core\inc\azure\core\nullable.hpp	75
```

This PR fixes the issue.
---
 sdk/core/azure-core/inc/azure/core/nullable.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sdk/core/azure-core/inc/azure/core/nullable.hpp b/sdk/core/azure-core/inc/azure/core/nullable.hpp
index 1233d21671..97e97f89a7 100644
--- a/sdk/core/azure-core/inc/azure/core/nullable.hpp
+++ b/sdk/core/azure-core/inc/azure/core/nullable.hpp
@@ -59,7 +59,7 @@ template <class T> class Nullable final {
    * @param other Another `%Nullable` instance to copy.
    */
   Nullable(const Nullable& other) noexcept(std::is_nothrow_copy_constructible<T>::value)
-      : m_hasValue(other.m_hasValue)
+      : m_disengaged{}, m_hasValue(other.m_hasValue)
   {
     if (m_hasValue)
     {
@@ -73,7 +73,7 @@ template <class T> class Nullable final {
    * @param other A `%Nullable` instance to move into the instance being constructed.
    */
   Nullable(Nullable&& other) noexcept(std::is_nothrow_move_constructible<T>::value)
-      : m_hasValue(other.m_hasValue)
+      : m_disengaged{}, m_hasValue(other.m_hasValue)
   {
     if (m_hasValue)
     {