Skip to content

Update service version for keyvault Secrets to 7.3 #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gearama merged 5 commits into from
Apr 11, 2022
Merged

Update service version for keyvault Secrets to 7.3 #3540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99db07b
one commit to rule them all
gearama Apr 7, 2022
da41922
Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp
gearama Apr 7, 2022
47482f4
Updated service version to 7.3
gearama Apr 7, 2022
f32cb4e
support v7.2
gearama Apr 11, 2022
5f03b05
typo
gearama Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_options.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @brief Keyvault Secret actions options
*/
#pragma once
#include "azure/keyvault/secrets/dll_import_export.hpp"
#include "dll_import_export.hpp"
#include <azure/core/internal/client_options.hpp>

namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
Expand Down Expand Up @@ -41,6 +41,12 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
*
*/
AZURE_SECURITY_KEYVAULT_SECRETS_DLLEXPORT static const ServiceVersion V7_2;

/**
* @brief Use to send request to the 7.3 version of Key Vault service.
*
*/
AZURE_SECURITY_KEYVAULT_SECRETS_DLLEXPORT static const ServiceVersion V7_3;
};

/**
Expand All @@ -49,14 +55,18 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
*/
struct SecretClientOptions final : public Azure::Core::_internal::ClientOptions
{
ServiceVersion Version;
/**
* @brief Service Version used.
*
*/
const ServiceVersion Version;

/**
* @brief Construct a new Secret Client Options object.
*
* @param version Optional version for the client.
*/
SecretClientOptions(ServiceVersion version = ServiceVersion::V7_2)
SecretClientOptions(ServiceVersion version = ServiceVersion::V7_3)
: Azure::Core::_internal::ClientOptions(), Version(version)
{
}
Expand Down
1 change: 1 addition & 0 deletions sdk/keyvault/azure-security-keyvault-secrets/src/secret_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ using namespace Azure::Core::Http::Policies;
using namespace Azure::Core::Http::Policies::_internal;
using namespace Azure::Security::KeyVault::Secrets::_detail;

const ServiceVersion ServiceVersion::V7_3("7.3");
const ServiceVersion ServiceVersion::V7_2("7.2");

std::unique_ptr<RawResponse> SecretClient::SendRequest(
Expand Down
52 changes: 26 additions & 26 deletions ...-security-keyvault-secrets/test/ut/recordings/KeyVaultSecretClientTest.BackupRestore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "4316c6df-60ab-490d-63d4-f92556a48623"
},
"Method": "PUT",
Expand All @@ -25,12 +25,12 @@
"x-ms-request-id": "f95376ab-838d-4260-865a-d5674167dfcb",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "89e6cc90-bce5-4f42-49c0-3b5240b496b6"
},
"Method": "POST",
Expand All @@ -52,12 +52,12 @@
"x-ms-request-id": "ba30c423-9412-4cfd-8440-cb9be2acde92",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore/backup?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore/backup?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "a3f54f5b-afd0-4878-5f3b-0e4764859e31"
},
"Method": "DELETE",
Expand All @@ -79,12 +79,12 @@
"x-ms-request-id": "fa272403-fd11-4641-aee0-a25c3e68ba14",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "6a63a721-bea4-479d-5c86-c696200570bf"
},
"Method": "GET",
Expand All @@ -106,12 +106,12 @@
"x-ms-request-id": "d6f92fde-f576-46d0-963b-207e613bd5ee",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "970c66b2-0290-48ca-57ab-920ade90077c"
},
"Method": "GET",
Expand All @@ -133,12 +133,12 @@
"x-ms-request-id": "b0a593ec-6523-4ec7-89e0-4528e1aaea0d",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "32a975a8-ca0c-4c42-7014-fddd321489fd"
},
"Method": "GET",
Expand All @@ -160,12 +160,12 @@
"x-ms-request-id": "6efb06c6-95ef-46c9-86bc-7b24998b8ef1",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "924dd1fa-b628-4ca8-7ab9-060b73f1e936"
},
"Method": "DELETE",
Expand All @@ -185,12 +185,12 @@
"x-ms-request-id": "88a61f20-ec78-4c05-b44b-7af7047a4d03",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "338f3014-909c-4eb5-7f8d-67fe1fae7712"
},
"Method": "POST",
Expand All @@ -212,12 +212,12 @@
"x-ms-request-id": "221bfac0-0882-4b01-bb86-e7cab76844a3",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/restore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/restore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "f27faacd-5749-4dcc-47ee-1d66581ff693"
},
"Method": "DELETE",
Expand All @@ -239,12 +239,12 @@
"x-ms-request-id": "90776b81-3da6-4023-9a9a-c70fbaba4b58",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "5bf50f69-10f5-4d56-7479-754a12d2e803"
},
"Method": "GET",
Expand All @@ -266,12 +266,12 @@
"x-ms-request-id": "5ac8762e-92bd-43cc-97c3-7711262ae379",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "9cdadd07-dcf3-4ba2-76f0-0b00da7f1086"
},
"Method": "GET",
Expand All @@ -293,12 +293,12 @@
"x-ms-request-id": "f3d38cb2-5493-4b26-a3af-1d92e1753899",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "71bec330-8e3e-4b43-5bd0-8e3ad1e29267"
},
"Method": "GET",
Expand All @@ -320,12 +320,12 @@
"x-ms-request-id": "5e752b66-2b9e-4aab-afa5-f3c93c8984a9",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "7f471246-c2bb-43e8-606d-bad929e08522"
},
"Method": "DELETE",
Expand All @@ -345,7 +345,7 @@
"x-ms-request-id": "806cf287-a483-4e34-b173-7973ef15e061",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/BackupRestore?api-version=7.3"
}
]
}
28 changes: 14 additions & 14 deletions ...ecurity-keyvault-secrets/test/ut/recordings/KeyVaultSecretClientTest.FirstCreateTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "b3129259-ee3a-4a2b-4942-1d8454c1726d"
},
"Method": "PUT",
Expand All @@ -25,12 +25,12 @@
"x-ms-request-id": "c1ee6aa3-ae1f-4172-859e-e3a0bffcc4f1",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "9d0b8a93-ea22-4e6e-659f-d1e4a5c343b3"
},
"Method": "GET",
Expand All @@ -52,12 +52,12 @@
"x-ms-request-id": "b91b6851-23c7-4023-ace6-aa864b159824",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "a01b1272-e9a6-4b6d-7061-49d3b04d1277"
},
"Method": "DELETE",
Expand All @@ -79,12 +79,12 @@
"x-ms-request-id": "33b73bd3-05c6-440b-aa53-cfbcd14721d7",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/secrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "c3f6ad31-a8ea-4a96-6e18-7e8c441ae18d"
},
"Method": "GET",
Expand All @@ -106,12 +106,12 @@
"x-ms-request-id": "96fcfff0-4731-4abd-bb9c-14d1ea61cfff",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "4b8519f8-39eb-4917-6d4f-b60f4b21284e"
},
"Method": "GET",
Expand All @@ -133,12 +133,12 @@
"x-ms-request-id": "4c68a5b3-c195-4e1b-8d97-d6b16f340e02",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "4f39f466-a211-40fd-5a48-0f53cce86fb3"
},
"Method": "GET",
Expand All @@ -160,12 +160,12 @@
"x-ms-request-id": "6ecaab0b-01e1-4472-b3df-581f6e4cbb2b",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.3"
},
{
"Headers": {
"content-type": "application/json",
"user-agent": "azsdk-cpp-keyvault-secrets/7.2 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"user-agent": "azsdk-cpp-keyvault-secrets/7.3 (Windows 10 Enterprise 6.3 19043 19041.1.amd64fre.vb_release.191206-1406)",
"x-ms-client-request-id": "80ddbf36-0707-4ed3-4c3e-bf24b3caf67d"
},
"Method": "DELETE",
Expand All @@ -185,7 +185,7 @@
"x-ms-request-id": "cec4bc4a-e1cd-4077-baaa-bf82313f1f8e",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedsecrets/FirstCreateTest?api-version=7.3"
}
]
}
Loading