diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md index 5604cde90b..6718b8ab10 100644 --- a/sdk/core/azure-core/CHANGELOG.md +++ b/sdk/core/azure-core/CHANGELOG.md @@ -5,7 +5,7 @@ ### Features Added - When a `RequestFailedException` exception is thrown, the `what()` method now includes information about the HTTP request which failed. -- Adding option `WinHttpTransportOptions.IgnoreUnknownServerCert`. It can be used to disable verifying server certificate for the `WinHttpTransport`. +- Adding option `WinHttpTransportOptions.IgnoreUnknownCertificateAuthority`. It can be used to disable verifying server certificate for the `WinHttpTransport`. ### Breaking Changes diff --git a/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp b/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp index 07375fbda2..0e16fd84fe 100644 --- a/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp +++ b/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp @@ -129,10 +129,9 @@ namespace Azure { namespace Core { namespace Http { struct WinHttpTransportOptions final { /** - * @brief When `true`, allows an invalid certificate authority. If this flag is set, the - * application does not receive a WINHTTP_CALLBACK_STATUS_FLAG_INVALID_CA callback. + * @brief When `true`, allows an invalid certificate authority. */ - bool IgnoreUnknownServerCert = false; + bool IgnoreUnknownCertificateAuthority = false; }; /** diff --git a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp index a21878a240..f82fd79c83 100644 --- a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp +++ b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp @@ -359,7 +359,7 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage } } - if (m_options.IgnoreUnknownServerCert) + if (m_options.IgnoreUnknownCertificateAuthority) { auto option = SECURITY_FLAG_IGNORE_UNKNOWN_CA; if (!WinHttpSetOption( diff --git a/sdk/core/perf/src/base_test.cpp b/sdk/core/perf/src/base_test.cpp index 482f9bf323..a073326b6d 100644 --- a/sdk/core/perf/src/base_test.cpp +++ b/sdk/core/perf/src/base_test.cpp @@ -116,7 +116,7 @@ namespace Azure { namespace Perf { = std::make_shared(curlOptions); #elif defined(BUILD_TRANSPORT_WINHTTP_ADAPTER) Azure::Core::Http::WinHttpTransportOptions winHttpOptions; - winHttpOptions.IgnoreUnknownServerCert = true; + winHttpOptions.IgnoreUnknownCertificateAuthority = true; clientOptions.Transport.Transport = std::make_shared(winHttpOptions); #else