QueryTablesIncludeFlags doesn't seem to be used anywhere within the QueryTables operation

[ahsonkhan]

This option doesn't seem to be used by the SDK, in the implementation detail, but is publicly exposed:
#6154

It's probably worth going back to a source of truth and investigating. What does the REST API specs or service docs say here?

Maybe it was carried over from storage, where "include" is added as query parameter. Should the same be done here?

azure-sdk-for-cpp/sdk/storage/azure-storage-blobs/src/rest_client.cpp

Lines 788 to 795 in c168d73

	if (options.Include.HasValue()
	&& !ListBlobContainersIncludeFlagsToString(options.Include.Value()).empty())
	{
	request.GetUrl().AppendQueryParameter(
	"include",
	_internal::UrlEncodeQueryParameter(
	ListBlobContainersIncludeFlagsToString(options.Include.Value())));
	}

GoLang doesn't seem to have this option, though I am not familiar with the service or specifics of Go's implementation:
https://github.com/Azure/azure-sdk-for-go/blob/0387c89ceebae256c9ea717533c739b7a875d996/sdk/data/aztables/options.go#L115-L145

[ahsonkhan]

Marking as blocking release if we need to remove it, since this is public surface area, and can't be fixed after.

cc @RickWinter, @LarryOsterman

[ahsonkhan]

The REST docs for query tables don't mention any use of the include query param.
https://learn.microsoft.com/en-us/rest/api/storageservices/query-tables

But, they do mention setting the Accept request header to one of a few sets of Metadata values (one of application/json;odata=nometadata, application/json;odata=minimalmetadata, application/json;odata=fullmetadata:
https://learn.microsoft.com/en-us/rest/api/storageservices/query-tables#request-headers

We seem to hardcode it to minimalmetadata always (and only in the PrepXEntity operations).

azure-sdk-for-cpp/sdk/tables/azure-data-tables/src/tables_clients.cpp

Line 1027 in c168d73

returnValue += "Accept: application/json;odata=minimalmetadata\n";

GoLang exposes this via options:
https://github.com/Azure/azure-sdk-for-go/blob/0387c89ceebae256c9ea717533c739b7a875d996/sdk/data/aztables/options.go#L129-L131
https://github.com/Azure/azure-sdk-for-go/blob/0387c89ceebae256c9ea717533c739b7a875d996/sdk/data/aztables/constants.go#L59-L67

cc @jhendrixMSFT

[ahsonkhan]

The other languages expose the Metadata option which let's users modify the accept request header when calling QueryTables. The REST API doc linked above mentions it.

Re-opening to consider what we want to do here.

[ahsonkhan]

For reference, here's the PR in GoLang which added the Metadata capability:
Azure/azure-sdk-for-go#22472

[gearama]

done