From 38c9764d776d3ead248cf184d40ab05497da6f23 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Fri, 11 Sep 2020 18:34:14 -0700 Subject: [PATCH 1/2] Places where we have const* arguments in source, optionally mark the value as const as well. --- sdk/src/azure/core/az_context.c | 8 ++++---- sdk/src/azure/core/az_http_policy_logging.c | 10 +++++----- sdk/src/azure/core/az_http_request.c | 10 +++++----- sdk/src/azure/core/az_http_response.c | 2 +- sdk/src/azure/core/az_json_reader.c | 4 ++-- sdk/src/azure/core/az_json_token.c | 20 +++++++++---------- sdk/src/azure/core/az_json_writer.c | 10 +++++----- sdk/src/azure/core/az_log.c | 2 +- sdk/src/azure/iot/az_iot_hub_client.c | 6 +++--- sdk/src/azure/iot/az_iot_hub_client_c2d.c | 2 +- sdk/src/azure/iot/az_iot_hub_client_methods.c | 4 ++-- sdk/src/azure/iot/az_iot_hub_client_sas.c | 4 ++-- .../azure/iot/az_iot_hub_client_telemetry.c | 4 ++-- sdk/src/azure/iot/az_iot_hub_client_twin.c | 6 +++--- .../azure/iot/az_iot_provisioning_client.c | 12 +++++------ .../iot/az_iot_provisioning_client_sas.c | 4 ++-- sdk/src/azure/platform/az_curl.c | 16 +++++++-------- sdk/src/azure/platform/az_nohttp.c | 2 +- .../storage/az_storage_blobs_blob_client.c | 4 ++-- 19 files changed, 65 insertions(+), 65 deletions(-) diff --git a/sdk/src/azure/core/az_context.c b/sdk/src/azure/core/az_context.c index a8ceeb67dc..2f010f9139 100644 --- a/sdk/src/azure/core/az_context.c +++ b/sdk/src/azure/core/az_context.c @@ -34,7 +34,7 @@ AZ_NODISCARD int64_t az_context_get_expiration(az_context const* context) // and return the corresponding value. Returns AZ_ERROR_ITEM_NOT_FOUND is there are no nodes // matching the specified key. AZ_NODISCARD az_result -az_context_get_value(az_context const* context, void const* key, void const** out_value) +az_context_get_value(az_context const* context, void const* const key, void const** out_value) { _az_PRECONDITION_NOT_NULL(context); _az_PRECONDITION_NOT_NULL(out_value); @@ -53,7 +53,7 @@ az_context_get_value(az_context const* context, void const* key, void const** ou } AZ_NODISCARD az_context -az_context_create_with_expiration(az_context const* parent, int64_t expiration) +az_context_create_with_expiration(az_context const* const parent, int64_t expiration) { _az_PRECONDITION_NOT_NULL(parent); _az_PRECONDITION(expiration >= 0); @@ -62,7 +62,7 @@ az_context_create_with_expiration(az_context const* parent, int64_t expiration) } AZ_NODISCARD az_context -az_context_create_with_value(az_context const* parent, void const* key, void const* value) +az_context_create_with_value(az_context const* const parent, void const* const key, void const* const value) { _az_PRECONDITION_NOT_NULL(parent); _az_PRECONDITION_NOT_NULL(key); @@ -80,7 +80,7 @@ void az_context_cancel(az_context* ref_context) ref_context->_internal.expiration = 0; // The beginning of time } -AZ_NODISCARD bool az_context_has_expired(az_context const* context, int64_t current_time) +AZ_NODISCARD bool az_context_has_expired(az_context const* const context, int64_t current_time) { _az_PRECONDITION_NOT_NULL(context); _az_PRECONDITION(current_time >= 0); diff --git a/sdk/src/azure/core/az_http_policy_logging.c b/sdk/src/azure/core/az_http_policy_logging.c index cb75a48e6b..f954526280 100644 --- a/sdk/src/azure/core/az_http_policy_logging.c +++ b/sdk/src/azure/core/az_http_policy_logging.c @@ -55,7 +55,7 @@ static az_span _az_http_policy_logging_copy_lengthy_value(az_span ref_log_msg, a } static az_result _az_http_policy_logging_append_http_request_msg( - az_http_request const* request, + az_http_request const* const request, az_span* ref_log_msg) { static az_span const auth_header_name = AZ_SPAN_LITERAL_FROM_STR("authorization"); @@ -125,7 +125,7 @@ static az_result _az_http_policy_logging_append_http_request_msg( static az_result _az_http_policy_logging_append_http_response_msg( az_http_response* ref_response, int64_t duration_msec, - az_http_request const* request, + az_http_request const* const request, az_span* ref_log_msg) { az_span http_response_string = AZ_SPAN_FROM_STR("HTTP Response ("); @@ -208,7 +208,7 @@ static az_result _az_http_policy_logging_append_http_response_msg( return AZ_OK; } -void _az_http_policy_logging_log_http_request(az_http_request const* request) +void _az_http_policy_logging_log_http_request(az_http_request const* const request) { uint8_t log_msg_buf[AZ_LOG_MESSAGE_BUFFER_SIZE] = { 0 }; az_span log_msg = AZ_SPAN_FROM_BUFFER(log_msg_buf); @@ -219,9 +219,9 @@ void _az_http_policy_logging_log_http_request(az_http_request const* request) } void _az_http_policy_logging_log_http_response( - az_http_response const* response, + az_http_response const* const response, int64_t duration_msec, - az_http_request const* request) + az_http_request const* const request) { uint8_t log_msg_buf[AZ_LOG_MESSAGE_BUFFER_SIZE] = { 0 }; az_span log_msg = AZ_SPAN_FROM_BUFFER(log_msg_buf); diff --git a/sdk/src/azure/core/az_http_request.c b/sdk/src/azure/core/az_http_request.c index 5ab3ec3fc0..bd98eea557 100644 --- a/sdk/src/azure/core/az_http_request.c +++ b/sdk/src/azure/core/az_http_request.c @@ -149,7 +149,7 @@ az_http_request_append_header(az_http_request* ref_request, az_span name, az_spa } AZ_NODISCARD az_result az_http_request_get_header( - az_http_request const* request, + az_http_request const* const request, int32_t index, az_span* out_name, az_span* out_value) @@ -173,7 +173,7 @@ AZ_NODISCARD az_result az_http_request_get_header( } AZ_NODISCARD az_result -az_http_request_get_method(az_http_request const* request, az_http_method* out_method) +az_http_request_get_method(az_http_request const* const request, az_http_method* out_method) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(out_method); @@ -183,7 +183,7 @@ az_http_request_get_method(az_http_request const* request, az_http_method* out_m return AZ_OK; } -AZ_NODISCARD az_result az_http_request_get_url(az_http_request const* request, az_span* out_url) +AZ_NODISCARD az_result az_http_request_get_url(az_http_request const* const request, az_span* out_url) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(out_url); @@ -193,7 +193,7 @@ AZ_NODISCARD az_result az_http_request_get_url(az_http_request const* request, a return AZ_OK; } -AZ_NODISCARD az_result az_http_request_get_body(az_http_request const* request, az_span* out_body) +AZ_NODISCARD az_result az_http_request_get_body(az_http_request const* const request, az_span* out_body) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(out_body); @@ -202,7 +202,7 @@ AZ_NODISCARD az_result az_http_request_get_body(az_http_request const* request, return AZ_OK; } -AZ_NODISCARD int32_t az_http_request_headers_count(az_http_request const* request) +AZ_NODISCARD int32_t az_http_request_headers_count(az_http_request const* const request) { return request->_internal.headers_length; } diff --git a/sdk/src/azure/core/az_http_response.c b/sdk/src/azure/core/az_http_response.c index 9cfc872b2d..86aadf3938 100644 --- a/sdk/src/azure/core/az_http_response.c +++ b/sdk/src/azure/core/az_http_response.c @@ -316,7 +316,7 @@ void _az_http_response_reset(az_http_response* ref_response) } // internal function to get az_http_response remainder -static az_span _az_http_response_get_remaining(az_http_response const* response) +static az_span _az_http_response_get_remaining(az_http_response const* const response) { return az_span_slice_to_end(response->_internal.http_response, response->_internal.written); } diff --git a/sdk/src/azure/core/az_json_reader.c b/sdk/src/azure/core/az_json_reader.c index 9d1bde28e0..ae428af2fa 100644 --- a/sdk/src/azure/core/az_json_reader.c +++ b/sdk/src/azure/core/az_json_reader.c @@ -14,7 +14,7 @@ AZ_NODISCARD az_result az_json_reader_init( az_json_reader* out_json_reader, az_span json_buffer, - az_json_reader_options const* options) + az_json_reader_options const* const options) { _az_PRECONDITION(az_span_size(json_buffer) >= 1); @@ -52,7 +52,7 @@ AZ_NODISCARD az_result az_json_reader_chunked_init( az_json_reader* out_json_reader, az_span json_buffers[], int32_t number_of_buffers, - az_json_reader_options const* options) + az_json_reader_options const* const options) { _az_PRECONDITION(number_of_buffers >= 1); _az_PRECONDITION(az_span_size(json_buffers[0]) >= 1); diff --git a/sdk/src/azure/core/az_json_token.c b/sdk/src/azure/core/az_json_token.c index f4852f6dbd..fca8ad8cd2 100644 --- a/sdk/src/azure/core/az_json_token.c +++ b/sdk/src/azure/core/az_json_token.c @@ -11,7 +11,7 @@ #include static az_span _az_json_token_copy_into_span_helper( - az_json_token const* json_token, + az_json_token const* const json_token, az_span destination) { _az_PRECONDITION(json_token->_internal.is_multisegment); @@ -40,7 +40,7 @@ static az_span _az_json_token_copy_into_span_helper( return destination; } -az_span az_json_token_copy_into_span(az_json_token const* json_token, az_span destination) +az_span az_json_token_copy_into_span(az_json_token const* const json_token, az_span destination) { _az_PRECONDITION_VALID_SPAN(destination, json_token->size, false); @@ -149,7 +149,7 @@ AZ_NODISCARD static bool _az_json_token_is_text_equal_helper( } AZ_NODISCARD bool az_json_token_is_text_equal( - az_json_token const* json_token, + az_json_token const* const json_token, az_span expected_text) { _az_PRECONDITION_NOT_NULL(json_token); @@ -243,7 +243,7 @@ AZ_NODISCARD bool az_json_token_is_text_equal( return az_span_size(expected_text) == 0; } -AZ_NODISCARD az_result az_json_token_get_boolean(az_json_token const* json_token, bool* out_value) +AZ_NODISCARD az_result az_json_token_get_boolean(az_json_token const* const json_token, bool* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -326,7 +326,7 @@ AZ_NODISCARD static az_result _az_json_token_get_string_helper( } AZ_NODISCARD az_result az_json_token_get_string( - az_json_token const* json_token, + az_json_token const* const json_token, char* destination, int32_t destination_max_size, int32_t* out_string_length) @@ -429,7 +429,7 @@ AZ_NODISCARD az_result az_json_token_get_string( } AZ_NODISCARD az_result -az_json_token_get_uint64(az_json_token const* json_token, uint64_t* out_value) +az_json_token_get_uint64(az_json_token const* const json_token, uint64_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -464,7 +464,7 @@ az_json_token_get_uint64(az_json_token const* json_token, uint64_t* out_value) } AZ_NODISCARD az_result -az_json_token_get_uint32(az_json_token const* json_token, uint32_t* out_value) +az_json_token_get_uint32(az_json_token const* const json_token, uint32_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -498,7 +498,7 @@ az_json_token_get_uint32(az_json_token const* json_token, uint32_t* out_value) return az_span_atou32(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_int64(az_json_token const* json_token, int64_t* out_value) +AZ_NODISCARD az_result az_json_token_get_int64(az_json_token const* const json_token, int64_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -532,7 +532,7 @@ AZ_NODISCARD az_result az_json_token_get_int64(az_json_token const* json_token, return az_span_atoi64(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_int32(az_json_token const* json_token, int32_t* out_value) +AZ_NODISCARD az_result az_json_token_get_int32(az_json_token const* const json_token, int32_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -566,7 +566,7 @@ AZ_NODISCARD az_result az_json_token_get_int32(az_json_token const* json_token, return az_span_atoi32(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_double(az_json_token const* json_token, double* out_value) +AZ_NODISCARD az_result az_json_token_get_double(az_json_token const* const json_token, double* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); diff --git a/sdk/src/azure/core/az_json_writer.c b/sdk/src/azure/core/az_json_writer.c index d01263e338..f566b61b82 100644 --- a/sdk/src/azure/core/az_json_writer.c +++ b/sdk/src/azure/core/az_json_writer.c @@ -15,7 +15,7 @@ AZ_NODISCARD az_result az_json_writer_init( az_json_writer* out_json_writer, az_span destination_buffer, - az_json_writer_options const* options) + az_json_writer_options const* const options) { _az_PRECONDITION_NOT_NULL(out_json_writer); @@ -40,7 +40,7 @@ AZ_NODISCARD az_result az_json_writer_chunked_init( az_span first_destination_buffer, az_span_allocator_fn allocator_callback, void* user_context, - az_json_writer_options const* options) + az_json_writer_options const* const options) { _az_PRECONDITION_NOT_NULL(out_json_writer); _az_PRECONDITION_NOT_NULL(allocator_callback); @@ -93,7 +93,7 @@ _get_remaining_span(az_json_writer* ref_json_writer, int32_t required_size) // This validation method is used outside of just preconditions, within // az_json_writer_append_json_text. -static AZ_NODISCARD bool _az_is_appending_value_valid(az_json_writer const* json_writer) +static AZ_NODISCARD bool _az_is_appending_value_valid(az_json_writer const* const json_writer) { _az_PRECONDITION_NOT_NULL(json_writer); @@ -136,7 +136,7 @@ static AZ_NODISCARD bool _az_is_appending_value_valid(az_json_writer const* json } #ifndef AZ_NO_PRECONDITION_CHECKING -static AZ_NODISCARD bool _az_is_appending_property_name_valid(az_json_writer const* json_writer) +static AZ_NODISCARD bool _az_is_appending_property_name_valid(az_json_writer const* const json_writer) { _az_PRECONDITION_NOT_NULL(json_writer); @@ -156,7 +156,7 @@ static AZ_NODISCARD bool _az_is_appending_property_name_valid(az_json_writer con } static AZ_NODISCARD bool _az_is_appending_container_end_valid( - az_json_writer const* json_writer, + az_json_writer const* const json_writer, uint8_t byte) { _az_PRECONDITION_NOT_NULL(json_writer); diff --git a/sdk/src/azure/core/az_log.c b/sdk/src/azure/core/az_log.c index a7d4cccc90..bde32f6984 100644 --- a/sdk/src/azure/core/az_log.c +++ b/sdk/src/azure/core/az_log.c @@ -23,7 +23,7 @@ static az_log_message_fn volatile _az_log_message_callback = NULL; // guards against looping past the end of the classification array. // Make sure to update the switch statement whenever new classifications are added. #ifndef AZ_NO_PRECONDITION_CHECKING -AZ_INLINE bool _az_log_classifications_are_valid(az_log_classification const* classifications) +AZ_INLINE bool _az_log_classifications_are_valid(az_log_classification const* const classifications) { if (classifications == NULL) { diff --git a/sdk/src/azure/iot/az_iot_hub_client.c b/sdk/src/azure/iot/az_iot_hub_client.c index 2dd8942ab7..3233e75342 100644 --- a/sdk/src/azure/iot/az_iot_hub_client.c +++ b/sdk/src/azure/iot/az_iot_hub_client.c @@ -37,7 +37,7 @@ AZ_NODISCARD az_result az_iot_hub_client_init( az_iot_hub_client* client, az_span iot_hub_hostname, az_span device_id, - az_iot_hub_client_options const* options) + az_iot_hub_client_options const* const options) { _az_PRECONDITION_NOT_NULL(client); _az_PRECONDITION_VALID_SPAN(iot_hub_hostname, 1, false); @@ -51,7 +51,7 @@ AZ_NODISCARD az_result az_iot_hub_client_init( } AZ_NODISCARD az_result az_iot_hub_client_get_user_name( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, char* mqtt_user_name, size_t mqtt_user_name_size, size_t* out_mqtt_user_name_length) @@ -142,7 +142,7 @@ AZ_NODISCARD az_result az_iot_hub_client_get_user_name( } AZ_NODISCARD az_result az_iot_hub_client_get_client_id( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, char* mqtt_client_id, size_t mqtt_client_id_size, size_t* out_mqtt_client_id_length) diff --git a/sdk/src/azure/iot/az_iot_hub_client_c2d.c b/sdk/src/azure/iot/az_iot_hub_client_c2d.c index e726efcd3b..f87b9950dd 100644 --- a/sdk/src/azure/iot/az_iot_hub_client_c2d.c +++ b/sdk/src/azure/iot/az_iot_hub_client_c2d.c @@ -17,7 +17,7 @@ static const az_span c2d_topic_suffix = AZ_SPAN_LITERAL_FROM_STR("/messages/devicebound/"); AZ_NODISCARD az_result az_iot_hub_client_c2d_parse_received_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span received_topic, az_iot_hub_client_c2d_request* out_request) { diff --git a/sdk/src/azure/iot/az_iot_hub_client_methods.c b/sdk/src/azure/iot/az_iot_hub_client_methods.c index c9794e04d3..68f006b9d4 100644 --- a/sdk/src/azure/iot/az_iot_hub_client_methods.c +++ b/sdk/src/azure/iot/az_iot_hub_client_methods.c @@ -22,7 +22,7 @@ static const az_span methods_response_topic_result = AZ_SPAN_LITERAL_FROM_STR("r static const az_span methods_response_topic_properties = AZ_SPAN_LITERAL_FROM_STR("/?$rid="); AZ_NODISCARD az_result az_iot_hub_client_methods_parse_received_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span received_topic, az_iot_hub_client_method_request* out_request) { @@ -76,7 +76,7 @@ AZ_NODISCARD az_result az_iot_hub_client_methods_parse_received_topic( } AZ_NODISCARD az_result az_iot_hub_client_methods_response_get_publish_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span request_id, uint16_t status, char* mqtt_topic, diff --git a/sdk/src/azure/iot/az_iot_hub_client_sas.c b/sdk/src/azure/iot/az_iot_hub_client_sas.c index 2dc341a59a..80fcfdce4a 100644 --- a/sdk/src/azure/iot/az_iot_hub_client_sas.c +++ b/sdk/src/azure/iot/az_iot_hub_client_sas.c @@ -34,7 +34,7 @@ static const az_span sig_string = AZ_SPAN_LITERAL_FROM_STR(SAS_TOKEN_SIG); static const az_span se_string = AZ_SPAN_LITERAL_FROM_STR(SAS_TOKEN_SE); AZ_NODISCARD az_result az_iot_hub_client_sas_get_signature( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, uint64_t token_expiration_epoch_time, az_span signature, az_span* out_signature) @@ -81,7 +81,7 @@ AZ_NODISCARD az_result az_iot_hub_client_sas_get_signature( } AZ_NODISCARD az_result az_iot_hub_client_sas_get_password( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, uint64_t token_expiration_epoch_time, az_span base64_hmac_sha256_signature, az_span key_name, diff --git a/sdk/src/azure/iot/az_iot_hub_client_telemetry.c b/sdk/src/azure/iot/az_iot_hub_client_telemetry.c index c628cd86cf..e8770efa31 100644 --- a/sdk/src/azure/iot/az_iot_hub_client_telemetry.c +++ b/sdk/src/azure/iot/az_iot_hub_client_telemetry.c @@ -18,8 +18,8 @@ static const az_span telemetry_topic_modules_mid = AZ_SPAN_LITERAL_FROM_STR("/mo static const az_span telemetry_topic_suffix = AZ_SPAN_LITERAL_FROM_STR("/messages/events/"); AZ_NODISCARD az_result az_iot_hub_client_telemetry_get_publish_topic( - az_iot_hub_client const* client, - az_iot_message_properties const* properties, + az_iot_hub_client const* const client, + az_iot_message_properties const* const properties, char* mqtt_topic, size_t mqtt_topic_size, size_t* out_mqtt_topic_length) diff --git a/sdk/src/azure/iot/az_iot_hub_client_twin.c b/sdk/src/azure/iot/az_iot_hub_client_twin.c index b1d7e57755..78bf2d5308 100644 --- a/sdk/src/azure/iot/az_iot_hub_client_twin.c +++ b/sdk/src/azure/iot/az_iot_hub_client_twin.c @@ -28,7 +28,7 @@ static const az_span az_iot_hub_twin_patch_sub_topic = AZ_SPAN_LITERAL_FROM_STR("PATCH/properties/desired/"); AZ_NODISCARD az_result az_iot_hub_client_twin_document_get_publish_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span request_id, char* mqtt_topic, size_t mqtt_topic_size, @@ -67,7 +67,7 @@ AZ_NODISCARD az_result az_iot_hub_client_twin_document_get_publish_topic( } AZ_NODISCARD az_result az_iot_hub_client_twin_patch_get_publish_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span request_id, char* mqtt_topic, size_t mqtt_topic_size, @@ -106,7 +106,7 @@ AZ_NODISCARD az_result az_iot_hub_client_twin_patch_get_publish_topic( } AZ_NODISCARD az_result az_iot_hub_client_twin_parse_received_topic( - az_iot_hub_client const* client, + az_iot_hub_client const* const client, az_span received_topic, az_iot_hub_client_twin_response* out_response) { diff --git a/sdk/src/azure/iot/az_iot_provisioning_client.c b/sdk/src/azure/iot/az_iot_provisioning_client.c index 1b10e646d1..a0a6fc26b3 100644 --- a/sdk/src/azure/iot/az_iot_provisioning_client.c +++ b/sdk/src/azure/iot/az_iot_provisioning_client.c @@ -47,7 +47,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_init( az_span global_device_hostname, az_span id_scope, az_span registration_id, - az_iot_provisioning_client_options const* options) + az_iot_provisioning_client_options const* const options) { _az_PRECONDITION_NOT_NULL(client); _az_PRECONDITION_VALID_SPAN(global_device_hostname, 1, false); @@ -66,7 +66,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_init( // /registrations//api-version= AZ_NODISCARD az_result az_iot_provisioning_client_get_user_name( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, char* mqtt_user_name, size_t mqtt_user_name_size, size_t* out_mqtt_user_name_length) @@ -119,7 +119,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_get_user_name( // AZ_NODISCARD az_result az_iot_provisioning_client_get_client_id( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, char* mqtt_client_id, size_t mqtt_client_id_size, size_t* out_mqtt_client_id_length) @@ -149,7 +149,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_get_client_id( // $dps/registrations/PUT/iotdps-register/?$rid=%s AZ_NODISCARD az_result az_iot_provisioning_client_register_get_publish_topic( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, char* mqtt_topic, size_t mqtt_topic_size, size_t* out_mqtt_topic_length) @@ -182,7 +182,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_register_get_publish_topic( // Topic: $dps/registrations/GET/iotdps-get-operationstatus/?$rid=%s&operationId=%s AZ_NODISCARD az_result az_iot_provisioning_client_query_status_get_publish_topic( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, az_span operation_id, char* mqtt_topic, size_t mqtt_topic_size, @@ -504,7 +504,7 @@ Stage 3: certificate.","timestampUtc":"2020-04-10T05:24:22.4718526Z"} */ AZ_NODISCARD az_result az_iot_provisioning_client_parse_received_topic_and_payload( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, az_span received_topic, az_span received_payload, az_iot_provisioning_client_register_response* out_response) diff --git a/sdk/src/azure/iot/az_iot_provisioning_client_sas.c b/sdk/src/azure/iot/az_iot_provisioning_client_sas.c index 77ac9c9e2d..afdcb8c2de 100644 --- a/sdk/src/azure/iot/az_iot_provisioning_client_sas.c +++ b/sdk/src/azure/iot/az_iot_provisioning_client_sas.c @@ -31,7 +31,7 @@ static const az_span skn_string = AZ_SPAN_LITERAL_FROM_STR(SAS_TOKEN_SKN); static const az_span se_string = AZ_SPAN_LITERAL_FROM_STR(SAS_TOKEN_SE); AZ_NODISCARD az_result az_iot_provisioning_client_sas_get_signature( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, uint64_t token_expiration_epoch_time, az_span signature, az_span* out_signature) @@ -69,7 +69,7 @@ AZ_NODISCARD az_result az_iot_provisioning_client_sas_get_signature( } AZ_NODISCARD az_result az_iot_provisioning_client_sas_get_password( - az_iot_provisioning_client const* client, + az_iot_provisioning_client const* const client, az_span base64_hmac_sha256_signature, uint64_t token_expiration_epoch_time, az_span key_name, diff --git a/sdk/src/azure/platform/az_curl.c b/sdk/src/azure/platform/az_curl.c index a116e19bc8..4cc381f03f 100644 --- a/sdk/src/azure/platform/az_curl.c +++ b/sdk/src/azure/platform/az_curl.c @@ -108,7 +108,7 @@ static AZ_NODISCARD az_result _az_span_append_header_to_buffer( } static AZ_NODISCARD az_result -_az_http_client_curl_slist_append(struct curl_slist** ref_list, char const* str) +_az_http_client_curl_slist_append(struct curl_slist** ref_list, char const* const str) { _az_PRECONDITION_NOT_NULL(ref_list); _az_PRECONDITION_NOT_NULL(str); @@ -216,7 +216,7 @@ _az_http_client_curl_add_expect_header(CURL* ref_curl, struct curl_slist** ref_l * @return az_result */ static AZ_NODISCARD az_result -_az_http_client_curl_build_headers(az_http_request const* request, struct curl_slist** ref_headers) +_az_http_client_curl_build_headers(az_http_request const* const request, struct curl_slist** ref_headers) { _az_PRECONDITION_NOT_NULL(request); @@ -316,7 +316,7 @@ static AZ_NODISCARD az_result _az_http_client_curl_send_delete_request(CURL* ref * handles POST request. It handles seting up a body for request */ static AZ_NODISCARD az_result -_az_http_client_curl_send_post_request(CURL* ref_curl, az_http_request const* request) +_az_http_client_curl_send_post_request(CURL* ref_curl, az_http_request const* const request) { _az_PRECONDITION_NOT_NULL(ref_curl); _az_PRECONDITION_NOT_NULL(request); @@ -401,7 +401,7 @@ static int32_t _az_http_client_curl_upload_read_callback( * As of CURL 7.12.1 CURLOPT_PUT is deprecated. PUT requests should be made using CURLOPT_UPLOAD */ static AZ_NODISCARD az_result -_az_http_client_curl_send_upload_request(CURL* ref_curl, az_http_request const* request) +_az_http_client_curl_send_upload_request(CURL* ref_curl, az_http_request const* const request) { _az_PRECONDITION_NOT_NULL(ref_curl); _az_PRECONDITION_NOT_NULL(request); @@ -439,7 +439,7 @@ _az_http_client_curl_send_upload_request(CURL* ref_curl, az_http_request const* static AZ_NODISCARD az_result _az_http_client_curl_setup_headers( CURL* ref_curl, struct curl_slist** ref_list, - az_http_request const* request) + az_http_request const* const request) { _az_PRECONDITION_NOT_NULL(ref_curl); _az_PRECONDITION_NOT_NULL(request); @@ -466,7 +466,7 @@ static AZ_NODISCARD az_result _az_http_client_curl_setup_headers( * @return az_result */ static AZ_NODISCARD az_result -_az_http_client_curl_setup_url(CURL* ref_curl, az_http_request const* request) +_az_http_client_curl_setup_url(CURL* ref_curl, az_http_request const* const request) { _az_PRECONDITION_NOT_NULL(ref_curl); _az_PRECONDITION_NOT_NULL(request); @@ -541,7 +541,7 @@ _az_http_client_curl_setup_response_redirect(CURL* ref_curl, az_http_response* r */ static AZ_NODISCARD az_result _az_http_client_curl_send_request_impl_process( CURL* ref_curl, - az_http_request const* request, + az_http_request const* const request, az_http_response* ref_response) { _az_PRECONDITION_NOT_NULL(ref_curl); @@ -598,7 +598,7 @@ static AZ_NODISCARD az_result _az_http_client_curl_send_request_impl_process( * @return az_result */ AZ_NODISCARD az_result -az_http_client_send_request(az_http_request const* request, az_http_response* ref_response) +az_http_client_send_request(az_http_request const* const request, az_http_response* ref_response) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(ref_response); diff --git a/sdk/src/azure/platform/az_nohttp.c b/sdk/src/azure/platform/az_nohttp.c index b4c830a48e..32da270c40 100644 --- a/sdk/src/azure/platform/az_nohttp.c +++ b/sdk/src/azure/platform/az_nohttp.c @@ -15,7 +15,7 @@ * @retval other Failure. */ AZ_NODISCARD az_result -az_http_client_send_request(az_http_request const* request, az_http_response* ref_response) +az_http_client_send_request(az_http_request const* const request, az_http_response* ref_response) { (void)request; (void)ref_response; diff --git a/sdk/src/azure/storage/az_storage_blobs_blob_client.c b/sdk/src/azure/storage/az_storage_blobs_blob_client.c index 5334c51315..0a84baa879 100644 --- a/sdk/src/azure/storage/az_storage_blobs_blob_client.c +++ b/sdk/src/azure/storage/az_storage_blobs_blob_client.c @@ -58,7 +58,7 @@ AZ_NODISCARD az_result az_storage_blobs_blob_client_init( az_storage_blobs_blob_client* out_client, az_span endpoint, void* credential, - az_storage_blobs_blob_client_options const* options) + az_storage_blobs_blob_client_options const* const options) { _az_PRECONDITION_NOT_NULL(out_client); _az_PRECONDITION_NOT_NULL(options); @@ -132,7 +132,7 @@ AZ_NODISCARD az_result az_storage_blobs_blob_client_init( AZ_NODISCARD az_result az_storage_blobs_blob_upload( az_storage_blobs_blob_client* ref_client, az_span content, /* Buffer of content*/ - az_storage_blobs_blob_upload_options const* options, + az_storage_blobs_blob_upload_options const* const options, az_http_response* ref_response) { From dc6924a82ce729b5b50600ac9a3c6eaa427f8545 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Wed, 23 Sep 2020 17:40:20 -0700 Subject: [PATCH 2/2] Auto-format the files. --- sdk/src/azure/core/az_context.c | 6 ++++-- sdk/src/azure/core/az_http_request.c | 6 ++++-- sdk/src/azure/core/az_json_token.c | 12 ++++++++---- sdk/src/azure/core/az_json_writer.c | 3 ++- sdk/src/azure/platform/az_curl.c | 5 +++-- 5 files changed, 21 insertions(+), 11 deletions(-) diff --git a/sdk/src/azure/core/az_context.c b/sdk/src/azure/core/az_context.c index f8ac6cb7fa..d5a89710ae 100644 --- a/sdk/src/azure/core/az_context.c +++ b/sdk/src/azure/core/az_context.c @@ -63,8 +63,10 @@ az_context_create_with_expiration(az_context const* const parent, int64_t expira return (az_context){ ._internal = { .parent = parent, .expiration = expiration } }; } -AZ_NODISCARD az_context -az_context_create_with_value(az_context const* const parent, void const* const key, void const* const value) +AZ_NODISCARD az_context az_context_create_with_value( + az_context const* const parent, + void const* const key, + void const* const value) { _az_PRECONDITION_NOT_NULL(parent); _az_PRECONDITION_NOT_NULL(key); diff --git a/sdk/src/azure/core/az_http_request.c b/sdk/src/azure/core/az_http_request.c index 72d49dfd69..8b64d01861 100644 --- a/sdk/src/azure/core/az_http_request.c +++ b/sdk/src/azure/core/az_http_request.c @@ -183,7 +183,8 @@ az_http_request_get_method(az_http_request const* const request, az_http_method* return AZ_OK; } -AZ_NODISCARD az_result az_http_request_get_url(az_http_request const* const request, az_span* out_url) +AZ_NODISCARD az_result +az_http_request_get_url(az_http_request const* const request, az_span* out_url) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(out_url); @@ -193,7 +194,8 @@ AZ_NODISCARD az_result az_http_request_get_url(az_http_request const* const requ return AZ_OK; } -AZ_NODISCARD az_result az_http_request_get_body(az_http_request const* const request, az_span* out_body) +AZ_NODISCARD az_result +az_http_request_get_body(az_http_request const* const request, az_span* out_body) { _az_PRECONDITION_NOT_NULL(request); _az_PRECONDITION_NOT_NULL(out_body); diff --git a/sdk/src/azure/core/az_json_token.c b/sdk/src/azure/core/az_json_token.c index fca8ad8cd2..087da8aaed 100644 --- a/sdk/src/azure/core/az_json_token.c +++ b/sdk/src/azure/core/az_json_token.c @@ -243,7 +243,8 @@ AZ_NODISCARD bool az_json_token_is_text_equal( return az_span_size(expected_text) == 0; } -AZ_NODISCARD az_result az_json_token_get_boolean(az_json_token const* const json_token, bool* out_value) +AZ_NODISCARD az_result +az_json_token_get_boolean(az_json_token const* const json_token, bool* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -498,7 +499,8 @@ az_json_token_get_uint32(az_json_token const* const json_token, uint32_t* out_va return az_span_atou32(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_int64(az_json_token const* const json_token, int64_t* out_value) +AZ_NODISCARD az_result +az_json_token_get_int64(az_json_token const* const json_token, int64_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -532,7 +534,8 @@ AZ_NODISCARD az_result az_json_token_get_int64(az_json_token const* const json_t return az_span_atoi64(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_int32(az_json_token const* const json_token, int32_t* out_value) +AZ_NODISCARD az_result +az_json_token_get_int32(az_json_token const* const json_token, int32_t* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); @@ -566,7 +569,8 @@ AZ_NODISCARD az_result az_json_token_get_int32(az_json_token const* const json_t return az_span_atoi32(az_span_slice(scratch, 0, _az_span_diff(remainder, scratch)), out_value); } -AZ_NODISCARD az_result az_json_token_get_double(az_json_token const* const json_token, double* out_value) +AZ_NODISCARD az_result +az_json_token_get_double(az_json_token const* const json_token, double* out_value) { _az_PRECONDITION_NOT_NULL(json_token); _az_PRECONDITION_NOT_NULL(out_value); diff --git a/sdk/src/azure/core/az_json_writer.c b/sdk/src/azure/core/az_json_writer.c index 80792108ff..b59d7b3307 100644 --- a/sdk/src/azure/core/az_json_writer.c +++ b/sdk/src/azure/core/az_json_writer.c @@ -136,7 +136,8 @@ static AZ_NODISCARD bool _az_is_appending_value_valid(az_json_writer const* cons } #ifndef AZ_NO_PRECONDITION_CHECKING -static AZ_NODISCARD bool _az_is_appending_property_name_valid(az_json_writer const* const json_writer) +static AZ_NODISCARD bool _az_is_appending_property_name_valid( + az_json_writer const* const json_writer) { _az_PRECONDITION_NOT_NULL(json_writer); diff --git a/sdk/src/azure/platform/az_curl.c b/sdk/src/azure/platform/az_curl.c index d831bfb522..df36148654 100644 --- a/sdk/src/azure/platform/az_curl.c +++ b/sdk/src/azure/platform/az_curl.c @@ -215,8 +215,9 @@ _az_http_client_curl_add_expect_header(CURL* ref_curl, struct curl_slist** ref_l * @param ref_headers list of headers in curl specific list * @return az_result */ -static AZ_NODISCARD az_result -_az_http_client_curl_build_headers(az_http_request const* const request, struct curl_slist** ref_headers) +static AZ_NODISCARD az_result _az_http_client_curl_build_headers( + az_http_request const* const request, + struct curl_slist** ref_headers) { _az_PRECONDITION_NOT_NULL(request);