-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add missing private link fields for CDN version 2020-04-15 #9858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Staging] Swagger Validation Report
❌ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
fce9639 to
cc107fb
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akning-ms please review this. From what I can tell, the check failures are all because this is a breaking change, but we haven't yet released this API version. |
|
LGTM, I will merge if ARM sign it off, @NullMDR for check python SDK failure |
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akning-ms The python codegen failure is a known issue for incorrect config. We've fixed it today. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward. |
|
Hi @lsmith130 Can you fix ModelValidation validation failure? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
88c2c8e to
721f9b8
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add missing private link fields for CDN version 2020-04-15. * Fix examples for CDN endpoint get, list, and update in 2020-04-15 * Fix CDN Endpoints_Update example.
Please note that this change modifies an API version that is not yet in use by any customers.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.