Added SecurityProfile to support Host Encryption for VM and Scaleset resources #9366

hari-bodicherla · 2020-05-06T23:57:41Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-05-06T23:57:56Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-05-06T23:58:28Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-05-06T23:59:36Z

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-06T23:59:44Z

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-06T23:59:45Z

azure-sdk-for-python

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-06T23:59:46Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 3c1fdb5 with merge commit f2350e59b036e698de15195d8fc2e8cc02783af2. SDK Automation 13.0.17.20200526.1
⚠️compute/mgmt/2015-06-15 [View full logs]
- compute.mgmt.2015-06-15.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2016-03-30 [View full logs]
- compute.mgmt.2016-03-30.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2017-03-30 [View full logs]
- compute.mgmt.2017-03-30.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2017-09-01 [View full logs]
- compute.mgmt.2017-09-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2017-12-01 [View full logs]
- compute.mgmt.2017-12-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2018-04-01 [View full logs]
- compute.mgmt.2018-04-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2018-06-01 [View full logs]
- compute.mgmt.2018-06-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2018-10-01 [View full logs]
- compute.mgmt.2018-10-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2019-03-01 [View full logs]
- compute.mgmt.2019-03-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2019-07-01 [View full logs]
- compute.mgmt.2019-07-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️compute/mgmt/2019-12-01 [View full logs]
- compute.mgmt.2019-12-01.zip
```
No run LangAfterScript
No file is changed.
```
⚠️containerservice/mgmt/2016-03-30 [View full logs]
- containerservice.mgmt.2016-03-30.zip
```
No run LangAfterScript
No file is changed.
```
⚠️containerservice/mgmt/2016-09-30 [View full logs]
- containerservice.mgmt.2016-09-30.zip
```
No run LangAfterScript
No file is changed.
```
⚠️containerservice/mgmt/2017-01-31 [View full logs]
- containerservice.mgmt.2017-01-31.zip
```
No run LangAfterScript
No file is changed.
```
⚠️preview/compute/mgmt/2016-04-30-preview [View full logs]
- preview.compute.mgmt.2016-04-30-preview.zip
```
No run LangAfterScript
No file is changed.
```
⚠️preview/containerservice/mgmt/2015-11-01-preview [View full logs]
- preview.containerservice.mgmt.2015-11-01-preview.zip
```
No run LangAfterScript
No file is changed.
```

openapi-sdkautomation · 2020-05-06T23:59:47Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 3c1fdb5 with merge commit f2350e59b036e698de15195d8fc2e8cc02783af2. SDK Automation 13.0.17.20200526.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Compute [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Compute.36.1.0.nupkg
- Microsoft.Azure.Management.Compute.36.1.0.snupkg
```
No run LangAfterScript
```

openapi-sdkautomation · 2020-05-06T23:59:47Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-06T23:59:50Z

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-05-07T01:22:23Z

Azure Pipelines successfully started running 1 pipeline(s).

hari-bodicherla · 2020-05-13T04:03:27Z

@majastrz , Could you review and approve the PR from ARM side as we need sign off from ARM since we are adding a new definition here. Thanks

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json

majastrz · 2020-05-13T19:43:53Z

@majastrz , Could you review and approve the PR from ARM side as we need sign off from ARM since we are adding a new definition here. Thanks

The current on-call (@chiragg4u) can review from ARM side. (It's a weekly rotation.)

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json

chiragg4u

🕐

azure-pipelines · 2020-05-15T01:01:06Z

Azure Pipelines successfully started running 1 pipeline(s).

hari-bodicherla · 2020-05-19T19:32:51Z

@hyonholee , I have resolved the conflicts, Can you please review and approve the PR. I will ping other reviewers too . Thanks

azure-pipelines · 2020-05-19T19:47:02Z

Comment was made before the most recent commit for PR 9366 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-05-19T19:53:20Z

Comment was made before the most recent commit for PR 9366 in repo Azure/azure-rest-api-specs

MS-syh2qs · 2020-05-28T19:18:00Z

@hari-bodicherla Please resolve the conflicts

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json

openapi-pipeline-app · 2020-05-29T22:43:39Z

[Staging] Swagger Validation Report

️🔄~[Staging] BreakingChange [Detail]

_{Posted by Swagger Pipeline}

azure-pipelines · 2020-05-29T22:43:51Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-05-29T22:45:17Z

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-05-29T23:38:57Z

Pull request contains merge conflicts.

azure-pipelines · 2020-05-29T23:41:40Z

Azure Pipelines successfully started running 1 pipeline(s).

…azure-rest-api-specs into compute-2020-06

azure-pipelines · 2020-05-30T00:02:28Z

Azure Pipelines successfully started running 1 pipeline(s).

Sandido · 2020-06-01T18:56:33Z

Looks like the number of Files Changed is now 0. Looks like your previous changes were lost. Please update this PR with all your changes.

hari-bodicherla requested a review from hyonholee as a code owner May 6, 2020 23:57

openapi-assignment-bot bot assigned fengzhou-msft May 6, 2020

hari-bodicherla requested a review from smotwani May 6, 2020 23:58

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 7, 2020

openapi-sdkautomation bot mentioned this pull request May 7, 2020

[AutoPR @azure/arm-compute] Added SecurityProfile to support Host Encryption for VM and Scaleset resources AzureSDKAutomation/azure-sdk-for-js#1197

Open

hyonholee force-pushed the compute-2020-06 branch from 0924085 to b31fd02 Compare May 11, 2020 22:13

hari-bodicherla requested review from avinashakka and majastrz May 13, 2020 03:27

hyonholee reviewed May 13, 2020

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Outdated Show resolved Hide resolved

hari-bodicherla removed the request for review from majastrz May 14, 2020 04:41

chiragg4u reviewed May 14, 2020

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Outdated Show resolved Hide resolved

chiragg4u suggested changes May 14, 2020

View reviewed changes

hari-bodicherla requested review from chiragg4u and hyonholee May 15, 2020 02:16

chiragg4u approved these changes May 15, 2020

View reviewed changes

hari-bodicherla added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 19, 2020

MS-syh2qs requested review from MS-syh2qs and removed request for MS-syh2qs May 19, 2020 19:39

hyonholee force-pushed the compute-2020-06 branch from 60ad3dc to 18dc89f Compare May 26, 2020 00:09

hari-bodicherla mentioned this pull request May 27, 2020

Generated SDK modules and recorded tests for enabling encryption at host property in Security Profile. Azure/azure-sdk-for-net#12329

Closed

smotwani reviewed May 29, 2020

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Outdated Show resolved Hide resolved

smotwani reviewed May 29, 2020

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Outdated Show resolved Hide resolved

Merge branch 'compute-2020-06' into compute-2020-06

a19a975

updated code

b8aa61d

Merge branch 'compute-2020-06' into compute-2020-06

3c1fdb5

hari-bodicherla added 2 commits May 29, 2020 16:59

resolved prettier fix

d7831b7

Merge branch 'compute-2020-06' of https://github.com/hari-bodicherla/…

ea8b141

…azure-rest-api-specs into compute-2020-06

hari-bodicherla added Do Not Merge DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval Do Not Merge labels May 30, 2020

hari-bodicherla merged commit ea8b141 into Azure:compute-2020-06 Jun 1, 2020

hari-bodicherla mentioned this pull request Jun 1, 2020

Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 #9666

Merged

2 tasks

ramankumarlive mentioned this pull request Jun 1, 2020

Cli support for Encryption of cache & data-in-transit for OS/Data disks and temp disks for VM & VMSS Azure/azure-cli#13559

Closed

Added SecurityProfile to support Host Encryption for VM and Scaleset resources #9366

Added SecurityProfile to support Host Encryption for VM and Scaleset resources #9366

Uh oh!

Conversation

hari-bodicherla commented May 6, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

azuresdkci commented May 6, 2020

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-trenton

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

azure-pipelines bot commented May 7, 2020

Uh oh!

hari-bodicherla commented May 13, 2020

Uh oh!

Uh oh!

majastrz commented May 13, 2020

Uh oh!

Uh oh!

chiragg4u left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented May 15, 2020

Uh oh!

hari-bodicherla commented May 19, 2020

Uh oh!

azure-pipelines bot commented May 19, 2020

Uh oh!

azure-pipelines bot commented May 19, 2020

Uh oh!

MS-syh2qs commented May 28, 2020

Uh oh!

Uh oh!

Uh oh!

openapi-pipeline-app bot commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented May 29, 2020

Uh oh!

openapi-sdkautomation bot commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation

Uh oh!

azure-pipelines bot commented May 29, 2020

Uh oh!

azure-pipelines bot commented May 29, 2020

Uh oh!

azure-pipelines bot commented May 30, 2020

Uh oh!

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 6, 2020 •

edited

Loading

openapi-pipeline-app bot commented May 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 29, 2020 •

edited

Loading