Adding ExtensionsTimeBudget to new Api Version #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hyonholee
reviewed
May 6, 2020
...er/Microsoft.Compute/stable/2020-06-01/examples/CreateAScaleSetWithExtensionsTimeBudget.json
Outdated
Show resolved
Hide resolved
hyonholee
reviewed
May 6, 2020
...anager/Microsoft.Compute/stable/2020-06-01/examples/CreateAVmInWithExtensionsTimeBudget.json
Outdated
Show resolved
Hide resolved
hyonholee
requested changes
May 6, 2020
Contributor
hyonholee
left a comment
hyonholee
left a comment
There was a problem hiding this comment.
Please add the links of new example files to compute.json.
Member
|
Since this PR is not targeting master branch but a dev branch of compute (I assume), I will then merge this PR as long as @hyonholee approves. |
hyonholee
force-pushed
the
compute-2020-06
branch
from
0924085 to
b31fd02
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Hi @kamusta-msft @hyonholee any updates? |
hyonholee
force-pushed
the
compute-2020-06
branch
from
b31fd02 to
60ad3dc
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hyonholee
added
the
WaitForARMFeedback
hyonholee
force-pushed
the
compute-2020-06
branch
from
60ad3dc to
18dc89f
Compare
Contributor
|
Please resolve the conflict |
Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget
[Staging] Swagger Validation Report️~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
hari-bodicherla
force-pushed
the
compute-2020-06
branch
from
f904c0e to
aec83a3
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@ravbhatnagar Could you review this PR? |
pilor
added
ARMSignedOff
Member
|
Hi @hyonholee could you please approve? I would merge this once you approved this, thanks! |
ArcturusZhang
approved these changes
Jun 8, 2020
Sandido
reviewed
Jun 8, 2020
...anager/Microsoft.Compute/stable/2020-06-01/examples/CreateAVmInWithExtensionsTimeBudget.json
Show resolved
Hide resolved
Sandido
suggested changes
Jun 8, 2020
Contributor
Sandido
left a comment
Sandido
left a comment
There was a problem hiding this comment.
See my comment about removing the 'In' string from the file name.
|
Azure Pipelines successfully started running 1 pipeline(s). |
hyonholee
approved these changes
Jun 10, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ArcturusZhang
pushed a commit
that referenced
this pull request
Jun 23, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (Azure#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (Azure#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (Azure#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (Azure#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (Azure#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (Azure#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (Azure#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (Azure#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed commits:
[f0151eb78] updated with extensionsTimeBudget
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.