From acbb4130f0f70621bce68c37dca90a1867857711 Mon Sep 17 00:00:00 2001 From: Junbo Wang Date: Sun, 26 Apr 2020 16:21:58 +0800 Subject: [PATCH 1/3] Adding 200 response in CreateOrUpdate api --- .../examples/CreateOrUpdate.json | 29 +++++++++++++++++++ .../preview/2018-03-01-preview/signalr.json | 6 ++++ 2 files changed, 35 insertions(+) diff --git a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json index 2446709ef47b..442a6a88f82b 100644 --- a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json +++ b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json @@ -20,6 +20,35 @@ "resourceName": "mySignalRService" }, "responses": { + "200": { + "body": { + "sku": { + "name": "Standard_S1", + "tier": "Standard", + "size": "S1", + "capacity": 1 + }, + "properties": { + "provisioningState": "Succeeded", + "externalIP": "10.0.0.1", + "hostName": "myservice.service.signalr.net", + "publicPort": 5001, + "serverPort": 5002, + "version": "1.0-preview", + "hostNamePrefix": null + }, + "location": "eastus", + "tags": { + "key1": "value1" + }, + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService", + "name": "mySignalRService", + "type": "Microsoft.SignalRService/SignalR" + }, + "headers": { + "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult..." + } + }, "201": { "body": { "sku": { diff --git a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/signalr.json b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/signalr.json index 0a661c94b9f3..d8c5408c9640 100644 --- a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/signalr.json +++ b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/signalr.json @@ -308,6 +308,12 @@ } ], "responses": { + "200": { + "description": "Success. The response describes a SignalR service.", + "schema": { + "$ref": "#/definitions/SignalRResource" + } + }, "201": { "description": "Created. The response describes the new service and contains a Location header to query the operation result.", "schema": { From b2a52e1e13420ed2c0d48737a0b662cede18f51e Mon Sep 17 00:00:00 2001 From: Junbo Wang Date: Sun, 26 Apr 2020 16:25:54 +0800 Subject: [PATCH 2/3] Update example --- .../2018-03-01-preview/examples/CreateOrUpdate.json | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json index 442a6a88f82b..3a92226cd0a1 100644 --- a/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json +++ b/specification/signalr/resource-manager/Microsoft.SignalRService/preview/2018-03-01-preview/examples/CreateOrUpdate.json @@ -32,8 +32,8 @@ "provisioningState": "Succeeded", "externalIP": "10.0.0.1", "hostName": "myservice.service.signalr.net", - "publicPort": 5001, - "serverPort": 5002, + "publicPort": 443, + "serverPort": 443, "version": "1.0-preview", "hostNamePrefix": null }, @@ -44,9 +44,6 @@ "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService", "name": "mySignalRService", "type": "Microsoft.SignalRService/SignalR" - }, - "headers": { - "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult..." } }, "201": { From 198a4c1ca9802a3f23ad98e48f092225bb4a6f83 Mon Sep 17 00:00:00 2001 From: Junbo Wang Date: Wed, 13 May 2020 08:34:58 +0800 Subject: [PATCH 3/3] Empty commit to trigger build --- specification/signalr/resource-manager/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/signalr/resource-manager/readme.md b/specification/signalr/resource-manager/readme.md index 356ff90245d8..dd35a4918a1f 100644 --- a/specification/signalr/resource-manager/readme.md +++ b/specification/signalr/resource-manager/readme.md @@ -40,7 +40,7 @@ directive: - suppress: EnumInsteadOfBoolean from: signalr.json where: $.definitions.Dimension.properties.toBeExportedForShoebox - reason: The boolean properties 'toBeExportedForShoebox' is defined by Geneva metrics + reason: The boolean properties 'toBeExportedForShoebox' is defined by Geneva metrics. - suppress: PutRequestResponseScheme from: signalr.json where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SignalRService/signalR/{resourceName}"].put