Skip to content

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 #8723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2020
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 #8723

merged 7 commits into from
Mar 25, 2020

Conversation

@rezmicrosoft-zz
Copy link
Contributor

@rezmicrosoft-zz rezmicrosoft-zz commented Mar 16, 2020 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

The private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/1156

Contribution checklist:

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e8f6c5d with merge commit 85cdcfb. SDK Automation 13.0.17.20200320.2
  • ️✔️azure-mgmt-imagebuilder [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 15.136% size of original (original: 19985 chars, delta: 3025 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model Operation has a new parameter is_data_action
[ChangeLog]   - Model ImageTemplateVmProfile has a new parameter os_disk_size_gb
[ChangeLog]   - Model ImageTemplateVmProfile has a new parameter vnet_config
[ChangeLog]   - Model ImageTemplatePlatformImageSource has a new parameter plan_info
[ChangeLog]   - Model ImageTemplateSharedImageDistributor has a new parameter exclude_from_latest
[ChangeLog]   - Model ImageTemplateSharedImageDistributor has a new parameter storage_account_type
[ChangeLog]   - Added operation VirtualMachineImageTemplatesOperations.cancel

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e8f6c5d with merge commit 85cdcfb. SDK Automation 13.0.17.20200320.2 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e8f6c5d with merge commit 85cdcfb. SDK Automation 13.0.17.20200320.2
  • ⚠️preview/virtualmachineimagebuilder/mgmt/2018-02-01-preview [Logs]  
      No file is changed.
    • ⚠️preview/virtualmachineimagebuilder/mgmt/2019-02-01-preview [Logs]  
        No file is changed.
      • ⚠️preview/virtualmachineimagebuilder/mgmt/2019-05-01-preview [Logs]  
          No file is changed.

        @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 16, 2020
        Closed
        @azuresdkci
        Copy link
        Contributor

        azuresdkci commented Mar 16, 2020

        Can one of the admins verify this patch?

        @rezmicrosoft-zz
        Copy link
        Contributor Author

        rezmicrosoft-zz commented Mar 16, 2020

        The private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/1156

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Mar 16, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @njuCZ
        Copy link
        Contributor

        njuCZ commented Mar 17, 2020

        Prettier check of file ListImageTemplatesByRg.json failed, please fix it @rezmicrosoft

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Mar 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @rezmicrosoft-zz
        Copy link
        Contributor Author

        rezmicrosoft-zz commented Mar 17, 2020 •
        edited
        Loading

        Prettier check of file ListImageTemplatesByRg.json failed, please fix it @rezmicrosoft

        Prettier check has been fixed.

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Mar 18, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @njuCZ njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 19, 2020
        ravbhatnagar
        ravbhatnagar approved these changes Mar 20, 2020
        View reviewed changes
        Copy link
        Contributor

        @ravbhatnagar ravbhatnagar left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        SIgning off from ARM side.

        @njuCZ
        Copy link
        Contributor

        njuCZ commented Mar 23, 2020

        @ravbhatnagar If arm team has signed off this PR, please remove the label waitforarmfeedback and add armsignedoff label

        @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 23, 2020
        @njuCZ njuCZ merged commit 85cdcfb into Azure:master Mar 25, 2020
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        @rezmicrosoft-zz @00Kai0
        [Hub Generated] Review request for Microsoft.VirtualMachineImages to …
        29cd8ed 
        …add version stable/2020-02-14 (Azure#8723)

* Adds base for updating Microsoft.VirtualMachineImages from version preview/2019-05-01-preview to version 2020-02-14

* Updates readme

* Updates API version in new specs and examples

* Add new stable version 2020-02-14, private PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/1156

* add cancel example 202

* run prettier

* run prettier on Windows
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

        Reviewers

        2 more reviewers

        @njuCZ njuCZ njuCZ approved these changes

        @ravbhatnagar ravbhatnagar ravbhatnagar approved these changes

        Reviewers whose approvals may not affect merge requirements

        Assignees

        @njuCZ njuCZ

        Labels

        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

        Projects

        None yet

        Milestone

        No milestone

        Development

        Successfully merging this pull request may close these issues.

        5 participants

        @rezmicrosoft-zz @azuresdkci @njuCZ @ravbhatnagar @rezmicrosoft