Skip to content

Add a new api-version for storagesync #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raych1 merged 1 commit into from
Jan 12, 2020
Merged

Add a new api-version for storagesync #8120

raych1 merged 1 commit into from
Jan 12, 2020

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jan 10, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 30ec96c with merge commit 0909187. SDK Automation 13.0.17.20191226.1
  • ⚠️sdk/storagesync/mgmt-v2019_02_01 [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[695,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,88] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[704,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListByResourceGroupHeaders>>
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[785,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListBySubscriptionHeaders>>
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[151,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,84] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1042,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,89] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[171,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,91] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[143,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,25] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,83] cannot find symbol
[mvn]   symbol: class ServiceResponse
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storagesync: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[695,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,88] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[704,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListByResourceGroupHeaders>>
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[785,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListBySubscriptionHeaders>>
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[151,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,84] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1042,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,89] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[171,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,91] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[143,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,25] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,83] cannot find symbol
[mvn] [ERROR]   symbol: class ServiceResponse
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 30ec96c with merge commit 0909187. SDK Automation 13.0.17.20191226.1 
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 30ec96c with merge commit 0909187. SDK Automation 13.0.17.20191226.1 
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 10, 2020
    Closed
    @ArcturusZhang
    Copy link
    Member Author

    ArcturusZhang commented Jan 10, 2020

    Hi @raych1 the java sdk generation is apparently stuck, and my pr does not modify anything with java configuration. I suggest we just ignore that failure and merge this.

    @raych1 raych1 merged commit 0909187 into Azure:master Jan 12, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @raych1 raych1 raych1 approved these changes

    @ankushbindlish2 ankushbindlish2 Awaiting requested review from ankushbindlish2

    Assignees

    @raych1 raych1

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @ArcturusZhang @raych1