From 8d0ca033b3c8c36fce6fdfbdddf271cc934d14ee Mon Sep 17 00:00:00 2001 From: Jiejiong Wu Date: Wed, 16 Oct 2019 16:11:58 -0700 Subject: [PATCH 1/5] add additional properties to template and examples --- .../stable/2019-09-01/azureFirewall.json | 19 +- .../2019-09-01/examples/AzureFirewallGet.json | 5 +- ...reFirewallGetWithAdditionalProperties.json | 179 +++++++ .../examples/AzureFirewallGetWithZones.json | 5 +- .../AzureFirewallListByResourceGroup.json | 8 +- .../AzureFirewallListBySubscription.json | 8 +- .../2019-09-01/examples/AzureFirewallPut.json | 8 +- .../examples/AzureFirewallPutInHub.json | 2 +- ...reFirewallPutWithAdditionalProperties.json | 506 ++++++++++++++++++ .../examples/AzureFirewallPutWithZones.json | 8 +- 10 files changed, 732 insertions(+), 16 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json index 80d650cd7181..c10d2454dad1 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json @@ -126,6 +126,9 @@ }, "Get Azure Firewall With Zones": { "$ref": "./examples/AzureFirewallGetWithZones.json" + }, + "Get Azure Firewall With Additional Properties": { + "$ref": "./examples/AzureFirewallGetWithAdditionalProperties.json" } } }, @@ -189,6 +192,9 @@ }, "Create Azure Firewall in virtual Hub": { "$ref": "./examples/AzureFirewallPutInHub.json" + }, + "Create Azure Firewall With Additional Properties": { + "$ref": "./examples/AzureFirewallPutWithAdditionalProperties.json" } }, "x-ms-long-running-operation": true, @@ -450,6 +456,10 @@ "sku": { "description": "The Azure Firewall Resource SKU.", "$ref": "#/definitions/AzureFirewallSku" + }, + "additionalProperties": { + "$ref": "#/definitions/AzureFirewallAdditionalProperties", + "description": "The additional properties used to further config this azure firewall " } }, "description": "Properties of the Azure Firewall." @@ -510,6 +520,13 @@ "modelAsString": true } }, + "AzureFirewallAdditionalProperties": { + "type": "object", + "additionalProperties": { + "type": "string" + }, + "description": "The additional properties of azure firewall" + }, "AzureFirewallApplicationRuleCollectionPropertiesFormat": { "properties": { "priority": { @@ -958,4 +975,4 @@ "description": "SKU of an Azure Firewall." } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json index 5004bf23be56..cde2c3c32ea8 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json @@ -167,9 +167,10 @@ ] } } - ] + ], + "additionalProperties": {} } } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json new file mode 100644 index 000000000000..d4d908a68615 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json @@ -0,0 +1,179 @@ +{ + "parameters": { + "api-version": "2019-09-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "azureFirewallName": "azurefirewall" + }, + "responses": { + "200": { + "body": { + "name": "azurefirewall", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall", + "type": "Microsoft.Network/azureFirewalls", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "location": "West US", + "zones": [], + "tags": { + "key1": "value1" + }, + "properties": { + "provisioningState": "Succeeded", + "sku": { + "name": "AZFW_VNet", + "tier": "Standard" + }, + "threatIntelMode": "Alert", + "ipConfigurations": [ + { + "name": "azureFirewallIpConfiguration", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewallgw/ipConfigurations/azureFirewallIpConfiguration", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "properties": { + "provisioningState": "Succeeded", + "privateIPAddress": "10.0.0.0", + "subnet": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet" + }, + "publicIPAddress": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName" + } + } + } + ], + "applicationRuleCollections": [ + { + "name": "apprulecoll", + "properties": { + "priority": 110, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "rule1", + "description": "Deny inbound rule", + "protocols": [ + { + "protocolType": "Https", + "port": 443 + } + ], + "targetFqdns": [ + "www.test.com" + ], + "sourceAddresses": [ + "216.58.216.164", + "10.0.0.0/24" + ] + } + ] + } + } + ], + "natRuleCollections": [ + { + "name": "natrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Dnat" + }, + "rules": [ + { + "name": "DNAT-HTTPS-traffic", + "description": "D-NAT all outbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "443" + ], + "protocols": [ + "TCP" + ], + "translatedAddress": "1.2.3.5", + "translatedPort": "8443" + }, + { + "name": "DNAT-HTTP-traffic-With-FQDN", + "description": "D-NAT all inbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "80" + ], + "protocols": [ + "TCP" + ], + "translatedFqdn": "internalhttpserver", + "translatedPort": "880" + } + ] + } + } + ], + "networkRuleCollections": [ + { + "name": "netrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "L4-traffic", + "description": "Block traffic based on source IPs and ports", + "sourceAddresses": [ + "192.168.1.1-192.168.1.12", + "10.1.4.12-10.1.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationAddresses": [ + "*" + ], + "protocols": [ + "TCP" + ] + }, + { + "name": "L4-traffic-with-FQDN", + "description": "Block traffic based on source IPs and ports to amazon", + "sourceAddresses": [ + "10.2.4.12-10.2.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationFqdns": [ + "www.amazon.com" + ], + "protocols": [ + "TCP" + ] + } + ] + } + } + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } + } + } + } + } +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json index 0f5c66eb1dac..e0e8b5193e5c 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json @@ -171,9 +171,10 @@ ] } } - ] + ], + "additionalProperties": {} } } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json index c3e1d550083f..fadb336b1f35 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json @@ -164,11 +164,15 @@ ] } } - ] + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } } } ] } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json index 0f5287245681..cae657db8062 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json @@ -163,11 +163,15 @@ ] } } - ] + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } } } ] } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json index 24a1cd6aa037..f87bd9b18b54 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json @@ -321,7 +321,8 @@ ] } } - ] + ], + "additionalProperties": {} } } }, @@ -486,9 +487,10 @@ ] } } - ] + ], + "additionalProperties": {} } } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json index 2a4cfee38526..f724d75f299e 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json @@ -97,4 +97,4 @@ } } } -} +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json new file mode 100644 index 000000000000..66effe2bea4f --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json @@ -0,0 +1,506 @@ +{ + "parameters": { + "api-version": "2019-09-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "azureFirewallName": "azurefirewall", + "parameters": { + "tags": { + "key1": "value1" + }, + "location": "West US", + "zones": [], + "properties": { + "sku": { + "name": "AZFW_VNet", + "tier": "Standard" + }, + "threatIntelMode": "Alert", + "ipConfigurations": [ + { + "name": "azureFirewallIpConfiguration", + "properties": { + "subnet": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet" + }, + "publicIPAddress": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName" + } + } + } + ], + "applicationRuleCollections": [ + { + "name": "apprulecoll", + "properties": { + "priority": 110, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "rule1", + "description": "Deny inbound rule", + "protocols": [ + { + "protocolType": "Https", + "port": 443 + } + ], + "targetFqdns": [ + "www.test.com" + ], + "sourceAddresses": [ + "216.58.216.164", + "10.0.0.0/24" + ] + } + ] + } + } + ], + "natRuleCollections": [ + { + "name": "natrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Dnat" + }, + "rules": [ + { + "name": "DNAT-HTTPS-traffic", + "description": "D-NAT all outbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "443" + ], + "protocols": [ + "TCP" + ], + "translatedAddress": "1.2.3.5", + "translatedPort": "8443" + }, + { + "name": "DNAT-HTTP-traffic-With-FQDN", + "description": "D-NAT all inbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "80" + ], + "protocols": [ + "TCP" + ], + "translatedFqdn": "internalhttpserver", + "translatedPort": "880" + } + ] + } + } + ], + "networkRuleCollections": [ + { + "name": "netrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "L4-traffic", + "description": "Block traffic based on source IPs and ports", + "sourceAddresses": [ + "192.168.1.1-192.168.1.12", + "10.1.4.12-10.1.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationAddresses": [ + "*" + ], + "protocols": [ + "TCP" + ] + }, + { + "name": "L4-traffic-with-FQDN", + "description": "Block traffic based on source IPs and ports to amazon", + "sourceAddresses": [ + "10.2.4.12-10.2.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationFqdns": [ + "www.amazon.com" + ], + "protocols": [ + "TCP" + ] + } + ] + } + } + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } + } + } + }, + "responses": { + "200": { + "body": { + "name": "azurefirewall", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall", + "type": "Microsoft.Network/azureFirewalls", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "location": "West US", + "zones": [], + "tags": { + "key1": "value1" + }, + "properties": { + "provisioningState": "Succeeded", + "sku": { + "name": "AZFW_VNet", + "tier": "Standard" + }, + "threatIntelMode": "Alert", + "ipConfigurations": [ + { + "name": "azureFirewallIpConfiguration", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azfirewallgw/ipConfigurations/azureFirewallIpConfiguration", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "properties": { + "provisioningState": "Succeeded", + "privateIPAddress": "10.0.0.0", + "subnet": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet" + }, + "publicIPAddress": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName" + } + } + } + ], + "applicationRuleCollections": [ + { + "name": "apprulecoll", + "properties": { + "priority": 110, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "rule1", + "description": "Deny inbound rule", + "protocols": [ + { + "protocolType": "Https", + "port": 443 + } + ], + "targetFqdns": [ + "www.test.com" + ], + "sourceAddresses": [ + "216.58.216.164", + "10.0.0.0/24" + ] + } + ] + } + } + ], + "natRuleCollections": [ + { + "name": "natrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Dnat" + }, + "rules": [ + { + "name": "DNAT-HTTPS-traffic", + "description": "D-NAT all outbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "443" + ], + "protocols": [ + "TCP" + ], + "translatedAddress": "1.2.3.5", + "translatedPort": "8443" + }, + { + "name": "DNAT-HTTP-traffic-With-FQDN", + "description": "D-NAT all inbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "80" + ], + "protocols": [ + "TCP" + ], + "translatedPort": "880", + "translatedFqdn": "internalhttpserver" + } + ] + } + } + ], + "networkRuleCollections": [ + { + "name": "netrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "L4-traffic", + "description": "Block traffic based on source IPs and ports", + "sourceAddresses": [ + "192.168.1.1-192.168.1.12", + "10.1.4.12-10.1.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationAddresses": [ + "*" + ], + "protocols": [ + "TCP" + ] + }, + { + "name": "L4-traffic-with-FQDN", + "description": "Block traffic based on source IPs and ports to amazon", + "sourceAddresses": [ + "10.2.4.12-10.2.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "protocols": [ + "TCP" + ], + "destinationFqdns": [ + "www.amazon.com" + ] + } + ] + } + } + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } + } + } + }, + "201": { + "body": { + "name": "azurefirewall", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall", + "type": "Microsoft.Network/azureFirewalls", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "location": "West US", + "zones": [], + "tags": { + "key1": "value1" + }, + "properties": { + "provisioningState": "Succeeded", + "sku": { + "name": "AZFW_VNet", + "tier": "Standard" + }, + "threatIntelMode": "Alert", + "ipConfigurations": [ + { + "name": "azureFirewallIpConfiguration", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azfirewallgw/ipConfigurations/azureFirewallIpConfiguration", + "etag": "w/\\00000000-0000-0000-0000-000000000000\\", + "properties": { + "provisioningState": "Succeeded", + "privateIPAddress": "10.0.0.0", + "subnet": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet2/subnets/AzureFirewallSubnet" + }, + "publicIPAddress": { + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/pipName" + } + } + } + ], + "applicationRuleCollections": [ + { + "name": "apprulecoll", + "properties": { + "priority": 110, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "rule1", + "description": "Deny inbound rule", + "protocols": [ + { + "protocolType": "Https", + "port": 443 + } + ], + "targetFqdns": [ + "www.test.com" + ], + "sourceAddresses": [ + "216.58.216.164", + "10.0.0.0/24" + ] + } + ] + } + } + ], + "natRuleCollections": [ + { + "name": "natrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Dnat" + }, + "rules": [ + { + "name": "DNAT-HTTPS-traffic", + "description": "D-NAT all outbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "443" + ], + "protocols": [ + "TCP" + ], + "translatedAddress": "1.2.3.5", + "translatedPort": "8443" + }, + { + "name": "DNAT-HTTP-traffic-With-FQDN", + "description": "D-NAT all inbound web traffic for inspection", + "sourceAddresses": [ + "*" + ], + "destinationAddresses": [ + "1.2.3.4" + ], + "destinationPorts": [ + "80" + ], + "protocols": [ + "TCP" + ], + "translatedFqdn": "internalhttpserver", + "translatedPort": "880" + } + ] + } + } + ], + "networkRuleCollections": [ + { + "name": "netrulecoll", + "properties": { + "priority": 112, + "action": { + "type": "Deny" + }, + "rules": [ + { + "name": "L4-traffic", + "description": "Block traffic based on source IPs and ports", + "sourceAddresses": [ + "192.168.1.1-192.168.1.12", + "10.1.4.12-10.1.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationAddresses": [ + "*" + ], + "protocols": [ + "TCP" + ] + }, + { + "name": "L4-traffic-with-FQDN", + "description": "Block traffic based on source IPs and ports to amazon", + "sourceAddresses": [ + "10.2.4.12-10.2.4.255" + ], + "destinationPorts": [ + "443-444", + "8443" + ], + "destinationFqdns": [ + "www.amazon.com" + ], + "protocols": [ + "TCP" + ] + } + ] + } + } + ], + "additionalProperties": { + "key1": "value1", + "key2": "value2" + } + } + } + } + } +} \ No newline at end of file diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json index 95e739257009..b027c5209966 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json @@ -329,7 +329,8 @@ ] } } - ] + ], + "additionalProperties": {} } } }, @@ -498,9 +499,10 @@ ] } } - ] + ], + "additionalProperties": {} } } } } -} +} \ No newline at end of file From 5135f47fef0f3049db2da40f40db732ac82effbf Mon Sep 17 00:00:00 2001 From: Jiejiong Wu Date: Thu, 17 Oct 2019 14:39:18 -0700 Subject: [PATCH 2/5] edit AzureFirewallPutInHub --- .../stable/2019-09-01/examples/AzureFirewallPutInHub.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json index f724d75f299e..cc73a13adb7a 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json @@ -57,7 +57,8 @@ } ], "privateIPAddress": "10.0.0.0" - } + }, + "additionalProperties": {} } } }, @@ -92,7 +93,8 @@ } ], "privateIPAddress": "10.0.0.0" - } + }, + "additionalProperties": {} } } } From f943d783c63eb1747bf41d4e014e01f2fb33f38c Mon Sep 17 00:00:00 2001 From: Jiejiong Wu Date: Thu, 17 Oct 2019 14:42:34 -0700 Subject: [PATCH 3/5] restore trailing newline --- .../Microsoft.Network/stable/2019-09-01/azureFirewall.json | 6 +++--- .../stable/2019-09-01/examples/AzureFirewallGet.json | 2 +- .../examples/AzureFirewallGetWithAdditionalProperties.json | 2 +- .../2019-09-01/examples/AzureFirewallGetWithZones.json | 2 +- .../examples/AzureFirewallListByResourceGroup.json | 2 +- .../examples/AzureFirewallListBySubscription.json | 2 +- .../stable/2019-09-01/examples/AzureFirewallPut.json | 2 +- .../stable/2019-09-01/examples/AzureFirewallPutInHub.json | 2 +- .../examples/AzureFirewallPutWithAdditionalProperties.json | 2 +- .../2019-09-01/examples/AzureFirewallPutWithZones.json | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json index c10d2454dad1..10346d879436 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json @@ -891,9 +891,9 @@ "destinationIpGroups": { "type": "array", "description": "List of destination IpGroups for this rule.", - "items": { + "items": { "type": "string" - } + } } }, "description": "Properties of the network rule." @@ -975,4 +975,4 @@ "description": "SKU of an Azure Firewall." } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json index cde2c3c32ea8..62df8a96d76f 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGet.json @@ -173,4 +173,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json index d4d908a68615..ce99ff9b08f9 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithAdditionalProperties.json @@ -176,4 +176,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json index e0e8b5193e5c..27a47d7d27fa 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallGetWithZones.json @@ -177,4 +177,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json index fadb336b1f35..db50d51f4c18 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListByResourceGroup.json @@ -175,4 +175,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json index cae657db8062..d97ba6774d0a 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallListBySubscription.json @@ -174,4 +174,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json index f87bd9b18b54..df53e54cfdbb 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPut.json @@ -493,4 +493,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json index cc73a13adb7a..1ce7938e2cf9 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json @@ -99,4 +99,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json index 66effe2bea4f..77dd548bbe9e 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithAdditionalProperties.json @@ -503,4 +503,4 @@ } } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json index b027c5209966..661caaaf2b82 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutWithZones.json @@ -505,4 +505,4 @@ } } } -} \ No newline at end of file +} From 405708c1b265964684d504f678255b24726884e4 Mon Sep 17 00:00:00 2001 From: Jiejiong Wu Date: Thu, 17 Oct 2019 14:58:00 -0700 Subject: [PATCH 4/5] change hub example --- .../stable/2019-09-01/examples/AzureFirewallPutInHub.json | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json index 1ce7938e2cf9..2a4cfee38526 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json @@ -57,8 +57,7 @@ } ], "privateIPAddress": "10.0.0.0" - }, - "additionalProperties": {} + } } } }, @@ -93,8 +92,7 @@ } ], "privateIPAddress": "10.0.0.0" - }, - "additionalProperties": {} + } } } } From a29f1eb643b3e984a9abc11487f6cf66c767d52e Mon Sep 17 00:00:00 2001 From: Jiejiong Wu Date: Sat, 19 Oct 2019 15:47:26 -0700 Subject: [PATCH 5/5] update hub situation --- .../stable/2019-09-01/examples/AzureFirewallPutInHub.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json index 2a4cfee38526..1ce7938e2cf9 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/examples/AzureFirewallPutInHub.json @@ -57,7 +57,8 @@ } ], "privateIPAddress": "10.0.0.0" - } + }, + "additionalProperties": {} } } }, @@ -92,7 +93,8 @@ } ], "privateIPAddress": "10.0.0.0" - } + }, + "additionalProperties": {} } } }