From 6053c478526f3f08ed0f46fbd85d502aacb1565f Mon Sep 17 00:00:00 2001 From: nomigori96 Date: Thu, 12 Sep 2019 17:47:35 +0300 Subject: [PATCH 1/3] Changes to the JIT API to allow initiating a jit request with a justification. --- .../2015-06-01-preview/jitNetworkAccessPolicies.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json index 6d6761379c4a..18ebf026ef24 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json @@ -551,6 +551,10 @@ "requestor": { "type": "string", "description": "The identity of the person who made the request" + }, + "justification": { + "type": "string", + "description": "The justification for making the initiate request" } }, "required": [ @@ -667,6 +671,10 @@ "items": { "$ref": "#/definitions/JitNetworkAccessPolicyInitiateVirtualMachine" } + }, + "justification": { + "type": "string", + "description": "The justification for making the initiate request" } }, "required": [ From 9868d2c384a02796e7ba45e199bc3dbd46a335cb Mon Sep 17 00:00:00 2001 From: nomigori96 Date: Mon, 16 Sep 2019 09:07:43 +0300 Subject: [PATCH 2/3] fixing the indentation --- .../preview/2015-06-01-preview/jitNetworkAccessPolicies.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json index 18ebf026ef24..ee9dac388a89 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/jitNetworkAccessPolicies.json @@ -552,7 +552,7 @@ "type": "string", "description": "The identity of the person who made the request" }, - "justification": { + "justification": { "type": "string", "description": "The justification for making the initiate request" } @@ -672,7 +672,7 @@ "$ref": "#/definitions/JitNetworkAccessPolicyInitiateVirtualMachine" } }, - "justification": { + "justification": { "type": "string", "description": "The justification for making the initiate request" } From 3be7797b60cb2c679ae773a49d22b6ca92e7e3ce Mon Sep 17 00:00:00 2001 From: nomigori96 Date: Mon, 23 Sep 2019 10:26:13 +0300 Subject: [PATCH 3/3] updating the examples --- ...tNetworkAccessPoliciesResourceGroupLocation_example.json | 3 ++- .../GetJitNetworkAccessPoliciesResourceGroup_example.json | 3 ++- ...itNetworkAccessPoliciesSubscriptionLocation_example.json | 3 ++- .../GetJitNetworkAccessPoliciesSubscription_example.json | 3 ++- .../GetJitNetworkAccessPolicy_example.json | 3 ++- .../InitiateJitNetworkAccessPolicy_example.json | 6 ++++-- 6 files changed, 14 insertions(+), 7 deletions(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroupLocation_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroupLocation_example.json index f933c5338620..16eb695cffc3 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroupLocation_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroupLocation_example.json @@ -48,7 +48,8 @@ } ], "startTimeUtc": "2018-05-17T08:06:45.5691611Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } ], "provisioningState": "Succeeded" diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroup_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroup_example.json index ce6b956f44a7..8a7225c11d64 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroup_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesResourceGroup_example.json @@ -47,7 +47,8 @@ } ], "startTimeUtc": "2018-05-17T08:06:45.5691611Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } ], "provisioningState": "Succeeded" diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscriptionLocation_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscriptionLocation_example.json index 082e8d9b3a9d..20202c49a112 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscriptionLocation_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscriptionLocation_example.json @@ -47,7 +47,8 @@ } ], "startTimeUtc": "2018-05-17T08:06:45.5691611Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } ], "provisioningState": "Succeeded" diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscription_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscription_example.json index 2681f4c7d255..e1b5c321dd60 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscription_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPoliciesSubscription_example.json @@ -46,7 +46,8 @@ } ], "startTimeUtc": "2018-05-17T08:06:45.5691611Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } ], "provisioningState": "Succeeded" diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPolicy_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPolicy_example.json index 253dabcb7421..25e099198fdf 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPolicy_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/GetJitNetworkAccessPolicy_example.json @@ -47,7 +47,8 @@ } ], "startTimeUtc": "2018-05-17T08:06:45.5691611Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } ], "provisioningState": "Succeeded" diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/InitiateJitNetworkAccessPolicy_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/InitiateJitNetworkAccessPolicy_example.json index 833fc2eff3b7..162617ae7e79 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/InitiateJitNetworkAccessPolicy_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/InitiateJitNetworkAccessPolicy_example.json @@ -18,7 +18,8 @@ } ] } - ] + ], + "justification": "testing a new version of the product" } }, "responses": { @@ -39,7 +40,8 @@ } ], "startTimeUtc": "2018-07-12T08:53:03.3658798Z", - "requestor": "barbara@contoso.com" + "requestor": "barbara@contoso.com", + "justification": "testing a new version of the product" } } }