Skip to content

Conversation

@msabansal
Copy link
Contributor

@msabansal msabansal commented Aug 26, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.
    Added documentation for this missing PATCH api call for bastionhost resource

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 26, 2019

In Testing, Please Ignore

[Logs] (Generated from 526b783, Iteration 5)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Aug 26, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpry8k21ow/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpry8k21ow/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[6622:0x3340cc0]    70428 ms: Mark-sweep 1375.9 (1426.3) -> 1375.8 (1426.8) MB, 1448.8 / 0.0 ms  (average mu = 0.130, current mu = 0.002) allocation failure GC in old space requested
[6622:0x3340cc0]    71835 ms: Mark-sweep 1376.1 (1426.8) -> 1376.0 (1427.3) MB, 1404.9 / 0.0 ms  (average mu = 0.068, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x24b2ba95be1d]
Security context: 0x11850aa1e6e9 <JSObject>
    1: newScalar [0xfb5a3059531] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x24b2babfcc96](this=0x3c5c85d257e9 <Object map = 0x321f31f32459>,v=0x06dbb1c026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0xfb5a3059411] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc=...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x24b2ba95be1d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 27, 2019

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 306, in generate_sdk_from_git_object
    commit_sha = do_commit(sdk_repo, message, branch_name, commit_for_sha.sha)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/git_tools.py", line 44, in do_commit
    msg = message_template.format(hexsha=hexsha)
ValueError: Single '}' encountered in format string

@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 29, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2019
@tjprescott tjprescott merged commit e6344a9 into Azure:master Sep 3, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
* first commit previous API

* second commit with new API

* adding examples

* changes to Readme and customword

* changes to Readme

* changes to Readme

* changes to Readme

* adding examples

* changes to Readme

Co-authored-by: Zainudeen Veetikadam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants