Skip to content

Conversation

@nschonni
Copy link
Contributor

  • Add "body" to response
  • createGroupRequest -> createManagementGroupRequest

- Add "body" to response
- createGroupRequest -> createManagementGroupRequest
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2019

SDK Automation [Logs] (Generated from 32f078b, Iteration 1)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/managementgroups/azure-mgmt-managementgroups [Logs]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • Failed managementgroups/resource-manager/v2017_08_31_preview [Logs]
  • Failed managementgroups/resource-manager/v2017_11_01_preview [Logs]
  • Failed managementgroups/resource-manager/v2018_01_01_preview [Logs]
  • Failed managementgroups/resource-manager/v2018_03_01_preview [Logs]
Failed Go: Azure/azure-sdk-for-go [Logs] [Diff]
  • Failed preview/resources/mgmt/2017-08-31-preview [Logs]
  • Failed preview/resources/mgmt/2017-11-01-preview [Logs]
  • Failed preview/resources/mgmt/2018-01-01-preview [Logs]
  • Failed preview/resources/mgmt/2018-03-01-preview [Logs]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Failed @azure/arm-managementgroups [Logs]

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 22, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@erich-wang
Copy link
Member

@nschonni , thank you for creating the PR. May I ask how do you find this issue? It seems our validation tool did not detect the issue.

@raych1 , @michaeljqzq to check whether it is a bug in validation tool.

@raych1
Copy link
Member

raych1 commented Jul 23, 2019

@erich-wang , model validation would not be triggered if there's no swagger spec change in the PR. That's why the check pass this time.
Actually this PR provides the fix to some examples which would fail by the new change released in model validation tool.
Here's the example error raised by new version of model validation tool.

{ message:
   'Validating "examples" and "x-ms-examples" in  D:/git/github/oav/azure-rest-api-specs/specification/managementgroups/resource-manager/Microsoft.Management/preview/2018-01-01-preview/management.json:\n',
  level: '\u001b[32minfo\u001b[39m' }
{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message:
   'Found errors in validating the request for x-ms-example "PutManagementGroup" in operation "ManagementGroups_CreateOrUpdate".:\nFound errors in validating the request for x-ms-example "PutManagementGroup" in operation "ManagementGroups_CreateOrUpdate".',
  innerErrors:
   [ { code: 'REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND',
       id: 'OAV105',
       message:
        'In operation "ManagementGroups_CreateOrUpdate", parameter createManagementGroupRequest is required in the swagger spec but is not present in the provided example parameter values.',
       position: { line: 162, column: 11 },
       url:
        'D:/git/github/oav/azure-rest-api-specs/specification/managementgroups/resource-manager/Microsoft.Management/preview/2018-01-01-preview/management.json',
       title:
        '#/paths/~1providers~1Microsoft.Management~1managementGroups~1{groupId}/put/parameters/3',
       directives: {} } ],
  level: '\u001b[31merror\u001b[39m' }

@erich-wang erich-wang merged commit 9dd05d3 into Azure:master Jul 24, 2019
@nschonni nschonni deleted the fix--managementgroups-model-validation branch July 24, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants