Skip to content

Conversation

@leizhaoPS
Copy link
Contributor

@leizhaoPS leizhaoPS commented Jul 17, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2019

SDK Automation [Logs] (Generated from 05289eb, Iteration 7)

Failed Go: Azure/azure-sdk-for-go [Logs] [Diff]
  • Failed machinelearningservices/mgmt/2018-11-19 [Logs]
  • Failed machinelearningservices/mgmt/2019-05-01 [Logs]
  • Failed preview/machinelearningservices/mgmt/2018-03-01-preview [Logs]
Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/machinelearning/azure-mgmt-machinelearningservices [Logs]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • Failed @azure/arm-machinelearningservices [Logs]

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6396

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 17, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5286

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leizhaoPS
Copy link
Contributor Author

@raych1 , please help merge the PR to master branch, we need check in this as soon as possible. Thanks a lot!

@leizhaoPS
Copy link
Contributor Author

@raych1 , Thanks for the quick response, I am really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants