From 9e81cfc37f6aa9569eb1674b337564eb7ba32a4a Mon Sep 17 00:00:00 2001 From: Gaurav Bhatnagar Date: Mon, 26 Nov 2018 14:55:13 -0800 Subject: [PATCH] Adding ARM section to the template This will help service teams be better informed about the ARM API review process and add the required labels. --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e453a4fc63bc..dd2afd20e710 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,3 +5,13 @@ - [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow. - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. - [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps. +### ARM API Review Checklist +- [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. +- adding/removing APIs. +- adding/removing properties. +- adding/removing API-version. +- adding a new service in Azure. + +Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs. +- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. +Please follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).