From 8b7b9f4b3251201ef604b1251111b6f74b5eb2ae Mon Sep 17 00:00:00 2001 From: Arthur Ma Date: Fri, 27 Mar 2026 15:16:49 +0800 Subject: [PATCH] Add C# clientName decorators for EastWestGatewayVisibility and AKS acronym Add two @@clientName decorators in client.tsp for the C# SDK: 1. EastWestGatewayVisibility -> AppLinkEastWestGatewayVisibility (contextual naming: add AppLink prefix for service context) 2. ClusterType.AKS -> Aks (PascalCase convention: 3+ letter acronyms use PascalCase) These address remaining naming issues from the C# SDK review of Azure/azure-sdk-for-net#57448. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- specification/applink/AppLink.Management/client.tsp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specification/applink/AppLink.Management/client.tsp b/specification/applink/AppLink.Management/client.tsp index a210b75f5886..7df799e848fb 100644 --- a/specification/applink/AppLink.Management/client.tsp +++ b/specification/applink/AppLink.Management/client.tsp @@ -7,23 +7,23 @@ namespace Microsoft.AppLink; @@clientName(Microsoft.AppLink, "AppNetworkMgmtClient", "python"); -// Fix selfManagedVersions flattening name collision in C# @@clientName(AvailableVersionProperties.selfManagedVersions, "selfManagedVersionDetail", "csharp" ); -// Contextual naming: add AppLink prefix to avoid cross-SDK collisions in C# @@clientName(ProvisioningState, "AppLinkProvisioningState", "csharp"); @@clientName(ClusterType, "AppLinkClusterType", "csharp"); +@@clientName(EastWestGatewayVisibility, + "AppLinkEastWestGatewayVisibility", + "csharp" +); @@clientName(UpgradeMode, "AppLinkUpgradeMode", "csharp"); @@clientName(UpgradeReleaseChannel, "AppLinkUpgradeReleaseChannel", "csharp"); @@clientName(ConnectivityProfile, "AppLinkConnectivityProfile", "csharp"); @@clientName(UpgradeProfile, "AppLinkUpgradeProfile", "csharp"); @@clientName(ReleaseChannelInfo, "AppLinkReleaseChannelInfo", "csharp"); @@clientName(VersionInfo, "AppLinkVersionInfo", "csharp"); - -// Contextual naming: add AppLink prefix to resource types @@clientName(AvailableVersion, "AppLinkAvailableVersion", "csharp"); @@clientName(AvailableVersionProperties, "AppLinkAvailableVersionProperties", @@ -35,7 +35,6 @@ namespace Microsoft.AppLink; "csharp" ); -// Operation renames: method names should clearly indicate what is listed @@clientName(AvailableVersions.listByLocation, "GetAppLinkAvailableVersionsByLocation", "csharp" @@ -45,10 +44,11 @@ namespace Microsoft.AppLink; "csharp" ); -// DateTimeOffset properties should follow *On naming convention in C# @@clientName(UpgradeHistoryProperties.startTimestamp, "startOn", "csharp"); @@clientName(UpgradeHistoryProperties.endTimestamp, "endOn", "csharp"); +@@clientName(ClusterType.AKS, "Aks", "csharp"); + @doc("The type used for update operations of the AppLink.") model AppLinkUpdate { #suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"